Re: [PATCH] perf/x86/intel: Add counter freezing quirk for Goldmont

Liang, Kan
2018-10-03T14:25:08Z

On 10/3/2018 10:15 AM, linux-kernel-owner@vger.kernel.org wrote:
> To make it more generic, I think we also need to extend the struct
> sku_microcode to check vendor and family.
> The "model" in struct x86_cpu_id is u16. I will also change "model" and
> "stepping" to u16.
>
> struct sku_microcode {
>     u16 vendor;
>     u16 family;
>     u16 model;
>     u16 stepping;
>     u32 microcode;
> };

No, should be consistent as struct cpuinfo_x86.
The struct sku_microcode should be

struct sku_microcode {
u8 vendor;
u8 family;
u8 model;
u8 stepping;
u32 microcode;
};

Thanks,
Kan