public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Liu Lucas/刘保柱" <lucas.liu@siengine.com>
To: "Liu Lucas/刘保柱" <lucas.liu@siengine.com>,
	"liviu.dudau@arm.com" <liviu.dudau@arm.com>,
	"airlied@gmail.com" <airlied@gmail.com>,
	"daniel@ffwll.ch" <daniel@ffwll.ch>
Cc: "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 回复: [PATCH] drm/komeda: add NV12 format to support writeback layer type
Date: Fri, 8 Sep 2023 08:11:44 +0000	[thread overview]
Message-ID: <b393669c80274dfcbcf94c60fea8ae76@siengine.com> (raw)
In-Reply-To: <20230829093004.22860-1-lucas.liu@siengine.com>

Hi  all,

	Do you have any suggestions for the patch I submitted? Please also let me know, thank you!

Best Regards,
baozhu.liu
-----邮件原件-----
发件人: baozhu.liu <lucas.liu@siengine.com> 
发送时间: 2023年8月29日 17:30
收件人: liviu.dudau@arm.com; airlied@gmail.com; daniel@ffwll.ch
抄送: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Liu Lucas/刘保柱 <lucas.liu@siengine.com>
主题: [PATCH] drm/komeda: add NV12 format to support writeback layer type

When testing the d71 writeback layer function, the output format is set to NV12, and the following error message is displayed:

[drm:komeda_fb_is_layer_supported] Layer TYPE: 4 doesn't support fb FMT: NV12 little-endian (0x3231564e) with modifier: 0x0..

Check the d71 data manual, writeback layer output formats includes NV12 format.

Signed-off-by: baozhu.liu <lucas.liu@siengine.com>
---
 drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
index 6c56f5662bc7..80973975bfdb 100644
--- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
+++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
@@ -521,7 +521,7 @@ static struct komeda_format_caps d71_format_caps_table[] = {
 	{__HW_ID(5, 1),	DRM_FORMAT_YUYV,	RICH,		Rot_ALL_H_V,	LYT_NM, AFB_TH}, /* afbc */
 	{__HW_ID(5, 2),	DRM_FORMAT_YUYV,	RICH,		Flip_H_V,		0, 0},
 	{__HW_ID(5, 3),	DRM_FORMAT_UYVY,	RICH,		Flip_H_V,		0, 0},
-	{__HW_ID(5, 6),	DRM_FORMAT_NV12,	RICH,		Flip_H_V,		0, 0},
+	{__HW_ID(5, 6),	DRM_FORMAT_NV12,	RICH_WB,	Flip_H_V,		0, 0},
 	{__HW_ID(5, 6),	DRM_FORMAT_YUV420_8BIT,	RICH,		Rot_ALL_H_V,	LYT_NM, AFB_TH}, /* afbc */
 	{__HW_ID(5, 7),	DRM_FORMAT_YUV420,	RICH,		Flip_H_V,		0, 0},
 	/* YUV 10bit*/
--
2.17.1


  reply	other threads:[~2023-09-08  8:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-29  9:30 [PATCH] drm/komeda: add NV12 format to support writeback layer type baozhu.liu
2023-09-08  8:11 ` Liu Lucas/刘保柱 [this message]
2023-09-11 14:46   ` 回复: " liviu.dudau
2023-09-12 12:52     ` 回复: " Liu Lucas/刘保柱

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b393669c80274dfcbcf94c60fea8ae76@siengine.com \
    --to=lucas.liu@siengine.com \
    --cc=airlied@gmail.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox