* [PATCH] drm/komeda: add NV12 format to support writeback layer type @ 2023-08-29 9:30 baozhu.liu 2023-09-08 8:11 ` 回复: " Liu Lucas/刘保柱 0 siblings, 1 reply; 4+ messages in thread From: baozhu.liu @ 2023-08-29 9:30 UTC (permalink / raw) To: liviu.dudau, airlied, daniel; +Cc: dri-devel, linux-kernel, baozhu.liu When testing the d71 writeback layer function, the output format is set to NV12, and the following error message is displayed: [drm:komeda_fb_is_layer_supported] Layer TYPE: 4 doesn't support fb FMT: NV12 little-endian (0x3231564e) with modifier: 0x0.. Check the d71 data manual, writeback layer output formats includes NV12 format. Signed-off-by: baozhu.liu <lucas.liu@siengine.com> --- drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c index 6c56f5662bc7..80973975bfdb 100644 --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c @@ -521,7 +521,7 @@ static struct komeda_format_caps d71_format_caps_table[] = { {__HW_ID(5, 1), DRM_FORMAT_YUYV, RICH, Rot_ALL_H_V, LYT_NM, AFB_TH}, /* afbc */ {__HW_ID(5, 2), DRM_FORMAT_YUYV, RICH, Flip_H_V, 0, 0}, {__HW_ID(5, 3), DRM_FORMAT_UYVY, RICH, Flip_H_V, 0, 0}, - {__HW_ID(5, 6), DRM_FORMAT_NV12, RICH, Flip_H_V, 0, 0}, + {__HW_ID(5, 6), DRM_FORMAT_NV12, RICH_WB, Flip_H_V, 0, 0}, {__HW_ID(5, 6), DRM_FORMAT_YUV420_8BIT, RICH, Rot_ALL_H_V, LYT_NM, AFB_TH}, /* afbc */ {__HW_ID(5, 7), DRM_FORMAT_YUV420, RICH, Flip_H_V, 0, 0}, /* YUV 10bit*/ -- 2.17.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* 回复: [PATCH] drm/komeda: add NV12 format to support writeback layer type 2023-08-29 9:30 [PATCH] drm/komeda: add NV12 format to support writeback layer type baozhu.liu @ 2023-09-08 8:11 ` Liu Lucas/刘保柱 2023-09-11 14:46 ` liviu.dudau 0 siblings, 1 reply; 4+ messages in thread From: Liu Lucas/刘保柱 @ 2023-09-08 8:11 UTC (permalink / raw) To: Liu Lucas/刘保柱, liviu.dudau@arm.com, airlied@gmail.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Hi all, Do you have any suggestions for the patch I submitted? Please also let me know, thank you! Best Regards, baozhu.liu -----邮件原件----- 发件人: baozhu.liu <lucas.liu@siengine.com> 发送时间: 2023年8月29日 17:30 收件人: liviu.dudau@arm.com; airlied@gmail.com; daniel@ffwll.ch 抄送: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Liu Lucas/刘保柱 <lucas.liu@siengine.com> 主题: [PATCH] drm/komeda: add NV12 format to support writeback layer type When testing the d71 writeback layer function, the output format is set to NV12, and the following error message is displayed: [drm:komeda_fb_is_layer_supported] Layer TYPE: 4 doesn't support fb FMT: NV12 little-endian (0x3231564e) with modifier: 0x0.. Check the d71 data manual, writeback layer output formats includes NV12 format. Signed-off-by: baozhu.liu <lucas.liu@siengine.com> --- drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c index 6c56f5662bc7..80973975bfdb 100644 --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c @@ -521,7 +521,7 @@ static struct komeda_format_caps d71_format_caps_table[] = { {__HW_ID(5, 1), DRM_FORMAT_YUYV, RICH, Rot_ALL_H_V, LYT_NM, AFB_TH}, /* afbc */ {__HW_ID(5, 2), DRM_FORMAT_YUYV, RICH, Flip_H_V, 0, 0}, {__HW_ID(5, 3), DRM_FORMAT_UYVY, RICH, Flip_H_V, 0, 0}, - {__HW_ID(5, 6), DRM_FORMAT_NV12, RICH, Flip_H_V, 0, 0}, + {__HW_ID(5, 6), DRM_FORMAT_NV12, RICH_WB, Flip_H_V, 0, 0}, {__HW_ID(5, 6), DRM_FORMAT_YUV420_8BIT, RICH, Rot_ALL_H_V, LYT_NM, AFB_TH}, /* afbc */ {__HW_ID(5, 7), DRM_FORMAT_YUV420, RICH, Flip_H_V, 0, 0}, /* YUV 10bit*/ -- 2.17.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: 回复: [PATCH] drm/komeda: add NV12 format to support writeback layer type 2023-09-08 8:11 ` 回复: " Liu Lucas/刘保柱 @ 2023-09-11 14:46 ` liviu.dudau 2023-09-12 12:52 ` 回复: " Liu Lucas/刘保柱 0 siblings, 1 reply; 4+ messages in thread From: liviu.dudau @ 2023-09-11 14:46 UTC (permalink / raw) To: Liu Lucas/刘保柱 Cc: airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Hi Liu, Sorry about the delay, I was on holiday until 28th and while cleaning up the backlog I've accidentally marked the email as read and did not reply. On Fri, Sep 08, 2023 at 08:11:44AM +0000, Liu Lucas/刘保柱 wrote: > Hi all, > > Do you have any suggestions for the patch I submitted? Please also let me know, thank you! > > Best Regards, > baozhu.liu > -----邮件原件----- > 发件人: baozhu.liu <lucas.liu@siengine.com> > 发送时间: 2023年8月29日 17:30 > 收件人: liviu.dudau@arm.com; airlied@gmail.com; daniel@ffwll.ch > 抄送: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Liu Lucas/刘保柱 <lucas.liu@siengine.com> > 主题: [PATCH] drm/komeda: add NV12 format to support writeback layer type > > When testing the d71 writeback layer function, the output format is set to NV12, and the following error message is displayed: > > [drm:komeda_fb_is_layer_supported] Layer TYPE: 4 doesn't support fb FMT: NV12 little-endian (0x3231564e) with modifier: 0x0.. > > Check the d71 data manual, writeback layer output formats includes NV12 format. > > Signed-off-by: baozhu.liu <lucas.liu@siengine.com> Acked-by: Liviu Dudau <liviu.dudau@arm.com> I will push the patch this week into drm-misc-next. Best regards, Liviu > --- > drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c > index 6c56f5662bc7..80973975bfdb 100644 > --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c > +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c > @@ -521,7 +521,7 @@ static struct komeda_format_caps d71_format_caps_table[] = { > {__HW_ID(5, 1), DRM_FORMAT_YUYV, RICH, Rot_ALL_H_V, LYT_NM, AFB_TH}, /* afbc */ > {__HW_ID(5, 2), DRM_FORMAT_YUYV, RICH, Flip_H_V, 0, 0}, > {__HW_ID(5, 3), DRM_FORMAT_UYVY, RICH, Flip_H_V, 0, 0}, > - {__HW_ID(5, 6), DRM_FORMAT_NV12, RICH, Flip_H_V, 0, 0}, > + {__HW_ID(5, 6), DRM_FORMAT_NV12, RICH_WB, Flip_H_V, 0, 0}, > {__HW_ID(5, 6), DRM_FORMAT_YUV420_8BIT, RICH, Rot_ALL_H_V, LYT_NM, AFB_TH}, /* afbc */ > {__HW_ID(5, 7), DRM_FORMAT_YUV420, RICH, Flip_H_V, 0, 0}, > /* YUV 10bit*/ > -- > 2.17.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ ^ permalink raw reply [flat|nested] 4+ messages in thread
* 回复: 回复: [PATCH] drm/komeda: add NV12 format to support writeback layer type 2023-09-11 14:46 ` liviu.dudau @ 2023-09-12 12:52 ` Liu Lucas/刘保柱 0 siblings, 0 replies; 4+ messages in thread From: Liu Lucas/刘保柱 @ 2023-09-12 12:52 UTC (permalink / raw) To: liviu.dudau@arm.com Cc: airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Hi Liviu, Thank you so much for reviewing this patch! I expect this patch to be merged. Best Regards, baozhu.liu -----邮件原件----- 发件人: liviu.dudau@arm.com <liviu.dudau@arm.com> 发送时间: 2023年9月11日 22:46 收件人: Liu Lucas/刘保柱 <lucas.liu@siengine.com> 抄送: airlied@gmail.com; daniel@ffwll.ch; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org 主题: Re: 回复: [PATCH] drm/komeda: add NV12 format to support writeback layer type Hi Liu, Sorry about the delay, I was on holiday until 28th and while cleaning up the backlog I've accidentally marked the email as read and did not reply. On Fri, Sep 08, 2023 at 08:11:44AM +0000, Liu Lucas/刘保柱 wrote: > Hi all, > > Do you have any suggestions for the patch I submitted? Please also let me know, thank you! > > Best Regards, > baozhu.liu > -----邮件原件----- > 发件人: baozhu.liu <lucas.liu@siengine.com> > 发送时间: 2023年8月29日 17:30 > 收件人: liviu.dudau@arm.com; airlied@gmail.com; daniel@ffwll.ch > 抄送: dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; Liu > Lucas/刘保柱 <lucas.liu@siengine.com> > 主题: [PATCH] drm/komeda: add NV12 format to support writeback layer > type > > When testing the d71 writeback layer function, the output format is set to NV12, and the following error message is displayed: > > [drm:komeda_fb_is_layer_supported] Layer TYPE: 4 doesn't support fb FMT: NV12 little-endian (0x3231564e) with modifier: 0x0.. > > Check the d71 data manual, writeback layer output formats includes NV12 format. > > Signed-off-by: baozhu.liu <lucas.liu@siengine.com> Acked-by: Liviu Dudau <liviu.dudau@arm.com> I will push the patch this week into drm-misc-next. Best regards, Liviu > --- > drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c > b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c > index 6c56f5662bc7..80973975bfdb 100644 > --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c > +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c > @@ -521,7 +521,7 @@ static struct komeda_format_caps d71_format_caps_table[] = { > {__HW_ID(5, 1), DRM_FORMAT_YUYV, RICH, Rot_ALL_H_V, LYT_NM, AFB_TH}, /* afbc */ > {__HW_ID(5, 2), DRM_FORMAT_YUYV, RICH, Flip_H_V, 0, 0}, > {__HW_ID(5, 3), DRM_FORMAT_UYVY, RICH, Flip_H_V, 0, 0}, > - {__HW_ID(5, 6), DRM_FORMAT_NV12, RICH, Flip_H_V, 0, 0}, > + {__HW_ID(5, 6), DRM_FORMAT_NV12, RICH_WB, Flip_H_V, 0, 0}, > {__HW_ID(5, 6), DRM_FORMAT_YUV420_8BIT, RICH, Rot_ALL_H_V, LYT_NM, AFB_TH}, /* afbc */ > {__HW_ID(5, 7), DRM_FORMAT_YUV420, RICH, Flip_H_V, 0, 0}, > /* YUV 10bit*/ > -- > 2.17.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-12 12:53 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-08-29 9:30 [PATCH] drm/komeda: add NV12 format to support writeback layer type baozhu.liu 2023-09-08 8:11 ` 回复: " Liu Lucas/刘保柱 2023-09-11 14:46 ` liviu.dudau 2023-09-12 12:52 ` 回复: " Liu Lucas/刘保柱
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox