Re: [PATCH 3/3] arm64: dts: ti: k3-pinctrl: Add the remaining macros

[Akashdeep Kaur <a-kaur@ti.com>]

Hi Dhruva,

On 13/08/25 18:35, Dhruva Gole wrote:
> Akashdeep,
> 
...
>> Add the missing macros for deep sleep configuration control.
> 
> Please can you add sources/ links to the TRM/collateral and sections where you get
> all this information from?

Added TRM reference links
> 
>> Reword the existing deep sleep macros to provide combinations that can
>> directly be used in device tree files.
> 
> I am not very clear on what this line is trying to say. Can you explain
> a bit more with an example of a reword and how it is helping?
Added example
> 
>>
>> Signed-off-by: Akashdeep Kaur <a-kaur@ti.com>
...
>> +#define WKUP_LVL_EN_SHIFT	    (7)
>> +#define WKUP_LVL_POL_SHIFT	    (8)
>> +#define ST_EN_SHIFT		        (14)
>> +#define DRV_STR_SHIFT		    (19)
>> +#define DS_ISO_OVERRIDE_EN_SHIFT (22)
>> +#define DS_ISO_BYPASS_EN_SHIFT  (23)
> 
> Seeing it on lore and in my git log -p as well, the alignment looks off.
> Please fix it.
> 
Fixed
>>   
>>   /* Schmitt trigger configuration */
>>   #define ST_DISABLE		(0 << ST_EN_SHIFT)
...
>> +
>> +#define WKUP_DISABLE        (0 << WKUP_EN_SHIFT)
>> +
> 
> These too, fix all alignment issues please.
Fixed
> 
>>   /* Only these macros are expected be used directly in device tree files */
>>   #define PIN_OUTPUT		(INPUT_DISABLE | PULL_DISABLE)
...

Regards,
Akashdeep Kaur