From: "Bence Csókás" <bence98@sch.bme.hu>
To: Ian Ray <ian.ray@gehealthcare.com>,
Guenter Roeck <linux@roeck-us.net>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: "Tomaž Zaman" <tomaz@mono.si>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Krzysztof Kozlowski" <krzk@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH V2 3/3] hwmon: (ina2xx) Add support for INA234
Date: Thu, 19 Feb 2026 21:45:16 +0100 [thread overview]
Message-ID: <b3af6bd4-0a8a-47c2-90c8-b5b65f9b4701@sch.bme.hu> (raw)
In-Reply-To: <20260219130127.87901-4-ian.ray@gehealthcare.com>
Hi,
On 2/19/26 14:01, Ian Ray wrote:
> INA234 is register compatible to INA226 (excepting manufacturer and die
> or device id registers) but has different scaling.
>
> Signed-off-by: Ian Ray <ian.ray@gehealthcare.com>
I can indeed find `power_lsb_factor = 32` in an earlier datasheet, dated
2021... Perhaps the TI folks also got confused about the whole "shift
down the lower 4 bits" thing... Well, with the caveat that I don't have
the part, so I can't test it myself:
Reviewed-by: Bence Csókás <bence98@sch.bme.hu>
Bence
next prev parent reply other threads:[~2026-02-19 20:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-19 13:01 [PATCH V2 0/3] hwmon: INA234 Ian Ray
2026-02-19 13:01 ` [PATCH V2 1/3] dt-bindings: hwmon: ti,ina2xx: Add INA234 device Ian Ray
2026-02-19 13:01 ` [PATCH V2 2/3] hwmon: (ina2xx) Make it easier to add more devices Ian Ray
2026-02-19 15:59 ` Guenter Roeck
2026-02-19 20:44 ` Bence Csókás
2026-02-20 1:13 ` kernel test robot
2026-02-20 1:54 ` kernel test robot
2026-02-19 13:01 ` [PATCH V2 3/3] hwmon: (ina2xx) Add support for INA234 Ian Ray
2026-02-19 20:45 ` Bence Csókás [this message]
2026-02-21 7:02 ` [PATCH V2 0/3] hwmon: INA234 Jens Almer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3af6bd4-0a8a-47c2-90c8-b5b65f9b4701@sch.bme.hu \
--to=bence98@sch.bme.hu \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=ian.ray@gehealthcare.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tomaz@mono.si \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox