From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F02C3A6B60 for ; Wed, 8 Apr 2026 08:35:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775637358; cv=none; b=mcLtmL2OqF2xns2s6pMj/EvDJgE+SQcZGHLW4/YNY12/ZSG/KEEf4vSSfXvhgYfwfBNUZRIQNafJBhJkS/oX0PGOCFARmWnG9/y3qQizhj5Dixl7eewSzRkYQ4qSWHQS10KBxIaX1cg102DJ8Tl3xwZmWZfx6Q42532AdWY+rG8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775637358; c=relaxed/simple; bh=/j/mCKzNC16wLgMFAQX3HI7G9C2VVWHKb4dZodwbG30=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=my78K0StJGsMgwlDxFHKG/V5O5uNqUXAj7gTAM2v3eU4sr5fq0qGFaBKTmNy1XJUyNoLxgxHLs8Wwh8SGFT5ZIcu+5MPjBh/36G3g9W87SgGPBCM6z9IRep/BBq1zzyYphATeLizThbhV+Gpb8YXHyEFivR1f0qwdEn4DitZmy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ehVqOdBE; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ehVqOdBE" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4852b81c73aso50134135e9.3 for ; Wed, 08 Apr 2026 01:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775637354; x=1776242154; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v3TQJY5IlXJsbG9+wxNqKMgJ09GA4sRxRbi0tKG232I=; b=ehVqOdBEr1OP0RKwOob8OvZVNt5QHEkq93+8FZehX/CBNGzd3jrNcELBvZMnKj2CP3 /+BUiexQ4qBlFnELExQfwwpum3KRrjGn459QdSgTCuL3mT6lQ9+5qnCa1nE0mLyuYqX2 C0bV5DX2FIsC+3O5T+M4yhmbYi7MDuZUsw7y8k7U76Fmv8peYaDMhKuUvGHsEhlopANZ Bxnk+Fx9l8FZze5YXtObBQiJ4GTxoD5AAjlzBrQQu7wuSdv+7EOOcij34wYYgnv7K0ca S0o3tnjc1+x+t/lmVN3moYQEf57YQjftnae/4PVLsoO6gZnnZ1hUhkQf4v85ntCrbzli L5ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775637354; x=1776242154; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=v3TQJY5IlXJsbG9+wxNqKMgJ09GA4sRxRbi0tKG232I=; b=HCVnJt0jgJnDQ2WPjL5rDoX3jz9jiVbsfsYH84WrVUgOJOMzihZ0TsjWJiFCms+vPl Y3lscSfchs6sTrOtEHnjDMjJbsiRzjIfK8VtD/lYLOUOOWvhap3/HGCgC0rVekFUSpCc mfJSFlDIu23Hc3pP288j7gyiupJ3qL1pkHqx7FhMLmNHiCdXJO2veGMuzAniu/arvlOH d9BUtNo7GxiP70OZ444KrKKED0WxIYFn8Un8PMT82XjkiZiQ1dNv42x1hOIUTCkNgrrh 8TNobM4vlAH5n0XK25OSzHR8roGNpspSrtZttAhfWO7Zm2BAG6ICVFlx8mLf//RcuyrO GkLA== X-Forwarded-Encrypted: i=1; AJvYcCU1wei7PBFJ8TeHOy2+7c7HuegMQXuExCOEHvIFENOF79p22KjNQ/pI5CdbVQcmCQa6fCrZRxv9/HJW5Xg=@vger.kernel.org X-Gm-Message-State: AOJu0YxfMbCIN1Qqb0Ulhp71iZtYcdI1Utmq8PPv91lKOO/bL9vSavJF CnE2Tdx2T+90uFwxmmh2UmxGDXjrSryoFiJAyM1B6ugU/+OJyPdF/sAt X-Gm-Gg: AeBDietlBDj7rNU6x2vKbuLYesASfLmkI4wNmqcSMN37DrAtpVqH1o+4HXXNKNDZ3LV kUI3tuXdpK623Ug5VYn07KbP5vdUzsefMzweC3ITxKjLPQRA17eH0kKAD282OfG1bDj1nlQ09B1 G0qSnfya8YyJC1Z5z30Q0NBiMnGpt4rPiIdfbxlQIBtfEJ5I2bKHQTYMTfNuPWHjLUrmslfXHfI JoL+DIF0XA1HC7UYUpOJkCSvb0+mNyoTClLExDY0EWqUzBrub9H+dmnxBahTwG998MkV4Dzm7hk vuyQFwsZGmaommLkteZEZROb3XJc6yzt1bnK3WlEMpEUO3k+0IRWduHjTOFT0EjaTDJ9ApzoW9D rD47pEr+QGIFvMvvn1OtOO0NJbNV5pXWj4Dy/g6FWabpRGIbbfK34eyiwNt92F3u4c4bHSQlWk/ +60QKNuS5eE37lFZ7lT1ZU/ulYPhNrfx4NjYKMOt1rzlMpXdG63kXREUbYBsEejV16U6tMKKbNA x5gLqMmINJuwPmC6eb04sGX90ZZapnCcS3nDSVFn8NSVY1xlLAytVLO55k= X-Received: by 2002:a05:600c:4b23:b0:488:a723:ea53 with SMTP id 5b1f17b1804b1-488a723ebddmr118522865e9.7.1775637353943; Wed, 08 Apr 2026 01:35:53 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325:77fd:1068:74c8:af87? ([2620:10d:c092:600::1:eaba]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488be75215dsm119684505e9.6.2026.04.08.01.35.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Apr 2026 01:35:53 -0700 (PDT) Message-ID: Date: Wed, 8 Apr 2026 09:35:58 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] io_uring/rsrc: use io_cache_free for node in io_buffer_register_bvec error path To: KobaK , Jens Axboe Cc: Keith Busch , Ming Lei , io-uring@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260408065408.2017967-1-kobak@nvidia.com> <20260408065408.2017967-3-kobak@nvidia.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: <20260408065408.2017967-3-kobak@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/8/26 07:54, KobaK wrote: > From: Koba Ko > > io_buffer_register_bvec() allocates the rsrc node via > io_rsrc_node_alloc() which pulls from ctx->node_cache. On imu allocation > failure, the node is freed with raw kfree() instead of > io_cache_free(&ctx->node_cache, node), bypassing the cache return path > and wasting a reuse opportunity. Every other error path in this file > correctly uses io_cache_free for nodes. > > Fixes: 27cb27b6d5ea4 ("io_uring: add support for kernel registered bvecs") > Signed-off-by: Koba Ko > --- > io_uring/rsrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/io_uring/rsrc.c b/io_uring/rsrc.c > index 1b96ab5e98c99..6f46cf9cd13d7 100644 > --- a/io_uring/rsrc.c > +++ b/io_uring/rsrc.c > @@ -961,7 +961,7 @@ int io_buffer_register_bvec(struct io_uring_cmd *cmd, struct request *rq, > */ > imu = io_alloc_imu(ctx, blk_rq_nr_phys_segments(rq)); > if (!imu) { > - kfree(node); > + io_cache_free(&ctx->node_cache, node); Looks like it was already patched a week ago -- Pavel Begunkov