From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753200AbdKNCSU (ORCPT ); Mon, 13 Nov 2017 21:18:20 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:52134 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751161AbdKNCSQ (ORCPT ); Mon, 13 Nov 2017 21:18:16 -0500 X-Google-Smtp-Source: AGs4zMYL7+N+ZSqyASHuFDzWGZQ8AdJCK/JhvIvAxGsI3esXZvJFc1cw0pNI0lNAUe/eRqpcbHQkWg== Subject: Re: [PATCH 1/3] perf help: Document missing options To: Namhyung Kim , Arnaldo Carvalho de Melo Cc: Sihyeon Jang , linux-kernel@vger.kernel.org, Jiri Olsa , kernel-team@lge.com References: <1510449047-12941-1-git-send-email-uneedsihyeon@gmail.com> <20171113182956.GA8836@kernel.org> <20171114001542.GA16464@sejong> From: Taeung Song Message-ID: Date: Tue, 14 Nov 2017 11:18:10 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171114001542.GA16464@sejong> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo and Namhyung :) On 11/14/2017 09:15 AM, Namhyung Kim wrote: > Hi Arnaldo, > > On Mon, Nov 13, 2017 at 03:29:56PM -0300, Arnaldo Carvalho de Melo wrote: >> Em Sun, Nov 12, 2017 at 10:10:45AM +0900, Sihyeon Jang escreveu: >>> Cc: Jiri Olsa >>> Cc: Namhyung Kim >>> Signed-off-by: Sihyeon Jang >>> --- >>> tools/perf/Documentation/perf-help.txt | 14 +++++++++++++- >>> 1 file changed, 13 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/perf/Documentation/perf-help.txt b/tools/perf/Documentation/perf-help.txt >>> index 5143918..bb605af 100644 >>> --- a/tools/perf/Documentation/perf-help.txt >>> +++ b/tools/perf/Documentation/perf-help.txt >>> @@ -7,7 +7,7 @@ perf-help - display help information about perf >>> >>> SYNOPSIS >>> -------- >>> -'perf help' [-a|--all] [COMMAND] >>> +'perf help' [--all] [--man|--web|--info] [COMMAND] >> >> Can you try figuring out if this actually works? I tried here and it >> doesn't, its an area we took "for free" when we copied the initial >> codebase from git.git, but I never looked at this area that much, now >> that I try: > > Yeah, I'm not sure we need to keep it. > > >> >> [acme@jouet linux]$ perf help >> Config with no key for man viewer: childrenError: wrong config key-value pair top.children=true >> [acme@jouet linux]$ >> >> Unsure if this is something that got broken by the 'perf config' >> patches, Taeung? > > Looks like a bug in 8e99b6d4533c ("tools include: Adopt strstarts() > from the kernel"). > > Following patch should fix it: > > Thanks, > Namhyung I also checked this error and test the below patch. It seems that Namhyung already fixes it !! Thanks, Taeung > > > From 096b78b437b5758acc025498e88d73d9d471b3c0 Mon Sep 17 00:00:00 2001 > From: Namhyung Kim > Date: Tue, 14 Nov 2017 09:10:43 +0900 > Subject: [PATCH] perf help: Fix a bug during strstart() conversion > > The commit 8e99b6d4533c changed prefixcmp() to strstart() but missed to > change the return value in some place. It makes perf help print > annoying output even for sane config items like below: > > $ perf help > '.root': unsupported man viewer sub key. > ... > > Fixes: 8e99b6d4533c ("tools include: Adopt strstarts() from the kernel") > Cc: Taeung Song > Signed-off-by: Namhyung Kim > --- > tools/perf/builtin-help.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c > index dbe4e4153bcf..ff51e5fc0daf 100644 > --- a/tools/perf/builtin-help.c > +++ b/tools/perf/builtin-help.c > @@ -283,7 +283,7 @@ static int perf_help_config(const char *var, const char *value, void *cb) > add_man_viewer(value); > return 0; > } > - if (!strstarts(var, "man.")) > + if (strstarts(var, "man.")) > return add_man_viewer_info(var, value); > > return 0; > @@ -313,7 +313,7 @@ static const char *cmd_to_page(const char *perf_cmd) > > if (!perf_cmd) > return "perf"; > - else if (!strstarts(perf_cmd, "perf")) > + else if (strstarts(perf_cmd, "perf")) > return perf_cmd; > > return asprintf(&s, "perf-%s", perf_cmd) < 0 ? NULL : s; >