From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dominik Poggel <pog@iesy.com>, robh+dt@kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Tianling Shen <cnsztl@gmail.com>,
Chris Morgan <macromorgan@hotmail.com>,
Ondrej Jirman <megi@xff.cz>, Andy Yan <andyshrk@163.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: iesy: add support for iesy PX30 SoM OSM-S
Date: Tue, 19 Mar 2024 13:42:26 +0100 [thread overview]
Message-ID: <b43f6dd8-221d-40b1-bbc9-d5f778fe1954@linaro.org> (raw)
In-Reply-To: <20240319095411.4112296-2-pog@iesy.com>
On 19/03/2024 10:54, Dominik Poggel wrote:
> This adds support for the iesy SoM px30-iesy-osm-sf and the matching
> evalboard px30-iesy-eva-mi V2.XX.
>
> Signed-off-by: Dominik Poggel <pog@iesy.com>
> +
> + /* BB138a: MAX9867ETJ+ audio codec */
> + max9867-sound {
> + compatible = "simple-audio-card";
> + simple-audio-card,name = "rockchip,max9867-codec";
> + simple-audio-card,format = "i2s";
> +
> + simple-audio-card,widgets =
> + "Speaker", "Jack",
> + "Microphone", "Mic";
> + simple-audio-card,routing =
> + "Jack", "LOUT",
> + "Jack", "ROUT",
> + "Mic", "DMICL",
> + "Mic", "DMICR";
> +
> + simple-audio-card,frame-master = <&cpudai>;
> + simple-audio-card,bitclock-master = <&cpudai>;
> +
> + status = "okay";
One more: Drop it. The same applies in all other places when not needed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-19 12:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 9:53 [PATCH 0/3] arm64: dts: rockchip: add support for iesy RPX30 SoM OSM-S Dominik Poggel
2024-03-19 9:54 ` [PATCH 1/3] arm64: dts: iesy: add support for iesy PX30 " Dominik Poggel
2024-03-19 12:40 ` Krzysztof Kozlowski
2024-03-19 15:17 ` Dominik Poggel
2024-03-19 18:55 ` Krzysztof Kozlowski
2024-03-20 14:28 ` Dominik Poggel
2024-03-19 12:42 ` Krzysztof Kozlowski [this message]
2024-03-19 9:54 ` [PATCH 2/3] dt-bindings: vendor-prefixes: add iesy Dominik Poggel
2024-03-19 12:41 ` Krzysztof Kozlowski
2024-03-19 9:54 ` [PATCH 3/3] dt-bindings: arm: rockchip: add iesy RPX30 evaluation board Dominik Poggel
2024-03-20 16:20 ` [PATCH 0/3] arm64: dts: rockchip: add support for iesy RPX30 SoM OSM-S Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b43f6dd8-221d-40b1-bbc9-d5f778fe1954@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andyshrk@163.com \
--cc=cnsztl@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=megi@xff.cz \
--cc=pog@iesy.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).