From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo2-f0.google.com (mail-oo2-f0.google.com [74.125.231.128]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68A232E2EEE for ; Tue, 4 Aug 2026 01:50:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.231.128 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785808218; cv=none; b=GCWaEG5TOieb9HpbXwSR7AYFp5F2sM+eEL3aKNvRosnLlr9WrOX6AZDbp/A9YTt+neG7z0wdXrZBlO2/WbUig93fwluVFr1X/+dAXNJakg5o2/RIl1PU1m/sP153hsYDRGyFy69muZyknK6eT3J7MQCM4vDVkslrtNBVca3Dd5U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785808218; c=relaxed/simple; bh=aGWjf2rIwE2Pw0W1u0oFXrU2Xi7aiFFUU+puUWkUP2M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mrbkFIXdtGKt30imNWnw7WYVKN+a8K1StYr8yhernuu16fjW0fSFJzS7cQcCeGhxE7dpKX5vAh0E0vIcQUgz4vdvajliqtC4VPvb6KRYpjrmUDyJagdFZFcRF7P01nqpA92tqHaUODH46jUi0jzSSlG7gvzjYQo1pkaChDr+j18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b=nR03o5YT; arc=none smtp.client-ip=74.125.231.128 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20251104.gappssmtp.com header.i=@kernel-dk.20251104.gappssmtp.com header.b="nR03o5YT" Received: by mail-oo2-f0.google.com with SMTP id 46e09a7af769-7ea63f91262so742535a34.1 for ; Mon, 03 Aug 2026 18:50:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20251104.gappssmtp.com; s=20251104; t=1785808214; x=1786413014; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nZtSjLe66WDshK1l19eq87lIGIzPEtGn0kgmfaVgorI=; b=nR03o5YTLQNkrKhZZTZrD4A/oOxRvhxalnwmyE9XQBHyezpjluH2QSM0P8ZpGWFatq MKENz2kd1gqj75UkgTEH44a9NYvaKl3puaT0avVa890YJSK8+xFNOchNidomi1k4kavO u8NXyjXhMSV/xYjwD7Zv8oCksbVCqUbbXyxswZL4lkrolx0ob31QqahWEMRi0ubMc6/+ 7z0Ucd8/BMK83aDJo5ybi1qR3212dZhgApmK0RdWDXfpedShzXORli8X/SLWrot9xgzV MTgYA1nYLPY0E9ZTbdLWKLhp6C84fXuQvjBu//CbDRqMQpbzlTd9lRkKQboq+2dLYICL 6b/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785808214; x=1786413014; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nZtSjLe66WDshK1l19eq87lIGIzPEtGn0kgmfaVgorI=; b=PSFaLJl9ukbN8c/YJO7xrhL9u+uRWug04WE6+rHl8LEhs+odcxtkCB+D4yJeQzLLZB /cF5IzFKhOtmvSIRQ6+9eumIeqUaDn1YjqBwbv+x1kA2ntGcf0/EurH0qOM9QOWxv46S JpnQKSKmoqliXUpGO7y7Cafe/6GkT6g1waT3JWeGTxCu6KXRpL1ZcEyQV4vPUTHkeIo0 tC7QzLhsX4vjQz/J10ZB1o+0/BfsfyvIi1YLoXORRUsgyHu/ZR+K42MqYVgCgdPkHrnn Phu95g0PeR5zcBbXggcjqXGv/X//IeaKGlgGe5tbC/oSNc1yHqQuuSYB2N8kB9RzErt5 b/4w== X-Forwarded-Encrypted: i=1; AHgh+Rop3YluuJlHsgQ+ZQ0dZPdgXY2eZwZQK+pUm9QCJst6B6B2Lct2ZPCFDmgohIBDAeZbZwSoLTWk2lTlMgM=@vger.kernel.org X-Gm-Message-State: AOJu0YyVmAttEEvWBChm1gLwXspRgox5P/EdArL82P8t7GFQgPIFbxj+ WQ/3bmflnOGdhnqMX20Nqn1h2xljNaGA+5BYlZzXrtA7LOSSuGp6SFSJHuH6r35ob9s= X-Gm-Gg: AR+sD112fKerzokTdjXIgodOAK0qTYL/JObfYPTPMA6mXzyFnEhWW6Gc2WxcxS71uBh vuQSvUK23z3ZXdl7X21cohvoiIjPtBF7FrebRDl69ZsmGenlDptuakj41JVBYv9OYsrfj+KeYaQ vnl/nGZyFK5LFKFq+ELrKyVPFJOmTN1iHgb8W/dVB9TrSgZIAdUM/9o9V1fa2q91YHPqOL3Avy+ VpDbppodVk/tyv4cVTyEyGQ6e+RyuS4LdDxlUkaGBeSI37VICD2ipObrBir5RMzgcx+JXdjqGIN oTjEiF+tD/IOgGtaSbOHVJ6RHHbQSUQFeevliuh56uQD4AYiR26B0TB6CyQlotDAwynmNyBSJ3b ExGjHDOyzlq1onG0E8fw88mYBliacfCz2kE2VQJJuRIj7qDUrAEqfY1SRGPDORXIPPgJ1hfbL/b w1/Q69+3MGZwd3eBlQAHJu8xGr9Ze5isWv6Lw1N+Yztl24h3JIRr3/DzdYLM13o9V0R4cl+zmXk 302N29JLtfOAlYMcrDsXtSLAPVaQf8/8LK/DrshbQfjEE0= X-Received: by 2002:a05:6820:4b90:b0:6ae:85c5:cccd with SMTP id 006d021491bc7-6ae85c5d2f5mr1868636eaf.4.1785808213774; Mon, 03 Aug 2026 18:50:13 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-458f67655fesm9958161fac.18.2026.08.03.18.50.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Aug 2026 18:50:12 -0700 (PDT) Message-ID: Date: Mon, 3 Aug 2026 19:50:11 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: linux-next: build failure after merge of the block tree To: Mark Brown , Keith Busch , Christian Brauner , Fengnan Chang Cc: Christoph Hellwig , Hannes Reinecke , Linux Kernel Mailing List , Linux Next Mailing List References: Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/3/26 10:52 AM, Mark Brown wrote: > Hi all, > > After merging the block tree, today's linux-next build > (arm64 allnoconfig) failed like this: > > /tmp/next/build/fs/iomap/direct-io.c: In function '__iomap_dio_read_simple': > /tmp/next/build/fs/iomap/direct-io.c:1037:15: error: too few arguments to function 'bio_iov_iter_get_pages' > 1037 | ret = bio_iov_iter_get_pages(bio, iter, alignment - 1); > | ^~~~~~~~~~~~~~~~~~~~~~ > In file included from /tmp/next/build/include/linux/bio-integrity.h:5, > from /tmp/next/build/fs/iomap/direct-io.c:6: > /tmp/next/build/include/linux/bio.h:524:5: note: declared here > 524 | int bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter, > | ^~~~~~~~~~~~~~~~~~~~~~ > > caused by a sematic conflict between > > 14b007e178811 (block: validate user space vectors during extraction) > > from the block tree and > > 36f199c8d0ee4 (iomap: add simple dio path for small direct I/O) > > from the vfs-brauner tree. I have applied the fixup patch below and can > carry as needed, you should ensure you flag this to Linus when sending > PRs: > > From 5bf17d9828d05688ad4fd04cc07b64642d4ba295 Mon Sep 17 00:00:00 2001 > From: Mark Brown > Date: Mon, 3 Aug 2026 15:53:13 +0100 > Subject: [PATCH] fs: Fix up semantic conflict with bio_iov_iter_get_pages > > /tmp/next/build/fs/iomap/direct-io.c: In function '__iomap_dio_read_simple': > /tmp/next/build/fs/iomap/direct-io.c:1037:15: error: too few arguments to function 'bio_iov_iter_get_pages' > 1037 | ret = bio_iov_iter_get_pages(bio, iter, alignment - 1); > | ^~~~~~~~~~~~~~~~~~~~~~ > In file included from /tmp/next/build/include/linux/bio-integrity.h:5, > from /tmp/next/build/fs/iomap/direct-io.c:6: > /tmp/next/build/include/linux/bio.h:524:5: note: declared here > 524 | int bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter, > | ^~~~~~~~~~~~~~~~~~~~~~ > > Signed-off-by: Mark Brown > --- > fs/iomap/direct-io.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > index 2b3e916dedc77..2aa71be36c996 100644 > --- a/fs/iomap/direct-io.c > +++ b/fs/iomap/direct-io.c > @@ -1034,7 +1034,8 @@ ssize_t __iomap_dio_read_simple(struct kiocb *iocb, struct iov_iter *iter, > bio->bi_iter.bi_sector = iomap_sector(&iomi->iomap, iomi->pos); > bio->bi_ioprio = iocb->ki_ioprio; > > - ret = bio_iov_iter_get_pages(bio, iter, alignment - 1); > + ret = bio_iov_iter_get_pages(bio, iter, bdev_dma_alignment(bio->bi_bdev), > + alignment - 1); > if (unlikely(ret)) > goto out_bio_put; Looks good to me, thanks Mark. -- Jens Axboe