Re: [PATCH v5 07/19] dt-bindings: soc: tegra-pmc: Add id for Tegra PMC 32KHz blink clock

Dmitry Osipenko
2019-12-30T19:39:50Z

28.12.2019 00:30, Sowjanya Komatineni пишет:
>
> On 12/22/19 1:55 PM, Dmitry Osipenko wrote:
>> 21.12.2019 01:26, Sowjanya Komatineni пишет:
>>> Tegra PMC has blink functionality that allows 32KHz clock out to
>>> blink pin of the Tegra.
>>>
>>> This patch adds id for this blink clock to use for enabling or
>>> disabling blink output through device tree.
>>>
>>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>>> ---
>>>   include/dt-bindings/soc/tegra-pmc.h | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/include/dt-bindings/soc/tegra-pmc.h
>>> b/include/dt-bindings/soc/tegra-pmc.h
>>> index f7c866404456..a99a457471ee 100644
>>> --- a/include/dt-bindings/soc/tegra-pmc.h
>>> +++ b/include/dt-bindings/soc/tegra-pmc.h
>>> @@ -9,7 +9,8 @@
>>>   #define TEGRA_PMC_CLK_OUT_1        0
>>>   #define TEGRA_PMC_CLK_OUT_2        1
>>>   #define TEGRA_PMC_CLK_OUT_3        2
>>> +#define TEGRA_PMC_CLK_BLINK        3
>>>   -#define TEGRA_PMC_CLK_MAX        3
>>> +#define TEGRA_PMC_CLK_MAX        4
>>>     #endif    /* _DT_BINDINGS_SOC_TEGRA_PMC_H */
>>>
>> Could you please explain the reason of separating CLK_OUT and BLINK PMC
>> patches?
> No specific reason just thought to have BLINK as separate patch as its
> different register configuration to have fixed 32Khz clock out.
>>
>> Also, you only documented CLK_OUT clocks in the DT binding and no BLINK.
> missed to add BLINK to dt-binding doc. Will add in v6.

Ok