From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7DCEC43603 for ; Thu, 12 Dec 2019 07:25:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 96506206DA for ; Thu, 12 Dec 2019 07:25:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728095AbfLLHZV (ORCPT ); Thu, 12 Dec 2019 02:25:21 -0500 Received: from mga12.intel.com ([192.55.52.136]:21658 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727994AbfLLHZV (ORCPT ); Thu, 12 Dec 2019 02:25:21 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Dec 2019 23:25:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,305,1571727600"; d="scan'208";a="245598700" Received: from linux.intel.com ([10.54.29.200]) by fmsmga002.fm.intel.com with ESMTP; 11 Dec 2019 23:25:20 -0800 Received: from [10.226.38.237] (unknown [10.226.38.237]) by linux.intel.com (Postfix) with ESMTP id 4F11058033E; Wed, 11 Dec 2019 23:25:18 -0800 (PST) Subject: Re: [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver To: dan.carpenter@oracle.com References: <5f85180573a3fb20238d6a340cdd990f140ed6f0.1576054234.git.jack.ping.chng@intel.com> <20191211105757.GC2070@kadam> From: "Chng, Jack Ping" Cc: devel@driverdev.osuosl.org, cheol.yong.kim@intel.com, andriy.shevchenko@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, mallikarjunax.reddy@linux.intel.com, gregkh@linuxfoundation.org, davem@davemloft.net Message-ID: Date: Thu, 12 Dec 2019 15:25:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, On 11/12/2019 6:58 PM, Dan Carpenter wrote: > This should just be sent to netdev. I spotted a couple bugs. > > 1) enable/disable we flipped xgmac_set_xgmii_2500_speed() > 2) retries wasn't reset in a couple places. > > I had a few tiny style nits as well but there is no reason to send it to > staging. > > regards, > dan carpenter Thanks for the review and comments. We will fix the bug and address the comments. Best regards, Chng Jack Ping