From: Scott Branden <scott.branden@broadcom.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Shreesha Rajashekar <shreesha@broadcom.com>
Subject: Re: [PATCH 3/3] mfd: d1w: iproc: Add d1w driver
Date: Thu, 17 Aug 2017 11:19:19 -0700 [thread overview]
Message-ID: <b4704ec6-aace-4fa3-5bc4-1dc8433ce54d@broadcom.com> (raw)
In-Reply-To: <20170817100206.tqb5kluje6nr27ob@dell>
Hi Lee,
On 17-08-17 03:02 AM, Lee Jones wrote:
> On Wed, 16 Aug 2017, Scott Branden wrote:
>
>> From: Shreesha Rajashekar <shreesha@broadcom.com>
>>
>> d1w bus master controller is added as a mfd node.
> Why?
>
>> ds1wm driver is hooked to this node through the mfd framework.
> Why?
It looks like it was added under mfd as htc-pasic3.c is there
(other than htc-pasic3.c is and mfd due to gpio nodes).
Yes, bcm-iproc-d1w should move under w1 directory.
>
> What makes this an MFD device?
>
>> Signed-off-by: Shreesha Rajashekar <shreesha@broadcom.com>
>> Signed-off-by: Scott Branden <scott.branden@broadcom.com>
>> ---
>> drivers/mfd/Kconfig | 11 +++
>> drivers/mfd/Makefile | 1 +
>> drivers/mfd/bcm-iproc-d1w.c | 202 ++++++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 214 insertions(+)
>> create mode 100644 drivers/mfd/bcm-iproc-d1w.c
prev parent reply other threads:[~2017-08-17 18:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 17:45 [PATCH 0/3] Add Support for Broadcom D1W controller Scott Branden
2017-08-16 17:45 ` [PATCH 1/3] dt-bindings: mfd: d1w: iproc: Documentation for d1w driver Scott Branden
2017-08-16 20:45 ` Rob Herring
2017-08-17 18:20 ` Scott Branden
2017-08-16 17:45 ` [PATCH 2/3] w1: d1w: Provide callback for ds1wm read/write Scott Branden
2017-08-17 1:10 ` Florian Fainelli
2017-08-16 17:45 ` [PATCH 3/3] mfd: d1w: iproc: Add d1w driver Scott Branden
2017-08-17 10:02 ` Lee Jones
2017-08-17 18:19 ` Scott Branden [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4704ec6-aace-4fa3-5bc4-1dc8433ce54d@broadcom.com \
--to=scott.branden@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shreesha@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox