From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754547AbdEJQbT (ORCPT ); Wed, 10 May 2017 12:31:19 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:45104 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754305AbdEJQbS (ORCPT ); Wed, 10 May 2017 12:31:18 -0400 Subject: Re: [PATCH] tinydrm: mipi-dbi: Adjust buffer output in mipi_dbi_debugfs_command_show() To: SF Markus Elfring , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Fengguang Wu , Joe Perches , Thierry Reding References: <2795b611-dfb9-eaf6-e04d-10e27ce96772@users.sourceforge.net> <7a6e57ed-7d71-78bc-706e-3a6a1eea3a23@tronnes.org> <1494354199.20782.5.camel@perches.com> Cc: kernel-janitors@vger.kernel.org, LKML From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: Date: Wed, 10 May 2017 18:31:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 10.05.2017 17.15, skrev SF Markus Elfring: > From: Markus Elfring > Date: Wed, 10 May 2017 17:03:20 +0200 > > * Use a special format string specification for the desired output of the > array "val" into a sequence. > > * Adjust two local variables accordingly. > > This refactoring supersedes the update suggestion "tinydrm: mipi-dbi: > Use seq_putc() in mipi_dbi_debugfs_command_show()" from 2017-05-08. > https://patchwork.kernel.org/patch/9716119/ > > Fixes: 02dd95fe316936269a52d6ccb971bb956412b40a ("drm/tinydrm: Add MIPI DBI support") > > Suggested-by: Joe Perches > Signed-off-by: Markus Elfring > --- Thanks again, Acked-by: Noralf Trønnes > drivers/gpu/drm/tinydrm/mipi-dbi.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c > index f4eb412f3604..2670259d1798 100644 > --- a/drivers/gpu/drm/tinydrm/mipi-dbi.c > +++ b/drivers/gpu/drm/tinydrm/mipi-dbi.c > @@ -914,8 +914,7 @@ static int mipi_dbi_debugfs_command_show(struct seq_file *m, void *unused) > { > struct mipi_dbi *mipi = m->private; > u8 cmd, val[4]; > - size_t len, i; > - int ret; > + int len, ret; > > for (cmd = 0; cmd < 255; cmd++) { > if (!mipi_dbi_command_is_read(mipi, cmd)) > @@ -944,9 +943,7 @@ static int mipi_dbi_debugfs_command_show(struct seq_file *m, void *unused) > continue; > } > > - for (i = 0; i < len; i++) > - seq_printf(m, "%02x", val[i]); > - seq_puts(m, "\n"); > + seq_printf(m, "%*phN\n", len, val); > } > > return 0;