From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2065.outbound.protection.outlook.com [40.107.94.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67ED524B28 for ; Wed, 20 Nov 2024 14:14:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.94.65 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732112086; cv=fail; b=N45udjDgD1LWcAWAUozN0Hpni59vyWkofSAwQaI4p8AGEwGKN6jN1DszQHkZuMIwXuQjIcpy51xwpZq/dsh+/VlbZnelnwfTAX8Wh+wWejLj10UPvdPPyGVRd+IyxOOi5/Im/by7/Vi0lGSZlPHcMRoTAoW4r4TVWDcRZ55zMrk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732112086; c=relaxed/simple; bh=iTiklOakITiZSffTvns7F9jv9lUG/pN6xOwfjyd2GEE=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=gCCGdc+Ps7aMQ9DURdfHWDDGq8Y0/2P/Q+K0Kp/oF09C8ejVy/mt5UJ9hlaa3h1R/LtKRIfR02hF8rc/w3esO1VTme7/87AqYnblO7+tnfFEPd6BMogeeIv6Zao9VXvPEviBGkyoiD4ppzxJeoWWlepKNNsvaLpXzRxgobVHiqA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=a7yKv8Pb; arc=fail smtp.client-ip=40.107.94.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="a7yKv8Pb" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kFF9QizXAXlJF8n3yOZbVRe6ZZATxT8B6M1eC4F5CwtcixdpCgXb+LUhK9jQD62nT8aUmgRr64IiNE1mQLLgMPcgb/DQ3DuXTQdIkgF8NMYwZrW4MOo9IowP21cE4SRo21HaU0RXT4Zrivh6F1E+2F+TwKJYbT976bQFQfMONNokFjCkNdTET1FuxHEZqOnpix5/mEkqlDXCUlyE9k/kjtFS0acOlU7Ygbhaf2XFecMQJvURXaX8RDZVPVYJND7bIvMdu+X/yOplEyJH2l8/UCiI13joa+Je0WFfuefm8Tsxu424JC1Z/CJ6ANc5RjHnOWz8n/xEjX+CWTOVl+cSgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MDkBiGA4TPmn1kDotAhmVjl74KEn17yen5k8JQsWQ1c=; b=lFjNSuaqUnV79bhaGHsC1tG838HQ/rQu3hk+BFE5lRw2jJZu17cX5n47nauLsCRRD8zN04N1a0V9qH+K5UAOnw28OumYxTFSRs2cmaI+90g4JVjBiAVES8JVnz1/DNQcmna0Y6tpw9WV03WiLAK1/eNobKgyppgZaZrowJ41Yy+b956Nb/WXAco+JD4pyc5IcisUazVO0DCmcLbz5zEYmv7AodX8++ltgZZb1p1DPyIcMkGWluNJLMDQW5mfD67Vhu0f9Cmu5T/XmR6EJR7BMA4/GWXMUlBqEWzrYCNMwKrk8ji2q1TRk+91QcM4JXNkg8JXSC+/hjWC5J7+dAnMqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MDkBiGA4TPmn1kDotAhmVjl74KEn17yen5k8JQsWQ1c=; b=a7yKv8Pbi/O/guMOWAOpp7GdmDQp5S3N36F4dwbTPq7XL2aEb9CPY7+ZFiSZXdPwSUnl1guJ2rWOSc00yo29MXBdDmnyQIfnpNxVtUDelFJaHoetaYMwN3tFf8E/sKj0FDm7KK39uKhNfX6F0rwRkIPSSA669/uqq3PKvgj6d0Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5070.namprd12.prod.outlook.com (2603:10b6:5:389::22) by DS7PR12MB5791.namprd12.prod.outlook.com (2603:10b6:8:76::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.21; Wed, 20 Nov 2024 14:14:42 +0000 Received: from DM4PR12MB5070.namprd12.prod.outlook.com ([fe80::20a9:919e:fd6b:5a6e]) by DM4PR12MB5070.namprd12.prod.outlook.com ([fe80::20a9:919e:fd6b:5a6e%5]) with mapi id 15.20.8182.014; Wed, 20 Nov 2024 14:14:41 +0000 Message-ID: Date: Wed, 20 Nov 2024 08:14:39 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 1/2] x86/ioremap: introduce helper to implement xxx_is_setup_data() To: Ingo Molnar Cc: Baoquan He , linux-kernel@vger.kernel.org, bp@alien8.de, x86@kernel.org References: <20241118010819.46602-1-bhe@redhat.com> <20241118010819.46602-2-bhe@redhat.com> <7cc5e26c-42fc-a700-ae19-608920cafe44@amd.com> Content-Language: en-US From: Tom Lendacky In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN4PR0501CA0069.namprd05.prod.outlook.com (2603:10b6:803:41::46) To DM4PR12MB5070.namprd12.prod.outlook.com (2603:10b6:5:389::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5070:EE_|DS7PR12MB5791:EE_ X-MS-Office365-Filtering-Correlation-Id: 923d31f9-ee82-41d6-37fe-08dd096dacf5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aWJGNURqNlJabkdSS3dvZ2Mwc1hpb3orZUpWV25tOGtCenlsT2huNk9QZ2ZW?= =?utf-8?B?anUzeDlWMVp2Y3V6ZVFwbGhpbjAyUFlDWGpuTUhTMWdJN1VGYVpHRlFhbTg4?= =?utf-8?B?Y3VoQnBlb1ZqRWFTMS85RHBENzY4WldTdUVpTW9QYnk2TFViTzc4L1NMM2hD?= =?utf-8?B?WFNISWNxTDhyY0syUEQ2b2pKTzZmYzJYQm1Ic2hTRTlPWkY5bFhWdXZvY0tk?= =?utf-8?B?Tm9uc05vRWhYdnpqNEg5U3BPVENPcExEZURYUWJvWnEwTjFsQW4vM3B0RmU2?= =?utf-8?B?Wk8rdXZNR3dsMHRGYkRRWnFuM214NG9vNk5CYWpVVzBaTUVGNTdqK2VWeVdi?= =?utf-8?B?VUhTMHBvZkdIejFFdWQ3NkgvUHJ1TnlkQnpyZW1ZaE8wSjVMUjM1ZWNDRGJY?= =?utf-8?B?ZTN2bGZYU3BIOGpNMWdOdFoyaHZxSmhUL0tTNjJjSVh2ZlFkdFNSRzlPUTVn?= =?utf-8?B?R1pGNzZ0cjdjVGh2eHd2RG5ubXhMa0NjYTZaM3dFMW9zK2laTnU2SWxsdWQ3?= =?utf-8?B?Z2FCNmlMazRSSjhGa2YyTUdMMVBLNmJmL1Rpb3R1OHFZM2JpYW1NV0JSak9O?= =?utf-8?B?RGpqajZVUVBQcVQyZ3JCVEdXelRCTXlFQS9sQ05UYUJyamphQlk2QStOMmNE?= =?utf-8?B?OFdsTG9VNUpkOTgvdHdPZmp3OExmcW1YV1dlTkY3ZUIvdG95bWE1WVVHSHVV?= =?utf-8?B?M1I2cGNOK2JIWFhoYy9CUFF1bFQwaFFUeVNIZ1B2MW40UHZIOWJVSnhydWNY?= =?utf-8?B?amIreWxuZ29EM0YrVm5LKzJlLzV5NktrTkF2R3ZhUkxSczB6UHZHaGF3Y2wz?= =?utf-8?B?U0FFdGF4ZzJkVmppbE1oUXcrVkZBY2VOblBlRmRicUZHSklpR0h2ajQvSVBi?= =?utf-8?B?YzVSSUZRM0QzMytUTWlNSjBtRTNxblBQQmQ2MmRHYTM0dnp1dDlreFRDLzRm?= =?utf-8?B?OUJtVTVCaFlieFA5QXFmUDB6WjYzVmo2UmwwMVE3MG4vN2RYNTJxK1lqR3Uw?= =?utf-8?B?Ums2SU5zWkR5YlhKclFta3B5MlpzMmpscUVvK1ZzQXViTUVxazlnZTBWTlQ5?= =?utf-8?B?OGwyd2NVdnA0NS81djNxYW81ODF6SVpYSTJUc2xYWHprY1VhL081aUhNc2Fx?= =?utf-8?B?NVo0K3hFNU9wdHVscWJ6NDhrbDVPSysrUWFmRW14UDIzRmNyRG9hYUlhK2My?= =?utf-8?B?ckZPT2hMUWd4dlJpUlRHV3ZOVndQcXBOZng2OEI4NXkrcCsyRDRDbjRsQThW?= =?utf-8?B?LzNFT3Y0SmdtRjdMMkN5bmR1U3JHc01iWU1UVGZRRHh2OEtxMlBiYjdreDJi?= =?utf-8?B?Nk5ISUxnSVBwYWRFZHoyN254eFJSMXBNcjlyT25QVUNaQTViMXFRNS9sN2hC?= =?utf-8?B?K3BrQmVFdHNtdUQ5YmRxcll0SEFsUmhVbnJCV0lFNjkwOWJvMHAxZDlHeFc5?= =?utf-8?B?YnFVa3htNTFTRE5DS1RaZzNwVTZPRmMwRnNJcWgyeWw5RzNPSGpZVlhsTHJt?= =?utf-8?B?ZEh6NTVQenk2WEE0ZzVkWG1nMDdLYnVkcUN5RGJJWCtqUmR6bGdMZU5IYU5M?= =?utf-8?B?akhITUJHTDNnMGhWOUpuZlJGNWN3Vll4SDJhY2RmWURZZmV0VWRmSUVqbWVz?= =?utf-8?B?VytVUHU1aTVFVlljbHNQcGIzOGd3MHV5by9TejRLRmhhejFROTAzam5YUGY3?= =?utf-8?B?TG9vcXRsSytiOEZ6NXlPQW5VV0lZTThUUVNzSmdHazFrcG1zR005TWJrVk1X?= =?utf-8?Q?RWNoPr5Jq8p3CWRfBnmWYMbOIDL2Z4MLZzJ2Zjx?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5070.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjdlWjV3L1YxME9mUmtpenpzL0g3L2Vxa0hLTVlIUmYzU1NvbW1OT2lTNFV6?= =?utf-8?B?dEVUNlc2WVlzb2Z5ZittaURPbUJTQkRLWWZwWkpKT09PYjFCTWlMSUtBMGEx?= =?utf-8?B?ODRQaXVSNm5FMlJIbGFBc09MTmR0enhiUnpualZlajNtd0NGOFI5ZnhIT3FO?= =?utf-8?B?S2wvU0JnUDQyTUlINVMwUFd2VG1SbDZBM2xIdlR3Rzc3SDR4U3R4UWNVa0I0?= =?utf-8?B?ck9zSUl1UHJOVWIwRkdPdjllRVVsK3R0VHRya1h4VVZaQjZYRjkydjJFelA1?= =?utf-8?B?bS9SdEN0cVFGcE01d3JVVzBhbkVtZzVydzF1ejNMN3Y2eUc4ZUI4eHVhbmEr?= =?utf-8?B?WlZXWis2TWdRZmhIYkMxUkg4S2FNODQzSkRDYW1jN1lXdjJESzRGTVdqZlF1?= =?utf-8?B?bmFyVW0yWkdlRlRQQXgrUmE5ZVJmL3ZmY1Q5VDhqZ1lnS2RzQlo3MnA4VkQx?= =?utf-8?B?UktvYnhXb2M4UjVEbmxGMnZBbjN0K01ZVm1xQ3hNV0I5NjZoTkY0WGFpYnJC?= =?utf-8?B?SUpJSjFtT1oya0swVTRHUmUyUmtvV1A2eEdQTGEvdjY4SmxUMGFid1Y4ZDRo?= =?utf-8?B?cFg5U0M0VEM0OG4vc2pkd1B6MjJFS1Q2QzZDM1ZLM3pmRW5mL0h4T0RjYjV0?= =?utf-8?B?VFdHUjZ4WElKQ0VSRVk3dnExbDM0VDVMeFRlR1RPRnJyZVdJaWVaY0R3eitW?= =?utf-8?B?ZmlNYk1LSG1oN3lhdEJVNVM0R2w4dG1nVGVhbFFqVkZXNk1JejZPSU5YWk9u?= =?utf-8?B?eEl6bWdaZVB0c2pINmE4M2h4Zzc3MkErb2QwbzBzMGZvdkxmS2lZTDJKNEdE?= =?utf-8?B?ZVkrRUtBbHp3a3RPNmlsMm1SNHc5Zk1PdkNtQ1RBOTFYLzF3T2RmcnRTSXcz?= =?utf-8?B?SHZUVmtQTkNMb29ZUXZTT3V1a0dXNXBqWkZEeHJ6NENieEVzM3B5bzFvb24r?= =?utf-8?B?c0QwSThIbzJZYi8yeUFoN1Bkck1CcFc5ZnZWU3lpMHZHS3ZBb2hFcFg4aXJK?= =?utf-8?B?UTNUTVZGeCtpR05qeEM1c0RORDN6amhscUFGS3p1OWhlUU1OcStKVjkwMGhG?= =?utf-8?B?UG5CZHN4V3NObFB6V2wvY2phRDQ3cnBablNHY0dJMTVEM0lGZ1BhNUI3NUpi?= =?utf-8?B?Q3ptTEdLamFTVFZLTkxWeEZ0U3kwbm4zUE9JK3pzZmN6dHFOS25zNTY1YllS?= =?utf-8?B?azgrOU9jbm95NG5SSEc1T2p0VzRKbXVraWJxRC9rRzQvVTRicXQ5c3I4RVJ2?= =?utf-8?B?K0NXaFlTYmROcVpxV0NJOE5FYXM4VVlJNnNyN3NCS3pmTkpjRGZIcy9jQUpW?= =?utf-8?B?elJzUkFNRHlFZWhqY243bWlqU1dOK3lkaytyRnJ6aURqYVVIYmY2bW9wQ1F1?= =?utf-8?B?cnlUQTV4UjFaOXdTa0t0aWp0WmRtVmVvZ3ZsL21UOU1pY0c5TmRicEo5b1RE?= =?utf-8?B?L0NPWFhJb2lkUXZCSGFhci9WSVZRTDduTUM1Rzl1RHp2RXo0WGNmaTVVRnYy?= =?utf-8?B?QnlGNENST1VqdW9pNHV5Zi9temt1eDFNWWRpZmlCQTc0N2xJSTZsODhSVzZs?= =?utf-8?B?TjRUVEdWTW0rT3ZtMjVvb3p6cDAwZmxuQUtKYS9zK0p5UkZldHY4cXBKekNa?= =?utf-8?B?Q1B6WjFTWXBpT1d1bzgrMDZseCs5UDhNOEVtRUlDR3VDSytuM3dkcWdlMHpz?= =?utf-8?B?c2N1T3F4U2hCQUk0c3pZc29RQTh6M0N2WUU3SS9xNlpRaDZBOXhWSGsza2lL?= =?utf-8?B?ZlF5Q2FjN1ZIT28zVGhLb21DamJaN3YwalRkVjFhMW9MY00rRGdjRWZIVklW?= =?utf-8?B?Q2U3RWtmYUZRRktuR1o1KyszeTNNRitUTjBrQXRhbmdNUU15OWhyOUR6cVBO?= =?utf-8?B?WmFxM2QyYWk4VlQzSVBDVGQrZ1lhQXQyU3RrNFBuajJBMHJGY1dkYjV2L1pB?= =?utf-8?B?elV1NDRnakk4aTlPaVAxdnQ1N1lKM0YrODI2V0Vrdm5UeG1KTEpaOUw2NjNu?= =?utf-8?B?bjZ0NEFKUHQyQ1ZTOHBkekFlMXRNVTUvVGFLVUlxcmFqbW1LRWwxSU0xZVBx?= =?utf-8?B?YWZNSUNMenRESHVyYmtGSVp6WEtXaytxcmNCUTZrZEJ6Z3hKOW1NTXcvVkwv?= =?utf-8?Q?Y9bcnhObris0Ox+q5RMkFbocP?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 923d31f9-ee82-41d6-37fe-08dd096dacf5 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5070.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Nov 2024 14:14:41.6159 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K9vp2YfmZTYq1o7zY7Yq31/6xTpWODDSA5kOTiEEc+lAm0KRIPwcGp2vfv05BZE5Z0TLH7t8lZ2Bj3tYvp1GTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5791 On 11/20/24 02:25, Ingo Molnar wrote: > > * Tom Lendacky wrote: > >>> /* >>> * Examine the physical address to determine if it is boot data by checking >>> * it against the boot params setup_data chain. >>> */ >>> -static bool memremap_is_setup_data(resource_size_t phys_addr, >>> - unsigned long size) >>> +static bool __ref __memremap_is_setup_data(resource_size_t phys_addr, >> >> Oh, I see why the __ref is needed now, because this calls an __init >> function based on the early bool. >> >> While this nicely consolidates the checking, I'll let the x86 >> maintainers decide whether they like that an __init function is calling >> a non __init function. > > So why would it be a problem? Only non-__init calling __init is a bug, > because __init functions cease to exist after early bootup. Also, > calling certain kernel subsystems too early, before they are > initialized, is a bug as well. I brought it up because that is what could happen if the wrong boolean value is supplied to the helper function. The helper function is marked non-__init but calls a __init function if the boolean value is true, hence the need for the __ref tagging. But, I don't anticipate that this helper will be called by anything else than what is currently calling it and the proper boolean values are set on those calls. I just wanted to raise awareness. I'm ok with using __ref, just wanted to make sure everyone else is, too. Thanks, Tom > > But calling non-__init functions that have initialized already is like > totally normal: printk() for example, but also all locking facilities, > etc. > > Am I missing anything here? > > Thanks, > > Ingo