From: Hao Jia <jiahao.kernel@gmail.com>
To: Aaron Lu <ziqianlu@bytedance.com>
Cc: mingo@redhat.com, peterz@infradead.org, mingo@kernel.org,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
kprateek.nayak@amd.com, linux-kernel@vger.kernel.org,
Hao Jia <jiahao1@lixiang.com>
Subject: Re: [PATCH v2] sched/fair: Fix non-empty throttled_limbo_list warning in tg_throttle_down()
Date: Tue, 28 Oct 2025 15:31:37 +0800 [thread overview]
Message-ID: <b495827a-0ee8-512a-edb8-cd79c84d5a6a@gmail.com> (raw)
In-Reply-To: <20251027120211.GB33@bytedance>
On 2025/10/27 20:02, Aaron Lu wrote:
>> *
>> + * THROTTLE - invoke in throttle_cfs_rq_work() to ensure task dequeue
>> + * during throttling, and in tg_unthrottle_up() to ensure
>> + * task enqueue during unthrottling.
>
> Thanks for adding the comment for dequeue_throttle. One nit is:
> dequeue_throttle is used for time accounting purpose so it would be
> better if you can make that clear, maybe something like this:
>
> invoked in throttle_cfs_rq_work() during throttle for accounting
> purpose, and in tg_unthrottle_up() to avoid throttling when enqueuing
> tasks.
Thanks, will do it.
Thanks,
Hao
prev parent reply other threads:[~2025-10-28 7:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 9:05 [PATCH v2] sched/fair: Fix non-empty throttled_limbo_list warning in tg_throttle_down() Hao Jia
2025-10-27 12:02 ` Aaron Lu
2025-10-28 3:03 ` K Prateek Nayak
2025-10-28 6:39 ` Aaron Lu
2025-10-28 7:31 ` Hao Jia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b495827a-0ee8-512a-edb8-cd79c84d5a6a@gmail.com \
--to=jiahao.kernel@gmail.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jiahao1@lixiang.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=ziqianlu@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox