From: Jacob Keller <jacob.e.keller@intel.com>
To: Arnd Bergmann <arnd@arndb.de>, Arnd Bergmann <arnd@kernel.org>,
"Sunil Goutham" <sgoutham@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
hariprasad <hkelam@marvell.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Suman Ghosh <sumang@marvell.com>, Simon Horman <horms@kernel.org>,
Anthony L Nguyen <anthony.l.nguyen@intel.com>,
Jiri Pirko <jiri@resnulli.us>,
"Mateusz Polchlopek" <mateusz.polchlopek@intel.com>,
Netdev <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ethernet: octeontx2: avoid linking objects into multiple modules
Date: Thu, 30 May 2024 13:30:26 -0700 [thread overview]
Message-ID: <b4bcd52c-ba0b-46b2-b302-fb412542328b@intel.com> (raw)
In-Reply-To: <866cb878-47fa-4bb9-ba93-6a0c0e70a4f7@app.fastmail.com>
On 5/30/2024 11:52 AM, Arnd Bergmann wrote:
> On Thu, May 30, 2024, at 19:54, Jacob Keller wrote:
>> On 5/28/2024 8:25 AM, Arnd Bergmann wrote:
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> Each object file contains information about which module it gets linked
>>> into, so linking the same file into multiple modules now causes a warning:
>>>
>>> scripts/Makefile.build:254: drivers/net/ethernet/marvell/octeontx2/nic/Makefile: otx2_devlink.o is added to multiple modules: rvu_nicpf rvu_nicvf
>>>
>>
>> When I tried to build, I don't see any warnings produced on the current
>> net-next with W=1. Is this something new and not yet in net-next tree?
>> If not, how do I enable this warning in my local build?
>
> The warning has been around with W=1 for over a year now, it still
> shows up here:
>
> make ARCH=arm64 allmodconfig drivers/net/ethernet/marvell/octeontx2/ -skj20
> scripts/Makefile.build:236: drivers/net/ethernet/marvell/octeontx2/nic/Makefile: otx2_devlink.o is added to multiple modules: rvu_nicpf rvu_nicvf
> scripts/Makefile.build:236: drivers/net/ethernet/marvell/octeontx2/nic/Makefile: otx2_dcbnl.o is added to multiple modules: rvu_nicpf rvu_nicvf
>
>
> Arnd
Hmm. Ah yep, I must have missed W=1. I thought I had it enabled. Doing a
clean rebuild with it, I do see the warnings.
Thanks,
Jake
next prev parent reply other threads:[~2024-05-30 20:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 15:25 [PATCH] ethernet: octeontx2: avoid linking objects into multiple modules Arnd Bergmann
2024-05-30 17:54 ` Jacob Keller
2024-05-30 18:52 ` Arnd Bergmann
2024-05-30 20:30 ` Jacob Keller [this message]
2024-05-31 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4bcd52c-ba0b-46b2-b302-fb412542328b@intel.com \
--to=jacob.e.keller@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mateusz.polchlopek@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox