public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Baojun Xu <baojun.xu@ti.com>, tiwai@suse.de
Cc: robh+dt@kernel.org, andriy.shevchenko@linux.intel.com,
	lgirdwood@gmail.com, perex@perex.cz, kevin-lu@ti.com,
	13916275206@139.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com,
	yung-chuan.liao@linux.intel.com, broonie@kernel.org,
	soyer@irl.hu
Subject: Re: [PATCH v1 6/8] ALSA: hda/tas2781: Add tas2781 SPI-based driver
Date: Tue, 26 Mar 2024 10:05:20 -0500	[thread overview]
Message-ID: <b4c5fb89-a43c-4c40-b729-a49a537f6179@linux.intel.com> (raw)
In-Reply-To: <20240326010905.2147-6-baojun.xu@ti.com>


> +enum device_catlog_id {

catalog?

> +	HP = 0,
> +	OTHERS
> +};

Is there not a better way to identify solutions?
You have ACPI IDs, no?


  reply	other threads:[~2024-03-26 15:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26  1:08 [PATCH v1 1/8] ALSA: hda/tas2781: Add tas2781 SPI-based driver Baojun Xu
2024-03-26  1:08 ` [PATCH v1 2/8] " Baojun Xu
2024-03-26 15:00   ` Andy Shevchenko
2024-03-26 15:22     ` Takashi Iwai
2024-03-26  1:09 ` [PATCH v1 3/8] " Baojun Xu
2024-03-26  1:09 ` [PATCH v1 4/8] " Baojun Xu
2024-03-26 15:01   ` Andy Shevchenko
2024-03-26 15:03     ` Andy Shevchenko
2024-03-26  1:09 ` [PATCH v1 5/8] " Baojun Xu
2024-03-26  1:09 ` [PATCH v1 6/8] " Baojun Xu
2024-03-26 15:05   ` Pierre-Louis Bossart [this message]
2024-04-06  7:43     ` [EXTERNAL] " Xu, Baojun
2024-03-26  1:09 ` [PATCH v1 7/8] " Baojun Xu
2024-03-26 15:13   ` Pierre-Louis Bossart
2024-03-26 15:16     ` Andy Shevchenko
2024-03-26 15:15   ` Andy Shevchenko
2024-03-27 10:02   ` Gergo Koteles
2024-04-05 15:51     ` [EXTERNAL] " Xu, Baojun
2024-03-26  1:09 ` [PATCH v1 8/8] " Baojun Xu
2024-03-26 14:58 ` [PATCH v1 1/8] " Andy Shevchenko
2024-04-05 16:17   ` [EXTERNAL] " Xu, Baojun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4c5fb89-a43c-4c40-b729-a49a537f6179@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=13916275206@139.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=baojun.xu@ti.com \
    --cc=broonie@kernel.org \
    --cc=kevin-lu@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=liam.r.girdwood@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=soyer@irl.hu \
    --cc=tiwai@suse.de \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox