Re: [PATCH] ARM: socfpga: fix missing RESET_CONTROLLER

[Dinh Nguyen <dinguyen@kernel.org>]

On 2/7/22 03:47, Krzysztof Kozlowski wrote:
> On 07/02/2022 10:45, Dinh Nguyen wrote:
>>
>>
>> On 2/7/22 02:44, Krzysztof Kozlowski wrote:
>>> The SocFPGA machine since commit b3ca9888f35f ("reset: socfpga: add an
>>> early reset driver for SoCFPGA") uses reset controller, so it should
>>> select RESET_CONTROLLER explicitly.  Selecting ARCH_HAS_RESET_CONTROLLER
>>> is not enough because it affects only default choice still allowing a
>>> non-buildable configuration:
>>>
>>>     /usr/bin/arm-linux-gnueabi-ld: arch/arm/mach-socfpga/socfpga.o: in function `socfpga_init_irq':
>>>     arch/arm/mach-socfpga/socfpga.c:56: undefined reference to `socfpga_reset_init'
>>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>> Cc: <stable@vger.kernel.org>
>>> Fixes: b3ca9888f35f ("reset: socfpga: add an early reset driver for SoCFPGA")
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>> ---
>>>    arch/arm/mach-socfpga/Kconfig | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm/mach-socfpga/Kconfig b/arch/arm/mach-socfpga/Kconfig
>>> index 43ddec677c0b..594edf9bbea4 100644
>>> --- a/arch/arm/mach-socfpga/Kconfig
>>> +++ b/arch/arm/mach-socfpga/Kconfig
>>> @@ -2,6 +2,7 @@
>>>    menuconfig ARCH_INTEL_SOCFPGA
>>>    	bool "Altera SOCFPGA family"
>>>    	depends on ARCH_MULTI_V7
>>> +	select ARCH_HAS_RESET_CONTROLLER
>>>    	select ARCH_SUPPORTS_BIG_ENDIAN
>>>    	select ARM_AMBA
>>>    	select ARM_GIC
>>> @@ -18,6 +19,7 @@ menuconfig ARCH_INTEL_SOCFPGA
>>>    	select PL310_ERRATA_727915
>>>    	select PL310_ERRATA_753970 if PL310
>>>    	select PL310_ERRATA_769419
>>> +	select RESET_CONTROLLER
>>>    
>>>    if ARCH_INTEL_SOCFPGA
>>>    config SOCFPGA_SUSPEND
>>
>> Acked-By: Dinh Nguyen <dinguyen@kernel.org>
> 
> Hi Dinh,
> 
> I was expecting you will pick it up. If you only ack, who is going to
> take it? Shall I send it directly to soc@?
> 

Ok...I'll pick it up.

Dinh