From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5828143E063 for ; Thu, 16 Jul 2026 17:17:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784222241; cv=none; b=D3QYGM/Dul3+cIE+CikDVydl3poMDhp5FkN1a0ibX7W3ES9aod0g7aE5iHFGBhreCaPZKGsQA/GiHda78mB45PaPE8Z2gKZhHJUGz+KLCMCnniBmX7D88lQKj5djfbuWlaUx138zrZt7vs3kdlrzWJgiCHNqD9WKuspEfBAbd8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784222241; c=relaxed/simple; bh=yhjO9foj3wfTz126q4+ORECWPTnHtF0SfAfrvQrOr24=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XpqBIQxNLlAq1xCLNPRi/mSgYAPE2RDYSR3htZ+/hqvx2jUXe3+gXfkz4t3GTnvgT72qlg09Pkt6J4b/FdHLS64SklQC67DO5nMYtGFnL1eRyoPtUIlCMpnVXwjwYprCYWVIq2sPFl80gQf8MZwCzXV0F/14FK32UB6g6uo1kSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dJYngoBn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=IYDu05we; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dJYngoBn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="IYDu05we" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66GGSeB73127418 for ; Thu, 16 Jul 2026 17:17:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RLyka2dGDlxqyY4LBXDQg+Mr3NeguU+JffNAcDddFJ0=; b=dJYngoBnuFcZ5nZW RUyQ3eRVKm4KJ43FVH1TQtMskakIkhd/QBMcF3jHQVEuBOh8l7cFzBjxVDePCMFF 5t9pilhUfyDKDRVRNjdkWLsbGrbr6UFHzVK/Wf4CbOdPrHb8P3Y4YZ/a3mfqmg9o Trv2wp2tiR3HHbsBDsUeOaRMvMtESEMsRD+KMqqb2aFaGCUkpJ14COqRaPCLwAad HlkMegi6OVzg/ESGWzASpmZ6E2L+NXZzhBA1X32A9MPXZPRn2jXubf0tuIU5FYux zxarc9uVM/6/2xem0dQTdzEePYOATgHNC2S3VxSRoMoRMA22omgpPgPab1j+43iw HAyWqg== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fetb7tq4g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Jul 2026 17:17:19 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51e9d892f0dso3498241cf.2 for ; Thu, 16 Jul 2026 10:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784222239; x=1784827039; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RLyka2dGDlxqyY4LBXDQg+Mr3NeguU+JffNAcDddFJ0=; b=IYDu05weyh1jIu7nXpRcwm+HTqfnWTOU53FX1rxAHDwF4UNC2p/YsC6Nnt3wWtwUq2 UrCAparMS+/bjT7ZOu4cqmD432RJvxP/dnp+jgpaQy0+peJDt8Z3meQKpT0KN0CuiEev LLgy9sQYv6LhrK67gxoLVBtW5lMo4tPT/RsSSQdnojNs8cJ/HzjNvtniP2U+V9L5ya0y sYAM+9YwS2903Im3XNZv21Rm4DZQwj86eKsdudW+QH5MJXDlMnuIAtEd+mVbsqWIhyXO oHoCxNtugHgz3gvwPvz1JgXZ2l7OSwSzWz5UbKA3PXxX+v4KGFhBk602QVS5siQd9Fku 2JMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784222239; x=1784827039; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RLyka2dGDlxqyY4LBXDQg+Mr3NeguU+JffNAcDddFJ0=; b=T2whtgE/3XXxNorxczRNiq7KUZGVisVJk5SVZGtS2tO7dqQATfWb3uBaBtQu9nmpC0 wxMt0US8bWDHGkDkkjFhU44zsP9QdKSOwkoFhe3WMJ6I6ZVJMK1QDmNZxqPMBAlZnOQd i3rQOACwI7fSwQIo5CHZpBFY+B6j9dspyWf2bP1nAqHpkMey/ku0iu/vhDwskP2MjvrC N51KwakNZrchgeoLwMbXAPNQZHnyObmJfKoNMoHDD+uDfo9Vp9GJY42puFUxuW2VsCyQ 8oDvAV0GwyAGFw6DjgiUONKIUr+rCcoDot61cb8FqnWzgNW93nkT33emzYkjNnTnDA+5 XiZw== X-Forwarded-Encrypted: i=1; AHgh+Rq1MD6xVr0CRMaK5gxcthfPpr33/W7rv67Q0xAh0Y3Kd4COqriSnzLeMxOyjk4I9uZjsgXvCeg1MjAsG/o=@vger.kernel.org X-Gm-Message-State: AOJu0YzZsgqvdLzrOE7k1r3lX8MKTthgeJL6+OYV1sTn/EGJbfFXLHSp ch0w1ZDHo6K2VKuHlyzjQAbmH3OrxkKQ6EVYHzNpxxy+IHAaNb+mk4X4ABl8SXXrg4xvGRKM69l Wrp/Y/WGyXOwlfUNLrk6NCavzJKPDsRcNRZmJIKH3F6Iw1NLYxOHnZS92UNsSOyA8YGU= X-Gm-Gg: AfdE7ck4Ty4qBR7GUtwN/Yb9Z+KsgCb0x7GP1V9Qsrhe9qOL94sIibolQfHJ6Ti/F8x loSai6ke0EIKGhxJjPjfo4RClphlEesJFXNRBcpEWIZ7VBJciaXkeMyl1cnLlwxYiZuqhOvovHT YwirjnFWbWI2Y5HnwgokTlegBsGG5Aflcl1hnDtood9VO0jwGCjiOGiPBY5wj68M2M4glVobjE+ bUpRGK89xNxHOmfhEoxJ5ppoFiyQu0UO70lJQFB5d656/lSAEv72XZtCJgI5Cd33Hk1RY/gGtsw WqP68NBigt6PvQlZxoKn11TKX1eS1vNHCHKDx7+cJ2cg3BTc9/XBpZ3Ekg0HAXt1qMueCbXNJ0J TYiPp/spW0XfGMyXqlurLpFUr X-Received: by 2002:ac8:7f88:0:b0:51a:8c9b:6494 with SMTP id d75a77b69052e-51cbf32f49dmr191490811cf.11.1784222238406; Thu, 16 Jul 2026 10:17:18 -0700 (PDT) X-Received: by 2002:ac8:7f88:0:b0:51a:8c9b:6494 with SMTP id d75a77b69052e-51cbf32f49dmr191490351cf.11.1784222237777; Thu, 16 Jul 2026 10:17:17 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c16871264c5sm259740166b.2.2026.07.16.10.17.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2026 10:17:16 -0700 (PDT) Message-ID: Date: Thu, 16 Jul 2026 19:17:14 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 6/6] arm64: dts: qcom: Add device tree for Nord RRD board To: Shawn Guo , Bjorn Andersson Cc: Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , Deepti Jaggi , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski References: <20260716142605.2398433-1-shengchao.guo@oss.qualcomm.com> <20260716142605.2398433-7-shengchao.guo@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260716142605.2398433-7-shengchao.guo@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE2MDE3NiBTYWx0ZWRfX2RnuRQtj3zZa o9GmT+z2+8kHim4Ny9lMWq864VcrLYXED2q0w30CbDp6f/Zq8wVPOFeMcGryUacX3rSq/K/1V6/ HdzPdNvSNo3wGw4JvshIScc374JY2qE= X-Authority-Analysis: v=2.4 cv=dM2WXuZb c=1 sm=1 tr=0 ts=6a59121f cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=JYDhkS4F_D_NCfCrlLEA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE2MDE3NiBTYWx0ZWRfX2+Y0edY7+Zql 02KizobR7IR0f5Eefp5oRddolJOeYEpaZ+wWF0s9fNs/flKv/et/bt4BzMUN1dMPqHLrBuxh7zv MKbWzWPBERjvQQy02d+Z7RPLphnNVcOybGIT+0YsrHIAvUu3iqCdIX9Rte1xzVhSj0FpxHhyck0 pOpVP2/G1VknHLukYEaIQmCIL83ke2pSdI4vPKculqInUTYRfyDuIiQ5DLnFQIQ5QCqHnxCocE6 KVA3AeXwZ88h6DXBOvddD/q1fcsgUkstLsHkyDdIuEXIlyHxmEQQ2iYFXS+grYuhh9aBBU3cLT+ tlbMYrB4dx6BdT69USImLgL+OWELWOHB5lWprj6MKv6qw24FwMfnl1XCPiVaCBG76BKGCGKvE67 FUfeRKRbZ2BxIoAcYnwQYB1A1ij/rM29iJVIYF0FAfcPFf1YVU2gFRe3qM9C31Jq/zLOdu//Qs0 BSUS2rZS9IPv3rGr3DA== X-Proofpoint-ORIG-GUID: LM_uORg0K6zOBbD71DBppwEXeGqXDLZP X-Proofpoint-GUID: LM_uORg0K6zOBbD71DBppwEXeGqXDLZP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-16_06,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 adultscore=0 spamscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 clxscore=1015 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607160176 On 7/16/26 4:26 PM, Shawn Guo wrote: > Add initial device tree for the Qualcomm Dragonwing IQ10 RRD (Robotics > Reference Design) board, which is built on Nord Embedded variant. Enable > the debug UART, UFS storage, PMICs, I2C and SPI. > > Co-developed-by: Bartosz Golaszewski > Signed-off-by: Bartosz Golaszewski > Signed-off-by: Shawn Guo > --- [...] > + /* PMIC A - Kobra_MM (PMM8650AU) - SID 0x0, Bus E0 */ This comment is very useful > + regulators-0 { > + compatible = "qcom,pmm8654au-rpmh-regulators"; > + qcom,pmic-id = "A_E0"; > + > + /* LDO Regulators */ This is much less so [...] > + vreg_l7a_1p2: ldo7 { > + regulator-name = "vreg_l7a_1p2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-initial-mode = ; > + regulator-always-on; > + regulator-boot-on; > + regulator-allow-set-load; You made a lot of the regulators always-/boot-on - are you sure about each one of them? > + regulator-allowed-modes = + RPMH_REGULATOR_MODE_HPM>; It's commonplace to restrict regulators to HPM only because not all of the drivers that should be voting on desired load actually do it. Do you have any intermittent failures, particularly around PHYs? [...] > +&i2c7 { > + clock-frequency = <400000>; > + > + status = "okay"; It's commonplace to add comments like: /* Type-C controller @ 0x15 */ Otherwise this lgtm Reviewed-by: Konrad Dybcio Konrad