* [PATCH] platform/x86: ideapad-laptop: Use str_on_off() helper
@ 2025-10-31 18:44 Rong Zhang
2025-11-05 8:20 ` Ilpo Järvinen
0 siblings, 1 reply; 2+ messages in thread
From: Rong Zhang @ 2025-10-31 18:44 UTC (permalink / raw)
To: Ike Panhc, Mark Pearson, Derek J. Clark, Hans de Goede,
Ilpo Järvinen
Cc: Rong Zhang, platform-driver-x86, linux-kernel, kernel test robot,
Julia Lawall
Use the str_on_off() helper instead of open-coding the same operation.
This improves code readability.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@inria.fr>
Closes: https://lore.kernel.org/r/202510311551.xjWbHTrm-lkp@intel.com/
Suggested-by: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/2bae2ea7-2ef9-0cfa-0c2c-39a7043b2aa5@linux.intel.com/
Signed-off-by: Rong Zhang <i@rong.moe>
---
This patch is based on 'review-ilpo-next' of pdx86/platform-drivers-x86,
hence depends on my previous patch ("platform/x86: ideapad-laptop:
Protect GBMD/SBMC calls with mutex").
---
drivers/platform/x86/lenovo/ideapad-laptop.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86/lenovo/ideapad-laptop.c b/drivers/platform/x86/lenovo/ideapad-laptop.c
index d2bfaa532020..931a72a2a487 100644
--- a/drivers/platform/x86/lenovo/ideapad-laptop.c
+++ b/drivers/platform/x86/lenovo/ideapad-laptop.c
@@ -475,25 +475,25 @@ static int debugfs_status_show(struct seq_file *s, void *data)
if (!read_ec_data(priv->adev->handle, VPCCMD_R_BL, &value))
seq_printf(s, "Backlight now: %lu\n", value);
if (!read_ec_data(priv->adev->handle, VPCCMD_R_BL_POWER, &value))
- seq_printf(s, "BL power value: %s (%lu)\n", value ? "on" : "off", value);
+ seq_printf(s, "BL power value: %s (%lu)\n", str_on_off(value), value);
seq_puts(s, "=====================\n");
if (!read_ec_data(priv->adev->handle, VPCCMD_R_RF, &value))
- seq_printf(s, "Radio status: %s (%lu)\n", value ? "on" : "off", value);
+ seq_printf(s, "Radio status: %s (%lu)\n", str_on_off(value), value);
if (!read_ec_data(priv->adev->handle, VPCCMD_R_WIFI, &value))
- seq_printf(s, "Wifi status: %s (%lu)\n", value ? "on" : "off", value);
+ seq_printf(s, "Wifi status: %s (%lu)\n", str_on_off(value), value);
if (!read_ec_data(priv->adev->handle, VPCCMD_R_BT, &value))
- seq_printf(s, "BT status: %s (%lu)\n", value ? "on" : "off", value);
+ seq_printf(s, "BT status: %s (%lu)\n", str_on_off(value), value);
if (!read_ec_data(priv->adev->handle, VPCCMD_R_3G, &value))
- seq_printf(s, "3G status: %s (%lu)\n", value ? "on" : "off", value);
+ seq_printf(s, "3G status: %s (%lu)\n", str_on_off(value), value);
seq_puts(s, "=====================\n");
if (!read_ec_data(priv->adev->handle, VPCCMD_R_TOUCHPAD, &value))
- seq_printf(s, "Touchpad status: %s (%lu)\n", value ? "on" : "off", value);
+ seq_printf(s, "Touchpad status: %s (%lu)\n", str_on_off(value), value);
if (!read_ec_data(priv->adev->handle, VPCCMD_R_CAMERA, &value))
- seq_printf(s, "Camera status: %s (%lu)\n", value ? "on" : "off", value);
+ seq_printf(s, "Camera status: %s (%lu)\n", str_on_off(value), value);
}
seq_puts(s, "=====================\n");
base-commit: ba06b928f05bfd2785260819f6b34b658a04a4e6
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] platform/x86: ideapad-laptop: Use str_on_off() helper
2025-10-31 18:44 [PATCH] platform/x86: ideapad-laptop: Use str_on_off() helper Rong Zhang
@ 2025-11-05 8:20 ` Ilpo Järvinen
0 siblings, 0 replies; 2+ messages in thread
From: Ilpo Järvinen @ 2025-11-05 8:20 UTC (permalink / raw)
To: Rong Zhang
Cc: Ike Panhc, Mark Pearson, Derek J. Clark, Hans de Goede,
platform-driver-x86, LKML, kernel test robot, Julia Lawall
[-- Attachment #1: Type: text/plain, Size: 3208 bytes --]
On Sat, 1 Nov 2025, Rong Zhang wrote:
> Use the str_on_off() helper instead of open-coding the same operation.
> This improves code readability.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Julia Lawall <julia.lawall@inria.fr>
> Closes: https://lore.kernel.org/r/202510311551.xjWbHTrm-lkp@intel.com/
> Suggested-by: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
> Link: https://lore.kernel.org/r/2bae2ea7-2ef9-0cfa-0c2c-39a7043b2aa5@linux.intel.com/
> Signed-off-by: Rong Zhang <i@rong.moe>
> ---
> This patch is based on 'review-ilpo-next' of pdx86/platform-drivers-x86,
> hence depends on my previous patch ("platform/x86: ideapad-laptop:
> Protect GBMD/SBMC calls with mutex").
> ---
> drivers/platform/x86/lenovo/ideapad-laptop.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/platform/x86/lenovo/ideapad-laptop.c b/drivers/platform/x86/lenovo/ideapad-laptop.c
> index d2bfaa532020..931a72a2a487 100644
> --- a/drivers/platform/x86/lenovo/ideapad-laptop.c
> +++ b/drivers/platform/x86/lenovo/ideapad-laptop.c
> @@ -475,25 +475,25 @@ static int debugfs_status_show(struct seq_file *s, void *data)
> if (!read_ec_data(priv->adev->handle, VPCCMD_R_BL, &value))
> seq_printf(s, "Backlight now: %lu\n", value);
> if (!read_ec_data(priv->adev->handle, VPCCMD_R_BL_POWER, &value))
> - seq_printf(s, "BL power value: %s (%lu)\n", value ? "on" : "off", value);
> + seq_printf(s, "BL power value: %s (%lu)\n", str_on_off(value), value);
This change should also add the include for str_on_off().
--
i.
>
> seq_puts(s, "=====================\n");
>
> if (!read_ec_data(priv->adev->handle, VPCCMD_R_RF, &value))
> - seq_printf(s, "Radio status: %s (%lu)\n", value ? "on" : "off", value);
> + seq_printf(s, "Radio status: %s (%lu)\n", str_on_off(value), value);
> if (!read_ec_data(priv->adev->handle, VPCCMD_R_WIFI, &value))
> - seq_printf(s, "Wifi status: %s (%lu)\n", value ? "on" : "off", value);
> + seq_printf(s, "Wifi status: %s (%lu)\n", str_on_off(value), value);
> if (!read_ec_data(priv->adev->handle, VPCCMD_R_BT, &value))
> - seq_printf(s, "BT status: %s (%lu)\n", value ? "on" : "off", value);
> + seq_printf(s, "BT status: %s (%lu)\n", str_on_off(value), value);
> if (!read_ec_data(priv->adev->handle, VPCCMD_R_3G, &value))
> - seq_printf(s, "3G status: %s (%lu)\n", value ? "on" : "off", value);
> + seq_printf(s, "3G status: %s (%lu)\n", str_on_off(value), value);
>
> seq_puts(s, "=====================\n");
>
> if (!read_ec_data(priv->adev->handle, VPCCMD_R_TOUCHPAD, &value))
> - seq_printf(s, "Touchpad status: %s (%lu)\n", value ? "on" : "off", value);
> + seq_printf(s, "Touchpad status: %s (%lu)\n", str_on_off(value), value);
> if (!read_ec_data(priv->adev->handle, VPCCMD_R_CAMERA, &value))
> - seq_printf(s, "Camera status: %s (%lu)\n", value ? "on" : "off", value);
> + seq_printf(s, "Camera status: %s (%lu)\n", str_on_off(value), value);
> }
>
> seq_puts(s, "=====================\n");
>
> base-commit: ba06b928f05bfd2785260819f6b34b658a04a4e6
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-05 8:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-31 18:44 [PATCH] platform/x86: ideapad-laptop: Use str_on_off() helper Rong Zhang
2025-11-05 8:20 ` Ilpo Järvinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox