From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755266AbcIEIPo (ORCPT ); Mon, 5 Sep 2016 04:15:44 -0400 Received: from mout.web.de ([212.227.15.4]:54039 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755038AbcIEIPl (ORCPT ); Mon, 5 Sep 2016 04:15:41 -0400 Subject: [PATCH 3/4] x86/smpboot: Replace one kzalloc() call by kcalloc() To: x86@kernel.org, Andi Kleen , Boris Ostrovsky , Borislav Petkov , "H. Peter Anvin" , Ingo Molnar , Jiri Olsa , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Len Brown , Peter Zijlstra , Thomas Gleixner References: <6dacb257-d15c-8ea1-9dd4-0440a5ecfd1d@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: Date: Mon, 5 Sep 2016 10:12:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <6dacb257-d15c-8ea1-9dd4-0440a5ecfd1d@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:uDDdCRNvgRjXZsw4aVK8kvc8xYcNGieHrZdQaLUXiH3W+R0mjLo rj6Pimur0CJG75Um2OINJfYnhOer6lMeE7kculWlkmN+rbdeSf7xjwNGNH7EjgW9aHycN25 ecRd3m9DSli9taspBOZtDfOn7rD972tLoFUh3a/SSo+OrZ3FX3d5//WkvDw8BZbCMv3o/jb /aBLCxbhEgjvRRlSKXwhA== X-UI-Out-Filterresults: notjunk:1;V01:K0:SYOFEgJS8zQ=:2++jCy9JA5pXvAYsF7Mx49 4wmQvMPfNafd7N/I0Fnp0v2milhwFVjEyOUfWPZ8z1uLiRg1kOmWUMbd14sMsEqtj4p+HNedv RtBQKndud6eCoi5QbL8Obs1aa9x9SPftKK2mkxSl4UHVe3gXDbkFyBSsz43Jqre3qmow9ToNH 4O6A8xuN9JqMc7JjQnrLErD62wPeohkA/fZnC3UjsIGL2OtzajfOp9ijcrj3pQ2XiB/jN+BqI og+28paqKtRkR6RRj5YmS3BTrMJrI2xt8hCfK+n4To5NT9enaqet24cKKSh/6qRK9Z1jVatpG mwq/uemTStzqMCOeW8Xb/zgYqce8uBNLzqj2GCtHQIPM0LzN4FfISRxBIiCVEDaqboAkg3WRq yo/jMddboYSy/nbTC2eWzkeY5D2nC1spwZ2afRRZpvYW3Q4hWHqO0fraPlcYjHqGsOekkkS58 z/hJ2oMAbgQ1OsiPnHXINg5WVFRffO8dMorUYhXhxzTML+vU4YS4M7vnWTlyhZPOiQT7wMapK WKc83pbvCqm8/iuddWqkJNlHaLLhTpsme4ez/xUI/hMKMxWRf+WSwfVHpjfeBdloYcTBzvKhl AqE10xXFTKBoAVI8i1jLR6mY6c61tqnfFzAfcIpFa6hMm9B5LfiwL1oIbCTCHl3U3rWR+3YxP 5cEAE313EMJsxFYyWRVejuXza6LRmHrlhpK6dC3J/FKivcvxhkFw8VWcPVy7SIimgLkaEi90A 0QfCXWiyeuhvbE99g3Cc4G+Kr/pOJnZDqzz9JOPLlUJIPpb9cWVceg3w+TPS5ity7Ajpf+/qY 5+SOHYx Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 5 Sep 2016 09:29:40 +0200 * The script "checkpatch.pl" can point information out like the following. WARNING: Prefer kcalloc over kzalloc with multiply Thus fix the affected source code place. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. * Delete the local variable "size" which became unnecessary with this refactoring. Signed-off-by: Markus Elfring --- arch/x86/kernel/smpboot.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index 2ce06ef..e3fdc44 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -311,7 +311,6 @@ EXPORT_SYMBOL(topology_phys_to_logical_pkg); static void __init smp_init_package_map(void) { unsigned int ncpus, cpu; - size_t size; /* * Today neither Intel nor AMD support heterogenous systems. That @@ -357,8 +356,9 @@ static void __init smp_init_package_map(void) memset(physical_to_logical_pkg, 0xff, sizeof(*physical_to_logical_pkg) * max_physical_pkg_id); - size = BITS_TO_LONGS(max_physical_pkg_id) * sizeof(unsigned long); - physical_package_map = kzalloc(size, GFP_KERNEL); + physical_package_map = kcalloc(BITS_TO_LONGS(max_physical_pkg_id), + sizeof(*physical_package_map), + GFP_KERNEL); for_each_present_cpu(cpu) { unsigned int apicid = apic->cpu_present_to_apicid(cpu); -- 2.9.3