From: Krzysztof Kozlowski <krzk@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>, Arnd Bergmann <arnd@kernel.org>
Cc: "Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Andreas Kemnade" <andreas@kemnade.info>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"David S . Miller" <davem@davemloft.net>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Eric Dumazet" <edumazet@google.com>,
"Felipe Balbi" <balbi@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Kevin Hilman" <khilman@baylibre.com>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Linus Walleij" <linusw@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Roger Quadros" <rogerq@kernel.org>,
"Tony Lindgren" <tony@atomide.com>,
linux-wireless@vger.kernel.org, Netdev <netdev@vger.kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux-OMAP <linux-omap@vger.kernel.org>,
"Christian Lamparter" <chunkeey@gmail.com>
Subject: Re: [PATCH v3 3/3] p54spi: convert to devicetree
Date: Thu, 30 Apr 2026 08:10:58 +0200 [thread overview]
Message-ID: <b5d9985c-474c-4866-bc5f-5b7b4be4d641@kernel.org> (raw)
In-Reply-To: <556b64c4-febb-4dc6-8d51-1b1c2d2c6aa6@app.fastmail.com>
On 29/04/2026 23:35, Arnd Bergmann wrote:
>
> The driver doesn't know the difference, so I assume they are
> either all compatible, or the other ones don't actually work.
> I've dropped everything except "st,stlc4550" now, as that is the
> one I used in the dts file. I kept the other identifiers
> in the binding as:
>
> compatible:
> oneOf:
> - const: st,stlc4560
> - items:
> - enum:
> - cnxt,3110x
> - st,stlc4550
> - isil,p54spi
Yes, just keep this enum part sorted alphabetically.
> - const: st,stlc4560
>
> Not sure if that's the best way to express this.
>
> Arnd
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-04-30 6:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 14:23 [PATCH v3 0/3] wireless: p54 devicetree conversion Arnd Bergmann
2026-04-27 14:23 ` [PATCH v3 1/3] dt-bindings: net: add st,stlc45xx/p54spi binding Arnd Bergmann
2026-04-29 6:55 ` Krzysztof Kozlowski
2026-04-27 14:23 ` [PATCH v3 2/3] ARM: dts: omap2: add stlc4560 spi-wireless node Arnd Bergmann
2026-04-27 14:23 ` [PATCH v3 3/3] p54spi: convert to devicetree Arnd Bergmann
2026-04-29 8:07 ` Krzysztof Kozlowski
2026-04-29 21:35 ` Arnd Bergmann
2026-04-30 6:10 ` Krzysztof Kozlowski [this message]
2026-04-29 8:09 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5d9985c-474c-4866-bc5f-5b7b4be4d641@kernel.org \
--to=krzk@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=andreas@kemnade.info \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=balbi@kernel.org \
--cc=bcousson@baylibre.com \
--cc=brgl@kernel.org \
--cc=chunkeey@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox