Re: [virtio-dev] Re: [RFC PATCH v3 3/3] SPI: Add virtio SPI driver.

Haixu Cui
2024-03-05T07:47:04Z

Hello Harald,

Thank you for your detailed expatiation. To my knowledge, you took
Vanilla as the front-end, and VMM is QEMU. Can you please explain
further how do you test the SPI transfer without the Vanilla userspace
interface? Thanks again.

Haixu Cui

On 3/4/2024 6:52 PM, Harald Mommer wrote:
> Hello Haixu,
>
> no, I've not touched spidev.c. Nowhere. I took Vanilla next/stable and
> applied the patches I sent.
>
> Run the driver as a (somewhat different but comparable) module on 6.5 on
> hardware over virtio-MMIO. Probes and goes live.
>
> Tested on next/stable using a specially adapted QEMU version which
> allows the usage of our proprietary virtio SPI device over PCI in qemu.
> Probes and goes live.
>
> There may be other patches in the setup we're using I'm not aware of but
> not this one.
>
> Only in case you're using some locally developed virtio SPI device on
> qemu which uses PCI transport:
>
> SPI has ID 45. Means 0x2d.
>
> https://www.qemu.org/docs/master/specs/pci-ids.html
>
> 1af4:1040 to 1af4:10ef
>
>    ID range for modern virtio devices. The PCI device ID is calculated
>    from the virtio device ID by adding the 0x1040 offset. ...
>
> lspci on qemu:
>
> / # lspci
> ...
> 00:03.0 Class 00ff: 1af4:106d
> ...
>
> / #
>
> You see something like this?
>
> Regards
> Harald
>
> On 04.03.24 08:11, Haixu Cui wrote:
>>
>>
>> On 2/13/2024 9:53 PM, Harald Mommer wrote:
>>> +static struct spi_board_info board_info = {
>>> +    .modalias = "spi-virtio",
>>> +};
>>
>> Hi Harald,
>>     Do you add "spi-virtio" in spidev_spi_ids in spidev.c when you
>> doing the tests, to probe spidev driver?
>>
>> Thanks
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
>> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
>>