From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alex Lanzano <lanzano.alex@gmail.com>,
Markus Elfring <Markus.Elfring@web.de>
Cc: Mehdi Djait <mehdi.djait@bootlin.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
Conor Dooley <conor+dt@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>, Rob Herring <robh@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH v3 2/2] drm/tiny: Add driver for Sharp Memory LCD
Date: Mon, 29 Jul 2024 14:28:48 +0200 [thread overview]
Message-ID: <b5edd9f8-4764-41e3-a4ea-5d9838acd5f9@kernel.org> (raw)
In-Reply-To: <darls2mffvsw2ktkirzimzij6w5w45hxylvfcfwgmd3k3elmar@xeg6mfpa3yax>
On 29/07/2024 14:05, Alex Lanzano wrote:
>> Under which circumstances would you become interested to apply a statement
>> like “guard(mutex)(&smd->tx_mutex);”?
>> https://elixir.bootlin.com/linux/v6.10.2/source/include/linux/mutex.h#L196
>>
>
> Ah, I didn't realize guarded mutexes were implemented. That's really
> good to know.
>
> I'd usually use them when it's possible to return before mutex_unlock is
> called to avoid goto cleanup logic. But it's probably best to just use them
> by default.
>
> Thanks for the review. Will clean up in v4.
<form letter>
Feel free to ignore all comments from Markus, regardless whether the
suggestion is reasonable or not. This person is banned from LKML and
several maintainers ignore Markus' feedback, because it is just a waste
of time.
</form letter>
Best regards,
Krzysztof
prev parent reply other threads:[~2024-07-29 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 1:42 [PATCH v3 0/2] Add driver for Sharp Memory LCD Alex Lanzano
2024-07-29 1:42 ` [PATCH v3 1/2] dt-bindings: display: Add Sharp Memory LCD bindings Alex Lanzano
2024-07-29 6:13 ` Krzysztof Kozlowski
2024-07-29 1:42 ` [PATCH v3 2/2] drm/tiny: Add driver for Sharp Memory LCD Alex Lanzano
2024-07-29 11:00 ` Markus Elfring
2024-07-29 12:05 ` Alex Lanzano
2024-07-29 12:28 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5edd9f8-4764-41e3-a4ea-5d9838acd5f9@kernel.org \
--to=krzk@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=airlied@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=lanzano.alex@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mehdi.djait@bootlin.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox