From: "Joseph, Jithu" <jithu.joseph@intel.com>
To: "Kurt Borja" <kuurtb@gmail.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: <platform-driver-x86@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Ashok Raj <ashok.raj.linux@gmail.com>,
Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH 4/4] platform/x86: intel: Use *-y instead of *-objs in Makefile
Date: Tue, 18 Feb 2025 16:10:05 -0800 [thread overview]
Message-ID: <b5f539d9-8aeb-4272-938c-e3046df9cb50@intel.com> (raw)
In-Reply-To: <20250218194113.26589-5-kuurtb@gmail.com>
On 2/18/2025 11:41 AM, Kurt Borja wrote:
> The `objs` suffix is reserved for user-space tools. Use the `y` suffix
> instead, which is usually used for kernel drivers.
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> ---
> drivers/platform/x86/intel/ifs/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks good to me (and verified that driver is getting built)
Reviewed-by: Jithu Joseph <jithu.joseph@intel.com>
>
> diff --git a/drivers/platform/x86/intel/ifs/Makefile b/drivers/platform/x86/intel/ifs/Makefile
> index 30f035ef5581..c3e417bce9b6 100644
> --- a/drivers/platform/x86/intel/ifs/Makefile
> +++ b/drivers/platform/x86/intel/ifs/Makefile
> @@ -1,3 +1,3 @@
> obj-$(CONFIG_INTEL_IFS) += intel_ifs.o
>
> -intel_ifs-objs := core.o load.o runtest.o sysfs.o
> +intel_ifs-y := core.o load.o runtest.o sysfs.o
Thanks
Jithu
next prev parent reply other threads:[~2025-02-19 0:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 19:41 [PATCH 0/4] platform-x86: Use *-y instead of *-objs in Makefiles Kurt Borja
2025-02-18 19:41 ` [PATCH 1/4] platform/x86: dell: dell-wmi-sysman: Use *-y instead of *-objs in Makefile Kurt Borja
2025-02-19 14:35 ` Andy Shevchenko
2025-02-20 16:13 ` Kurt Borja
2025-02-18 19:41 ` [PATCH 2/4] platform/x86: amd: Use *-y instead of *-objs in Makefiles Kurt Borja
2025-02-18 19:41 ` [PATCH 3/4] platform/x86: hp: Use *-y instead of *-objs in Makefile Kurt Borja
2025-02-18 19:41 ` [PATCH 4/4] platform/x86: intel: " Kurt Borja
2025-02-19 0:10 ` Joseph, Jithu [this message]
2025-02-19 14:36 ` Andy Shevchenko
2025-02-24 15:17 ` [PATCH 0/4] platform-x86: Use *-y instead of *-objs in Makefiles Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5f539d9-8aeb-4272-938c-e3046df9cb50@intel.com \
--to=jithu.joseph@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ashok.raj.linux@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kuurtb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox