Re: [PATCH v3 3/5] riscv: dts: starfive: Add common board dtsi for VisionFive 2 Lite variants

[E Shattow <e@freeshell.de>]

On 11/21/25 03:51, Emil Renner Berthing wrote:
> Quoting Hal Feng (2025-11-20 09:29:44)
>> Add common board dtsi for use by VisionFive 2 Lite variants.
>>
>> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
>> ---
>>  .../jh7110s-starfive-visionfive-2-lite.dtsi   | 691 ++++++++++++++++++
>>  1 file changed, 691 insertions(+)
>>  create mode 100644 arch/riscv/boot/dts/starfive/jh7110s-starfive-visionfive-2-lite.dtsi
>>
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110s-starfive-visionfive-2-lite.dtsi b/arch/riscv/boot/dts/starfive/jh7110s-starfive-visionfive-2-lite.dtsi
>> new file mode 100644
>> index 000000000000..aa375c4a3fa3
>> --- /dev/null
>> +++ b/arch/riscv/boot/dts/starfive/jh7110s-starfive-visionfive-2-lite.dtsi
>> @@ -0,0 +1,691 @@
>> +// SPDX-License-Identifier: GPL-2.0 OR MIT
>> +/*
>> + * Copyright (C) 2025 StarFive Technology Co., Ltd.
>> + * Copyright (C) 2025 Hal Feng <hal.feng@starfivetech.com>
>> + */
>> +
>> +/dts-v1/;
>> +#include "jh7110.dtsi"
>> +#include "jh7110-pinfunc.h"
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/leds/common.h>
>> +#include <dt-bindings/pinctrl/starfive,jh7110-pinctrl.h>
> ''
> I'm confused. In [1] you said "remove jh7110s-common.dtsi, because only one
> board uses JH7110S now." but this series still adds two different boards.
> 
> Also this derives from jh7110.dtsi rather than from jh7110-common.dts as I
> suggested in [2].
> 
> In any case I'm fine with doing it this way, so
> Acked-by: Emil Renner Berthing <emil.renner.berthing@canonical.com>
> 
> [1]: https://lore.kernel.org/linux-riscv/ZQ2PR01MB13076544E2136E7E7C2EEDA1E6CD2@ZQ2PR01MB1307.CHNPR01.prod.partner.outlook.cn/
> [2]: https://lore.kernel.org/linux-riscv/CAJM55Z-MfpVX3EuQ_AjvDSk6FwR51R5cQdN5RybS9pbJ8r9NNg@mail.gmail.com/

"Yes" or "No" question from me: Is it necessary to introduce new
"jh7110s" compatible?

I am also confused as suggestions and feedback from v2 are not
implemented in v3:

"jh7110" or "jh7110s" filename prefix ?

<prefix>-starfive-visionfive-2-lite.dtsi includes jh7110-common.dtsi ?
Not changed in v3 with include of "jh7110.dtsi" and duplicating
jh7110-common.dtsi in a board dtsi file. This may be acceptable but it
makes no sense to me why is this done when the suggestion is for minimal
changes.

<prefix>-starfive-visionfive-2-lite.dtsi adds four pairs of
'/delete-property/' with OPP table where different from jh7110-common.dtsi ?

<prefix>-starfive-visionfive-2-lite.dts:
compatible = "starfive,visionfive-2-lite", "starfive,jh7110"
? (or else)
compatible = "starfive,visionfive-2-lite", "starfive,jh7110s"
? (or else)
compatible = "starfive,visionfive-2-lite", "starfive,jh7110s",
"starfive,jh7110"
?

<prefix>-starfive-visionfive-2-lite-emmc.dts:
compatible = "starfive,visionfive-2-lite-emmc", "starfive,jh7110"
? (or else)
compatible = "starfive,visionfive-2-lite-emmc", "starfive,jh7110s"
? (or else)
compatible = "starfive,visionfive-2-lite", "starfive,jh7110s",
"starfive,jh7110"
?

-E