From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f179.google.com (mail-oi1-f179.google.com [209.85.167.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6865E1FFC67 for ; Wed, 8 Jan 2025 17:06:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736355975; cv=none; b=ZBqdIq0SUIjTq9hBj3YC8+84MpvHos9aXlG909qelxxFeQlDwCm7kA4wMYS7Q3/NdGyDGGclu8o5/wv9hYOXT0045I/1KghBXUULZalWF4mz/7qIJlllWraJAqFgEgnmrANuNnAzQBNEX/B05nfE6sR8FkGBWtVReR2g3qllTnw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736355975; c=relaxed/simple; bh=jCamsfLpcBDv0KT7qF02it6Id78FDWwVeoi+mD41IZg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=um5BdAZWvln9W8XluO2/PEYCss3t39fDmW6jq6y/mye3rME/+BB6z3Ntbwcy680FKgv6a1TEsJpOcjUTrBqCroRgq3a3AuhxhbZct3RreOzlKd4Bv3I19WmgqN2K6f+1YoHLhXlvbwWj1fhFkabZcTKKE5FikNky+ZWQpzW8b2E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=WsJnBZQF; arc=none smtp.client-ip=209.85.167.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="WsJnBZQF" Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3eb98b3b63dso3661237b6e.1 for ; Wed, 08 Jan 2025 09:06:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736355972; x=1736960772; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=n/b4Xzx1xkuwA/wx5BhKWtA/mjZMQ0mArLR9j53cJLo=; b=WsJnBZQFZnH1CSsoN9fIHXN5k800U4yja6SiLWiBRwNgBxjwMCzcYinOUwsyMxE0fr lElSqVqS2KOC35bk8BJJrhi9DnFlBOkTkeS/p192FqfJHFoUEglhpXs2amTo+mW4V7g1 r/dK89OLsP4oQAElb554Z23uNObr/VrzEzH7wibOWGlxRSHgfnCD9eHAig1eNkB6lIhk kVJSDvGgGYQDd6TMS5G6vQkaI01p3quOqigX7hwh75/H+TkBlFwHUBo8MOo7dmmzb/aa J+PpYlzIDbFv0L8H8iWZKFrqm1P8z/WwsnU0MDE6f1RwIDRJzpZhnAzLJtJ1D3m3kx+j SkRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736355972; x=1736960772; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n/b4Xzx1xkuwA/wx5BhKWtA/mjZMQ0mArLR9j53cJLo=; b=IA7wR7bmxkk78Vsj9Xw07ZNcLKZa+D1wjTgDVj8AQHxoRqxUYu+yZ1H7R9DFfLQCVV Y2WKQE6gYVQH4J7xqZDFvxQr+d0eHDlO9f2m2Ubuli99nc87WqUCie9VuPy4BGnzxt1V ijK2Tn03SobD+TPhfutE8iqzsHRp4ad72lYdRHUodUBos4XtakPIvDaBFq3e08SAo4V/ EFNXUJ4Gexz02DGRwxVsPCY3c9L3cfEXY7zHAtP4yezKS1sBQpvshGxIWR4/gKwCHq77 GNguVsmpKN+k0ipqvKzviUv4ekXqJ44RjzIk7VSLmDOj0YL5yVCMfW0IruJuffqFeo0s vDPA== X-Forwarded-Encrypted: i=1; AJvYcCVoIezjmyYz95XnMqOFAAdfQqi5MbTOAFFQnVeBAg4+7i5YXGonj7ge46/28Lj+EeNyM1SpQFA8V4uq7wE=@vger.kernel.org X-Gm-Message-State: AOJu0YwClMyK9QpvNHFU1BD1STTcUSHlO7iSVKAbEpgRI5cuGdb5bA1L 4WbWjk95X4YpCaBmB06YoLaN3K+FS0DPMgA/J1UEM+gTygQ424B+jXTVdGra7kg= X-Gm-Gg: ASbGncslhL8yx4Lk9Zbp962KpGV5Cz8dqSxgDnEwEq5+hdRLQTEtz99LV/1/Y2EIR+m gqxm8AHIXICOEyH4lRIIl/gGXWWZwkV5tzVNvz24vo+8CPAjbs+Kyf8cqcHKYTMGd/pWwK8YEd4 IsLgGs8Dl4lO1JzPntOY2to8i5ciwh4i4qjXWT8hGhDF54XITdZb8LswL95BanwMqHVf3RqqD8E aJUlROpnfMgmXqxEE/GsDZH9ZkxiuwD5oC6N61SFrtjpWaNRUeBdVXJzF4HstyFrUrJZGY0QM/r d5OHnMr+Pli7V88WHA== X-Google-Smtp-Source: AGHT+IEWotvyiUKl/k0KXLMw0knOeNaJYVLSpncNojbcFb3g/TMcabu1SuBV0WZUGqsskizMdV4GPA== X-Received: by 2002:a05:6808:913:b0:3eb:5d13:f688 with SMTP id 5614622812f47-3ef2edd34d7mr1881257b6e.26.1736355972541; Wed, 08 Jan 2025 09:06:12 -0800 (PST) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3ece244e86asm11434861b6e.5.2025.01.08.09.06.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 09:06:11 -0800 (PST) Message-ID: Date: Wed, 8 Jan 2025 11:06:09 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 8/8] iio: adc: ad4851: add ad485x driver To: Jonathan Cameron , Antoniu Miclaus Cc: robh@kernel.org, conor+dt@kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org References: <20241220120134.42760-1-antoniu.miclaus@analog.com> <20241220120134.42760-8-antoniu.miclaus@analog.com> <20241223120005.1bc9a208@jic23-huawei> From: David Lechner Content-Language: en-US In-Reply-To: <20241223120005.1bc9a208@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/23/24 6:00 AM, Jonathan Cameron wrote: > On Fri, 20 Dec 2024 14:01:34 +0200 > Antoniu Miclaus wrote: > ... >> + ret = devm_regulator_get_enable_optional(dev, "vddh"); >> + if (ret < 0 && ret != -ENODEV) >> + return dev_err_probe(dev, ret, "failed to enable vddh voltage\n"); >> + >> + ret = devm_regulator_get_enable_optional(dev, "vddl"); >> + if (ret < 0 && ret != -ENODEV) >> + return dev_err_probe(dev, ret, "failed to enable vddl voltage\n"); >> + >> + ret = devm_regulator_get_enable_optional(dev, "vrefbuf"); >> + if (ret < 0 && ret != -ENODEV) >> + return dev_err_probe(dev, ret, "failed to enable vrefbuf voltage\n"); >> + >> + if (ret > 0) > > I'm fairly sure that call never returns a positive. Will return 0 for success so I think this > should be if (ret == 0) Even better, make it 1 line instead of 4 and use the specific error code we are checking for: st->vrefbuf_en = ret != -ENODEV; > >> + st->vrefbuf_en = true; >> + else >> + st->vrefbuf_en = false; >> + >> + ret = devm_regulator_get_enable_optional(dev, "vrefio"); >> + if (ret < 0 && ret != -ENODEV) >> + return dev_err_probe(dev, ret, "failed to enable vrefio voltage\n"); >> + >> + if (ret > 0) > > Same here. ^ > >> + st->vrefio_en = true; >> + else >> + st->vrefio_en = false; >> + > ... > >> +} >