From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 075352749D9; Thu, 14 Aug 2025 08:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755159756; cv=none; b=b0M7LbbNAV90IGwjJcp9PVfzNb3b913KwROn8h9SEoXUPqJbkj81lrrjo8Azbx7oHR7Fke56HbqBpr+B/YLHEWiR0jMTMXXIm7Iwi27uYxdMqorUfH+m5fF8m1i4KydXxak1QIuXMR+lBRJk0qn8JjHlHDoOydCa6BVEj4FHk0g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755159756; c=relaxed/simple; bh=QptsBHffm0KH6p7+g8nJS4gOiQnquTBf7oewFglHkds=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=QxntmQSi8C3ZTnARQ8wZ5Ktlht0iSyObWd1rVTdQiX6IIWOspnhoJN8BUUS3YEbyF2+LaiRgEM/9GPH1IwSgG+ld6SrtNpq+Pdshsf0e6spnKXqNDZ45fMbxDyfcCfu4bW841zaUJSh51RWKSJUImSuy76LkIw/iQYCVhfvO0v4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.235]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTPS id 4c2dX72kGnzYQv9Z; Thu, 14 Aug 2025 16:22:31 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.128]) by mail.maildlp.com (Postfix) with ESMTP id F29F41A0E39; Thu, 14 Aug 2025 16:22:29 +0800 (CST) Received: from [10.174.179.143] (unknown [10.174.179.143]) by APP4 (Coremail) with SMTP id gCh0CgBXIBHEnJ1oFBmODg--.42407S3; Thu, 14 Aug 2025 16:22:29 +0800 (CST) Subject: Re: [PATCH 00/16] blk-mq: introduce new queue attribute asyc_dpeth To: Ming Lei , Yu Kuai Cc: axboe@kernel.dk, bvanassche@acm.org, nilay@linux.ibm.com, hare@suse.de, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com, yangerkun@huawei.com, johnny.chenyi@huawei.com, "yukuai (C)" References: <20250814033522.770575-1-yukuai1@huaweicloud.com> From: Yu Kuai Message-ID: Date: Thu, 14 Aug 2025 16:22:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:gCh0CgBXIBHEnJ1oFBmODg--.42407S3 X-Coremail-Antispam: 1UD129KBjvJXoW7ZF1DuFy8XFWfGr48WrWkCrg_yoW8Xw4Up3 y3t3WSkw4DGry8Cw4xt3yrXry8C3ZYgrZ8JrW5Kr47GF98X3WjvFnagF1ruas7Wr15Gr4a gF1qq3s3Xw4qyFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUB214x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4U JVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvEwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxGxcIEc7CjxVA2Y2ka 0xkIwI1lc7I2V7IY0VAS07AlzVAYIcxG8wCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x 0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E 7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcV C0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF 04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF0xvEx4A2jsIEc7 CjxVAFwI0_Gr1j6F4UJbIYCTnIWIevJa73UjIFyTuYvjfUonmRUUUUU X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ Hi, ÔÚ 2025/08/14 15:54, Ming Lei дµÀ: > On Thu, Aug 14, 2025 at 11:35:06AM +0800, Yu Kuai wrote: >> From: Yu Kuai >> >> Backgroud and motivation: >> >> At first, we test a performance regression from 5.10 to 6.6 in >> downstream kernel(described in patch 13), the regression is related to >> async_depth in mq-dealine. >> >> While trying to fix this regression, Bart suggests add a new attribute >> to request_queue, and I think this is a good idea because all elevators >> have similar logical, however only mq-deadline allow user to configure >> async_depth. And this is patch 9-16, where the performance problem is >> fixed in patch 13; >> >> Because async_depth is related to nr_requests, while reviewing related >> code, patch 2-7 are cleanups and fixes to nr_reqeusts. >> >> I was planning to send this set for the next merge window, however, >> during test I found the last block pr(6.17-rc1) introduce a regression >> if nr_reqeusts grows, exit elevator will panic, and I fix this by >> patch 1,8. > > Please split the patchset into two: > > - one is for fixing recent regression on updating 'nr_requests', so this > can be merged to v6.17, and be backport easily for stable & downstream There are actually two regressions, as fixed by patch 5 and patch 8, how about the first patchset for patch 1-8? Are you good with those minor prep cleanup patches? > > - another one is for improving IO performance related with async_depth. Sure, although patch 9-16 is still a performance regression :) Thanks, Kuai > > > Thanks, > Ming > > > . >