Re: [PATCH 03/28] mfd: zl3073x: Add register access helpers

Ivan Vecera
2025-04-09T06:42:16Z

On 07. 04. 25 11:03 odp., Andrew Lunn wrote:
> On Mon, Apr 07, 2025 at 07:28:30PM +0200, Ivan Vecera wrote:
>> Add helpers zl3073x_{read,write}_reg() to access device registers.
>> These functions have to be called with device lock that can be taken
>> by zl3073x_{lock,unlock}() or a caller can use defined guard.
>
> regmap has locking. It would be good to explain in detail why regmap
> locking is not sufficient.
>
> Andrew
>
Yes, it is not sufficient. I will describe this in v2 commit description.

Thanks,
Ivan