From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78CF227703C; Thu, 27 Nov 2025 13:59:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764251942; cv=none; b=bLryU/NmJLt2jEtzqnsnbSzqx90zqeJnDKhKRiOwBFhtswLDc4th/8F428nRcIlhsOEq/ESzI2bZCVoT8t4v7YxwPYtAQz+6aSBFUqa/qBDKq5ruEy2FZQTWeMnsZmOOcLBaQXELQBs1zKMKHzRkwYoHhvPOSEvnIRUnC18fQEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764251942; c=relaxed/simple; bh=RAb5JyI+7Eg8dSIG0pq4NFV6UoD+9rhPIqCdXRp9X6Y=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AHPUbm2ur2lwD6AVCLMbS00pXwLUEm0u5R1xiqAtrHCy3hZv1iJ/UF3DUCYpvkpEd7eSskAMVGYCR7hpgFxnhIVJ3wH4my106NdYq06BvbL6FT9Yp0O8GVjpO9/ECzX58stSdn23NCW58p8lZaiRe3LrmyXfeZaokxGYwMMncFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eFQbwjzz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eFQbwjzz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B3B6C113D0; Thu, 27 Nov 2025 13:58:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764251942; bh=RAb5JyI+7Eg8dSIG0pq4NFV6UoD+9rhPIqCdXRp9X6Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=eFQbwjzzwCzmXwWVUfJOe/gvAu/FRjplhO1QM6whjf63EgQ3+FLPH1x3r1W2MZ3+n PfsuBN2TLU11T0HjnkA0gEaBlw4QgDHn02J7gHRir+GDRaR5J6IsqBlsuDpHL/CHKy JYhV6vo9Qzt+F5Av5A/Q7nVfsz27CuJUsZk2bbUKnizoGN0MpVN4tgn/2W0HGS7EOn qH4Bm/A0peR5Q67iT3PT1HxBPDseD+hDsYZohT4xyL/czWq4MUXI6uhGewEwdF09Oo qU1klZ8k4EW/acpCXfRW3Tjjn2q53lexpk0Jj4S5ofFp8qDtCzg7DvZZOTdxizvOpI KkFXXn9Qz1yKg== Message-ID: Date: Thu, 27 Nov 2025 14:58:54 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/9] dt-bindings: display: add verisilicon,dc To: Icenowy Zheng , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Drew Fustini , Guo Ren , Fu Wei , Philipp Zabel , Heiko Stuebner , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Michal Wilczynski Cc: Han Gao , Yao Zi , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org References: <20251124105226.2860845-1-uwu@icenowy.me> <20251124105226.2860845-3-uwu@icenowy.me> <544ae21cc1b5f488d03a5650d9275ff22b237d63.camel@icenowy.me> <0b7ba974-d8d5-4417-8182-3e9299315058@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 27/11/2025 14:47, Icenowy Zheng wrote: > 在 2025-11-26星期三的 11:22 +0100，Krzysztof Kozlowski写道： >> On 26/11/2025 10:50, Icenowy Zheng wrote: >>>>> +maintainers: >>>>> +  - Icenowy Zheng >>>>> + >>>>> +properties: >>>>> +  $nodename: >>>>> +    pattern: "^display@[0-9a-f]+$" >>>>> + >>>>> +  compatible: >>>>> +    items: >>>>> +      - enum: >>>>> +          - thead,th1520-dc8200 >>>>> +      - const: verisilicon,dc >>>> >>>> I do not see any explanation of exception for generic >>>> compatibles, >>>> maybe >>>> except "self-identification" remark. Rob already pointed this >>>> out, so >>>> be >>>> explicit in commit msg why you are using a generic compatible. >>> >>> Well I only get the meaning of "a SoC specific compatible is >>> required" >>> in his review message. >>> >>> I think my binding now requires both a SoC-specific compatible and >>> a >>> generic compatible, which should be okay to satisfy Rob's original >>> review. >> >> You will get then the same questions for me - what justifies generic >> compatible. You should be on this explicit, because otherwise people >> misinterpret some commits and patches, and they think the generic >> compatible is allowed for them as well. > > I came across a comment on Mali Valhall bindings that says `Mali > Valhall GPU model/revision is fully discoverable`, just after the > compatible string. > > Should I add a comment like this, or should I make things more clear in > the commit message? Just say in the commit msg in the sentence about "self-identification facility" that therefore you use generic compatible (or "generic compatible is suitable"). Please trim the context when replying. Look below: > >> >>> >>>> >>>>> + >>>>> +  reg: >>>>> +    maxItems: 1 >>>>> + >>>>> +  interrupts: >>>>> +    maxItems: 1 >>>>> + >>>>> +  clocks: >>>>> +    minItems: 4 >>>> >>>> This is not flexible. Device either has or has not these clocks. >>> >>> The existence of all these clocks are verified by diagrams in >>> manuals >> >> So not flexible, then: >> >>> of two different SoCs with DC8200 (T-Head TH1520 and StarFive >>> JH7110). >>> >>> Maybe a explicit `maxItems: 5` is needed here, but as my DT passes >>> dtbs_check, I don't think it's necessary? >> >> No, drop minItems only. >> >>> >>> Or maybe I should drop the flexibility now and use a `minItems: 5` >>> here >>> (and leave DC8000 support as another story)? (The Eswin EIC7700 >>> manual >>> does not have a diagram showing external connections of the DC, >>> like >>> the two SoCs I mentioned above). >> >> You document here only the devices explicitly mentioned in the >> binding. >> You cannot add here constraints or clocks for some device which is >> not >> in the binding and I see only th1520 in the binding. >> >> Best regards, >> Krzysztof > Is all this needed for me? If it is there I will waste time scrolling through it looking for your questions. Think how your patchset and replies are received by reviewer. Best regards, Krzysztof