Re: [PATCH v4 1/7] ref_tracker: don't use %pK in pr_ostream() output

[Jeff Layton <jlayton@kernel.org>]

On Wed, 2025-04-23 at 16:46 -0700, Jakub Kicinski wrote:
> On Fri, 18 Apr 2025 10:24:25 -0400 Jeff Layton wrote:
> > -		pr_ostream(s, "%s@%pK: couldn't get stats, error %pe\n",
> > +		pr_ostream(s, "%s@%p: couldn't get stats, error %pe\n",
> 
> FTR I think this is counter productive. 
> 
> Reference tracking is a debug feature and you may want to find that
> object with a debugger and inspect it. That's not the same as random
> drivers printing kernel addresses into logs for not apparent reason.
>
> Does kmemleak use the hashed address representation? It's a very
> similar situation.

Looking at mm/kmemleak.c, I think it doesn't. It looks like it casts
the pointers to unsigned long and prints them with %08lx:

        warn_or_seq_printf(seq, "unreferenced object%s 0x%08lx (size %zu):\n",
                           __object_type_str(object),
                           object->pointer, object->size);

I'm not sure if that's any different from %px though. I can make either
change in the name formats if that's preferred.
-- 
Jeff Layton <jlayton@kernel.org>