From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A7773FB7CE for ; Thu, 7 May 2026 18:48:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778179724; cv=none; b=qaEhKUDbrau+3Odo8VkIFtAVQIh2Ww0gqGT7j3zTVA8MB+qro6/ruiIk50bDwKfC61m+NE01YMHAqSvhG90ZZh0fqI+WhK5ukBFcso0WviGK9de4feKJuI+0RYh0zP216xryuiDjVVjdwY0yEU9pW2IyltT1tco8DjCo7TM1YlY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778179724; c=relaxed/simple; bh=vZRPUsJ8H6vPFrsZBGhZkIvVdskHA7hsrcgXl7eDv5w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZB5Z7fH9H7eB6oj/mEVp6JPHW8B1A/QCuaOJHv6pUqKhBmtj7SB96E3IiCBgQuHDs3qK0nXh33GsLmdrtP7VmTC/qIwkJB9gNw4xcC4N2fDcY71wd3OfyhV1Ek0HKNUXsrSYqaMQerIv6tZl5Hm8wkGp5/pz1Z4WgDMvAGzkh7s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wkennington.com; spf=none smtp.mailfrom=wkennington.com; dkim=pass (2048-bit key) header.d=wkennington-com.20251104.gappssmtp.com header.i=@wkennington-com.20251104.gappssmtp.com header.b=dZb7x0Nw; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wkennington.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=wkennington.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=wkennington-com.20251104.gappssmtp.com header.i=@wkennington-com.20251104.gappssmtp.com header.b="dZb7x0Nw" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-82735a41920so492431b3a.2 for ; Thu, 07 May 2026 11:48:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wkennington-com.20251104.gappssmtp.com; s=20251104; t=1778179719; x=1778784519; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qwVr3VDk6+ellI1CrTIIDHY0uhTZTZ3stNMtbHD4e4w=; b=dZb7x0NwBmKnV9JkbbLbfeFrwGIbssiaXv7tMYcvxKNvhjMpwHfIceJm0601PC24DQ y/+RZ9690kcGSdkKja2zmWyXRpdws0Su18sSJkL8QSxQkJ4JAgyHR165lHOuDiP5wU3Q izmpz7E3mnJc5Ynr6+N9lerf84KSbmQKdPHVvS/4YIv6HL5lKYWM20VyEd2vzmmJGBnP aOZb8QfkChit5youduE854Yeo4vAXWfadE02UeK0MfJ28OfQhlfxHd5+PyPYq0ewH4va 1BldAWjWI7IOv7TGBQWLo3YtAWRcD1WAKDF8AxUyclFBlsKHXhnL7GMEZx9CPQKn8wKX 5DAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778179719; x=1778784519; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qwVr3VDk6+ellI1CrTIIDHY0uhTZTZ3stNMtbHD4e4w=; b=WU+vX8KjzbKzU6ZRhH1GKQz7BzweJmdo6qFo8dsvhn6dDQMZNjhE3LN73+t8t6Gnd8 4NAntRcaBTG005NeBhMeNIegY+r26sy0H83KEoD6/WPcAoXpluWmSwULwJjjOzlSvw9P L6tCbvQ3IXuLn7iA6pvRD7rchBMfnUExfjh0xHB99xcw8IgmZexuXOq9W0MQWytYWXzy OCt8EQlIZ1Nqt6AaNLH8N5Aq7qk+szKn3AyK5j+HstEO/D85qkciUKTNP3H6k9lQwuez PBNaoWVSaOYychWtLigL8gMyZslHY+qMRXFSOOUAZWb7HgAS40zsEIpMi2rhnpig1Q/l gLDw== X-Forwarded-Encrypted: i=1; AFNElJ8DQL0zp8R5mS8MrOgkZmSwyCrijrndnMuMmSQM25cmy9y9rdQVxkPHm4c/N4/LOZa+k16V/8Chm9sTnC4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/mbp2sJA6tU79cE1m596LV30Uun41ISSk/2GDrh3R6mkEG7sc rZjXPxuBjpLzDoWnWsnLcdR01gyT2aQDYqt15MTg1FMs7A/fEJBqd5lxNPHu0FIEpSpaLev8H+N Jb5/hk+w= X-Gm-Gg: AeBDietGSLZj6FbFJuiOE0ok07lUO3+eBg5cpere0dYl7oA3TJ9NdHtEw8gzNy2f+nB pXjPgY9gn1uYoZh8R+6AUIqr0skSAAqdYT3jFBLWznpXgasexvZHiKErK8PyKuDj+LLs0mVc61K tJ7U5/ylMvD+5kkUIkeHGIWpT1tvInt8oO3gBW6jsIVI/6DFRsRNZTvvKqwA9rCzV0NBxh4YVnC FAsrlb4mOdgm+Dk2+Dx7KBR+3B8PS34/oOkQF8uXXFDBxbdEPgTo2LkVmqqUN91cZdjVi2CCoBt RiAshtGr8mK/s9YTwVncbJxBfahO/JxeN2zBnBZub7/v6dleEu5g1J4DfQqkzL1ufkyUHLrLht8 k1UQkxX0+toI2IMZgF60CWcFYEGATvRJBEmoYTle1JINH09VCHq/1ddFn/wFG89P+AVbZovKu0I R650ZDXCoT17OyYQy9PcgzCQHxrxrNb5YzjqTgawmDul+h/oqzGxC9ygeY22+olfXRhDFFgzYL6 WWCWGH+QuB8MGYvTnY/IEDzaTHq8vVyTLFWaaR5W4WXz3ccs4Qw+qEpGE9H67hH X-Received: by 2002:a05:6a00:ad09:b0:82d:62ed:b01d with SMTP id d2e1a72fcca58-83a5e344711mr9203824b3a.45.1778179719422; Thu, 07 May 2026 11:48:39 -0700 (PDT) Received: from ?IPV6:2a00:79e1:2e00:d201:e58:7bff:fe94:34ed? ([2a00:79e1:2e00:d201:e58:7bff:fe94:34ed]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83967dbcf16sm11292951b3a.40.2026.05.07.11.48.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 11:48:38 -0700 (PDT) Message-ID: Date: Thu, 7 May 2026 11:48:38 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/4] i2c: designware: Introduce shutdown exported function To: Andy Shevchenko Cc: Mika Westerberg , Jan Dabros , Andi Shyti , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260504-dw-i2c-v3-0-57e56135d602@wkennington.com> <20260504-dw-i2c-v3-1-57e56135d602@wkennington.com> <471722ab-a6f2-4e21-9b68-ef2050ec4e65@wkennington.com> Content-Language: en-US From: "William A. Kennington III" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/7/26 03:04, Andy Shevchenko wrote: > On Thu, May 07, 2026 at 12:56:50AM -0700, William A. Kennington III wrote: >> On 5/5/26 00:29, Andy Shevchenko wrote: >>> On Mon, May 04, 2026 at 08:15:02PM +0000, William A. Kennington III wrote: >>>> Introduce an exported shutdown function to safely shutdown the >>>> DesignWare I2C controller. >>>> >>>> This shutdown hook gracefully sets the slave disable bit before disabling >>>> the controller. This guarantees that any incoming requests from the master >>>> are immediately NACKed during shutdown, preventing the bus from hanging. > ... > >> Is this just language correction? > I have asked for replacing 'slave'/'master' terminology to a new, > inclusive one. Yeah, this is exactly what I figured I just wanted to make sure I didn't misunderstand. I updated all of those cases in all the patches. > ... > > >>>> + /* >>>> + * We only need to handle shutdown for slave mode to ensure >>>> + * we NACK any incoming master requests. Master mode cleanup >>>> + * is handled after each transfer in i2c_dw_xfer. >>> i2c_dw_xfer() >>> >>>> + */ >>> Since it's a newly added comment, can you switch to use inclusive language? >>> Same for the whole series related to the commit messages, comments, and >>> documentation. > Same here and... > >>>> + /* >>>> + * To quickly NACK the master during shutdown, we set the slave >>>> + * disable bit while the controller is still enabled. >>>> + */ > ...here. > > ... > >>>> +EXPORT_SYMBOL_GPL(i2c_dw_shutdown); >>> Can we use namespace? >> It already does use namespaces with >> >> `#define DEFAULT_SYMBOL_NAMESPACE    "I2C_DW_COMMON"` >> >> I assume I should just keep it consistent as-is? > Yep, thanks for pointing that out! >