Re: [ath5k-devel] [PATCH] ath5k: fix detection of jumbo frames

["Bob Copeland" <me@bobcopeland.com>]

On Mon, Nov 3, 2008 at 8:35 AM, Pavel Roskin <proski@gnu.org> wrote:
> Thanks for catching it!  Please mention rs_antenna in addition to
> rs_more.
>
>> -     rs->rs_antenna = rx_status->rx_status_0 &
>> -             AR5K_5210_RX_DESC_STATUS0_RECEIVE_ANTENNA;
>> -     rs->rs_more = rx_status->rx_status_0 &
>> -             AR5K_5210_RX_DESC_STATUS0_MORE;
>> +     rs->rs_antenna = AR5K_REG_MS(rx_status->rx_status_0,
>> +             AR5K_5210_RX_DESC_STATUS0_RECEIVE_ANTENNA);
>> +     rs->rs_more = AR5K_REG_MS(rx_status->rx_status_0,
>> +             AR5K_5210_RX_DESC_STATUS0_MORE);
>
> rs_more should be boolean.  It would be better to use "!!" to calculate
> rs_rate.  No need to shift anything.  As for rs_antenna, it's fine with
   ^^^^^^
I assume you meant rs_more again:  rs_more = !!(rx_status_0 & ...)

>> +#define AR5K_5212_RX_DESC_STATUS0_DECOMP_CRC_ERROR_S 13
>
> This doesn't belong to the patch.  It looks like it's another boolean
> value, but it's not currently used.

ACK, all valid.  I'll respin.

-- 
Bob Copeland %% www.bobcopeland.com