From: Baolu Lu <baolu.lu@linux.intel.com>
To: Diederik de Haas <didi.debian@cknow.org>,
David Woodhouse <dwmw2@infradead.org>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>
Cc: baolu.lu@linux.intel.com, Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: device_def_domain_type documentation header does not match implementation
Date: Fri, 31 May 2024 09:17:05 +0800 [thread overview]
Message-ID: <b6ebac8d-02f5-4153-b687-a4d40056f697@linux.intel.com> (raw)
In-Reply-To: <14311965.TaHA55BQu8@bagend>
On 5/30/24 9:57 PM, Diederik de Haas wrote:
> While looking into ``drivers/iommu/intel/iommu.c::device_def_domain_type``
> function I noticed a discrepancy between the documentation header and the
> implementation.
>
> ``@startup: true if this is during early boot``
> 0e31a7266508 ("iommu/vt-d: Remove startup parameter from
> device_def_domain_type()")
> removed the ``startup`` function parameter
>
> returns ``IOMMU_DOMAIN_DMA: device requires a dynamic mapping domain``
> 28b41e2c6aeb ("iommu: Move def_domain type check for untrusted device into
> core")
> moved the possible return of ``IOMMU_DOMAIN_DMA`` to ``drivers/iommu/iommu.c``
>
> But neither updated the documentation header.
Yeah, I think the @startup line should be removed. It is irrelevant.
Others remain good to me.
Best regards,
baolu
prev parent reply other threads:[~2024-05-31 1:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 13:57 device_def_domain_type documentation header does not match implementation Diederik de Haas
2024-05-30 15:49 ` Robin Murphy
2024-05-30 16:06 ` Diederik de Haas
2024-05-31 1:19 ` Baolu Lu
2024-05-31 1:17 ` Baolu Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6ebac8d-02f5-4153-b687-a4d40056f697@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=didi.debian@cknow.org \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox