The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Mike Galbraith <efault@gmx.de>, lkml <linux-kernel@vger.kernel.org>
Cc: nouveau@lists.freedesktop.org, Ben Skeggs <bskeggs@redhat.com>,
	Dave Airlie <airlied@redhat.com>
Subject: Re: drm/nouneau: 5.11 cycle regression bisected to 461619f5c324 "drm/nouveau: switch to new allocator"
Date: Wed, 10 Feb 2021 16:34:42 +0100	[thread overview]
Message-ID: <b72ee235-2a79-bf88-a220-6e34d30a4bbe@amd.com> (raw)
In-Reply-To: <6b2fa70c333d49dee64fa3c96cd7b7c99e8a6e9b.camel@gmx.de>



Am 10.02.21 um 16:30 schrieb Mike Galbraith:
> On Wed, 2021-02-10 at 14:26 +0100, Christian König wrote:
>> Am 10.02.21 um 13:22 schrieb Mike Galbraith:
>>> On Wed, 2021-02-10 at 12:44 +0100, Christian König wrote:
>>>> Please try to add a "return NULL" at the beginning of ttm_pool_type_take().
>>>>
>>>> That should effectively disable using the pool.
>>> That did away with the yield looping, but it doesn't take long for the
>>> display to freeze.  I ssh'd in from lappy, but there was nada in dmesg.
>> Yeah, that is expected. Without taking pages from the pool we leak
>> memory like sieve.
>>
>> At least we could narrow down the problem quite a bit with that.
>>
>> Can you test the attached patch and see if it helps?
> Yup, that seems to have fixed it all up.  Another one bites the dust ;)

Ah! So basically nouveau relies on that the pages are cleared.

Yeah, that wasn't consitently implemented before. Some code path was 
clearing the page, some wasn't.

Any objections that I add a Reported-and-tested-by: Mike Galbraith 
<efault@gmx.de> ?

Regards,
Christian.

>
> 	-Mike
>


  reply	other threads:[~2021-02-10 15:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 10:13 drm/nouneau: 5.11 cycle regression bisected to 461619f5c324 "drm/nouveau: switch to new allocator" Mike Galbraith
2021-02-10 10:34 ` Christian König
2021-02-10 10:40   ` Mike Galbraith
2021-02-10 10:42     ` Christian König
2021-02-10 11:06       ` Mike Galbraith
2021-02-10 10:46   ` Mike Galbraith
2021-02-10 10:52     ` Christian König
2021-02-10 11:22       ` Mike Galbraith
2021-02-10 11:44         ` Christian König
2021-02-10 12:22           ` Mike Galbraith
2021-02-10 13:26             ` Christian König
2021-02-10 15:30               ` Mike Galbraith
2021-02-10 15:34                 ` Christian König [this message]
2021-02-10 15:37                   ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b72ee235-2a79-bf88-a220-6e34d30a4bbe@amd.com \
    --to=christian.koenig@amd.com \
    --cc=airlied@redhat.com \
    --cc=bskeggs@redhat.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox