From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AA713451BD for ; Sat, 9 May 2026 23:33:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778369617; cv=none; b=roWne/3mjv0su8/hOsSm8hx60yIhV7T+Exe1KrxKomZXbujjlES9J44ltudNVw6dhYm6pSNUQajWiWK+TLAizUKpwrMxiB9O3oLL9i4afk7gGGp1dfGNqjpu5I7kWwltltaA331e53F2CSf+AlZEYL2YnKYk9v9GBmZ9E1kIQEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778369617; c=relaxed/simple; bh=tS2ZOwwLAK44zzC8KJkgqLe54SK6fFDD9Mz8fNc8SFY=; h=Message-ID:Date:MIME-Version:To:Cc:From:Subject:Content-Type; b=pZP9DNURnkbk3pnuL5zKSWbD0oDjY+TtK00jqluKto6tKcEY8ADPOdGDzHEybMjNYdvpWNe+La5Tb+hJhIWQ6EdsuPgTvBtSxgWOzjBQBxOclX1M27gJKTW7fvwEndxihgne6X2SsdIMKxJACUo1dSBEyQ1FavBcj8yM8KWUm6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Rr5h6Dk6; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rr5h6Dk6" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-45297094718so2469525f8f.3 for ; Sat, 09 May 2026 16:33:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778369614; x=1778974414; darn=vger.kernel.org; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=BVG5zt/COxsE1iTVHgCjqR8vjJKT8VaVSfahJvIXRIY=; b=Rr5h6Dk6FZaxD/57ZmEOoWoe5CCsLkQV8wZjLGdsfueg+rOQ9OxrcNGiBPW9wWH0jb ESrEow+ABBjCJ3jMAcVEPss/LnD14vtsQvXJ0i6bi5Lae/N9lq4lecDhFcKMmFuwTcSx jqDr9OJ9PJYzPVlTIaLIOUWSgkvZ/UX9p7li9+M9wuRISRPAjsAYkxjRkFfsa/bSQ+iK 82yE/ONud/Tj2rrfExfcQCxlDyhKr8WiN9taih46rEJYfDLtYCz/f9JcnqQ1HIPOBfVZ CjKJ459m06c/vR6i9eFduzPdq4eKA4ZqidFSJO0EFbGdNW8HWWFmK2SKaDUZcMNya6f2 oCiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778369614; x=1778974414; h=content-transfer-encoding:subject:from:cc:to:content-language :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=BVG5zt/COxsE1iTVHgCjqR8vjJKT8VaVSfahJvIXRIY=; b=r0oRjfzV3me+3u1D3Y9OibCdAfV2vbsl9NKV7Y596A9jvSf3JbgzrO90F3cOyQa9H0 skOw7bAwX9NzhpmOJOm2SfbDCmFOzLUpR/Nw1H8wgaujL0cAtXh2+LqsTSGGh/VWHTpM 8kjW4KaMScSz+A3IpEvu8yfKWvL8IIXorlZRdj+3++qtaHfiDoPSZ4Qv2wqJKgpkA5b9 ulXUSE5OE0g+OZN/sX9qMdTKWPoCdZm1gZNg/6+4zYDGZsGF2+Y5sZSBH5MWFAKVSEDV TwRyfuBDtMv6B3ZbTJB/3+wzbGHcoB+3/rVtZ8NSItXJPO7TXM4W3yJ/jzWUI1hY5vrq lPzg== X-Forwarded-Encrypted: i=1; AFNElJ+obW4R4YtKc2dd8T+OVzuuStqWfZHc/upM1zFiCFICWev4wJoWKP3h8B5sxAvGnCceBEGYo7YcVsnbNb4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8XGQFILmjm3hUpmk68Ag25fmUlPyuJb0NhFngnBxVQTUq98wp kmvRl+Jj5oQ/RCAA5gf+h253U8kvqYIMjsyAd3wg4pyIMXBnIEzGzZwT X-Gm-Gg: Acq92OEUkAJus9BUkYn6CJk4H9n1ROxNF+IKH2ETOic6ghOvIsQzJmOQTffEjjAoGa9 fVWXzRKaiYqZKxVSNWkgEQeepW7emHER1JRUknNgFafV36o3RpbB6eatpt7Vm48Jz30TPpIa/FU frBx8gq9Neq0F+dkIPHv4K66M6nIz63Q/VsTCQZTyOmFd9+W/0yJwCfwauogzJezwSMjUR4mKwF wClFdItcGVIgOXBsax5LqlBRVOvRbjsKWJTeDGF8w78dTHrUPV7F8RmY9Y730BFw87w2A5S7B4T yANcan7Jd331aD1yYxFtsbTlaPT/tXVRujg3aDJWa29PqioCn7wOjXKNqGjU75UuVYspe8jahSt QIpRS0jguj53TqO3qL/nwkIyD9E/Kq4aKBrJFgBFPEfpeuxQVJ1UJM0VjX0OfaW+RJigrfDs1jn Nv5zMxnC29PHKBE7StKJB/gyvPa2aY/zQ4Sxz9Rzj0q8+CPJp2vaLkhi83YE0TL8+yox8a1qkiN gxHFK3P8PiZ4wdymKPMjp3hdRHeKQ== X-Received: by 2002:a5d:5d87:0:b0:43d:6a0c:9571 with SMTP id ffacd0b85a97d-4515b61a683mr29155653f8f.11.1778369614359; Sat, 09 May 2026 16:33:34 -0700 (PDT) Received: from ?IPV6:2a02:2f04:a405:b300:e2a1:1a24:245d:ce04? ([2a02:2f04:a405:b300:e2a1:1a24:245d:ce04]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4548ec6b00fsm16193195f8f.11.2026.05.09.16.33.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 May 2026 16:33:33 -0700 (PDT) Message-ID: Date: Sun, 10 May 2026 02:33:32 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org Cc: almaz.alexandrovich@paragon-software.com, m.brodschi@gmail.com From: Mihai Brodschi Subject: [PATCH] ntfs3: Allocate iomap inline_data using alloc_page Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit This fixes a BUG reported in iomap_write_end_inline: iomap_inline_data_valid checks that the inline_data fits within a page. If the inline_data is allocated with kmemdup there's no guarantee that it's page-aligned, so the check sometimes fails. Allocate it with alloc_page to ensure it's page-aligned. Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221446 Signed-off-by: Mihai Brodschi Fixes: 099ef9a ("fs/ntfs3: implement iomap-based file operations") --- fs/ntfs3/attrib.c | 9 ++++++--- fs/ntfs3/inode.c | 4 ++-- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/fs/ntfs3/attrib.c b/fs/ntfs3/attrib.c index e61c5bf7e27e..f72848d077b9 100644 --- a/fs/ntfs3/attrib.c +++ b/fs/ntfs3/attrib.c @@ -1042,10 +1042,13 @@ int attr_data_get_block_locked(struct ntfs_inode *ni, CLST vcn, CLST clen, *lcn = RESIDENT_LCN; *len = data_size; if (res && data_size) { - *res = kmemdup(resident_data(attr_b), data_size, - GFP_KERNEL); - if (!*res) + void *page = alloc_page(GFP_KERNEL); + if (!page) { err = -ENOMEM; + } else { + *res = page_address(page); + memcpy(*res, resident_data(attr_b), data_size); + } } goto out; } diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c index 42af1abe17f8..031f85fd53d4 100644 --- a/fs/ntfs3/inode.c +++ b/fs/ntfs3/inode.c @@ -801,7 +801,7 @@ static int ntfs_iomap_begin(struct inode *inode, loff_t offset, loff_t length, if (lcn == RESIDENT_LCN) { if (offset >= clen) { - kfree(res); + __free_page(virt_to_page(res)); if (flags & IOMAP_REPORT) { /* special code for report. */ return -ENOENT; @@ -921,7 +921,7 @@ static int ntfs_iomap_end(struct inode *inode, loff_t pos, loff_t length, out: if (iomap->type == IOMAP_INLINE) { - kfree(iomap->private); + __free_page(virt_to_page(iomap->private)); iomap->private = NULL; } -- 2.53.0