From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28B25C12002 for ; Fri, 16 Jul 2021 10:24:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 003A1613F2 for ; Fri, 16 Jul 2021 10:24:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238191AbhGPK1b (ORCPT ); Fri, 16 Jul 2021 06:27:31 -0400 Received: from imap2.colo.codethink.co.uk ([78.40.148.184]:36214 "EHLO imap2.colo.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239175AbhGPK0r (ORCPT ); Fri, 16 Jul 2021 06:26:47 -0400 Received: from [167.98.27.226] (helo=[10.35.5.170]) by imap2.colo.codethink.co.uk with esmtpsa (Exim 4.92 #3 (Debian)) id 1m4L0W-0006x0-GA; Fri, 16 Jul 2021 11:23:48 +0100 Subject: Re: [PATCH] riscv: add correct as-options for assembly in modules To: linux-kernel@lists.codethink.co.uk, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou References: <20210712174849.2202287-1-ben.dooks@codethink.co.uk> From: Ben Dooks Organization: Codethink Limited. Message-ID: Date: Fri, 16 Jul 2021 11:23:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210712174849.2202287-1-ben.dooks@codethink.co.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/07/2021 18:48, Ben Dooks wrote: > When trying to load modules built for riscv which include assembly > the kernel loader errors with "unexpected relocation type 'R_RISCV_ALIGN'" > due to R_RISCV_ALIGN relocations being generated by the assembler. > > In commit 7a8e7da42250138 ("RISC-V: Fixes to module loading") > the fix for gcc adds -mno-relax to the command line when building > C files. However this was never applied to assembly flags, and gcc > does no pass -mno-relax to gas when presented with a .S file. > > The fix (other than making gcc always pass -mno-relax to gas) is > to add -Wa,-mno-relax to gcc to make sure the as is invoked with > the right options. > > Signed-off-by: Ben Dooks Just wanted to find out if anyone has had time to review this. If this is ok, should we also send to -stable ? > --- > arch/riscv/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile > index 1f5c03082976..fca40511a8c6 100644 > --- a/arch/riscv/Makefile > +++ b/arch/riscv/Makefile > @@ -60,6 +60,7 @@ ifeq ($(CONFIG_PERF_EVENTS),y) > endif > > KBUILD_CFLAGS_MODULE += $(call cc-option,-mno-relax) > +KBUILD_AFLAGS_MODULE += $(call as-option,-Wa$(comma)-mno-relax) > > # GCC versions that support the "-mstrict-align" option default to allowing > # unaligned accesses. While unaligned accesses are explicitly allowed in the > -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html