* [PATCH] doc: fs: remove bdev_try_to_free_page related doc
@ 2021-12-23 3:51 Zhiqiang Liu
2021-12-23 12:57 ` Jan Kara
2021-12-23 14:15 ` Jens Axboe
0 siblings, 2 replies; 4+ messages in thread
From: Zhiqiang Liu @ 2021-12-23 3:51 UTC (permalink / raw)
To: corbet, Jan Kara, Darrick J. Wong, axboe, zhangyi (F),
linux-kernel@vger.kernel.org
Cc: linux-doc, linfeilong
In commit acc6100d3ffa ("fs: remove bdev_try_to_free_page callback"),
bdev_try_to_free_page has been removed.
We should remove its doc.
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
---
Documentation/filesystems/locking.rst | 5 -----
1 file changed, 5 deletions(-)
diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst
index d36fe79167b3..3f9b1497ebb8 100644
--- a/Documentation/filesystems/locking.rst
+++ b/Documentation/filesystems/locking.rst
@@ -169,7 +169,6 @@ prototypes::
int (*show_options)(struct seq_file *, struct dentry *);
ssize_t (*quota_read)(struct super_block *, int, char *, size_t, loff_t);
ssize_t (*quota_write)(struct super_block *, int, const char *, size_t, loff_t);
- int (*bdev_try_to_free_page)(struct super_block*, struct page*, gfp_t);
locking rules:
All may block [not true, see below]
@@ -194,7 +193,6 @@ umount_begin: no
show_options: no (namespace_sem)
quota_read: no (see below)
quota_write: no (see below)
-bdev_try_to_free_page: no (see below)
====================== ============ ========================
->statfs() has s_umount (shared) when called by ustat(2) (native or
@@ -210,9 +208,6 @@ dqio_sem) (unless an admin really wants to screw up something and
writes to quota files with quotas on). For other details about locking
see also dquot_operations section.
-->bdev_try_to_free_page is called from the ->releasepage handler of
-the block device inode. See there for more details.
-
file_system_type
================
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] doc: fs: remove bdev_try_to_free_page related doc
2021-12-23 3:51 [PATCH] doc: fs: remove bdev_try_to_free_page related doc Zhiqiang Liu
@ 2021-12-23 12:57 ` Jan Kara
2021-12-23 14:15 ` Jens Axboe
1 sibling, 0 replies; 4+ messages in thread
From: Jan Kara @ 2021-12-23 12:57 UTC (permalink / raw)
To: Zhiqiang Liu
Cc: corbet, Jan Kara, Darrick J. Wong, axboe, zhangyi (F),
linux-kernel@vger.kernel.org, linux-doc, linfeilong
On Thu 23-12-21 11:51:00, Zhiqiang Liu wrote:
>
> In commit acc6100d3ffa ("fs: remove bdev_try_to_free_page callback"),
> bdev_try_to_free_page has been removed.
>
> We should remove its doc.
>
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Indeed. Thanks. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> Documentation/filesystems/locking.rst | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst
> index d36fe79167b3..3f9b1497ebb8 100644
> --- a/Documentation/filesystems/locking.rst
> +++ b/Documentation/filesystems/locking.rst
> @@ -169,7 +169,6 @@ prototypes::
> int (*show_options)(struct seq_file *, struct dentry *);
> ssize_t (*quota_read)(struct super_block *, int, char *, size_t, loff_t);
> ssize_t (*quota_write)(struct super_block *, int, const char *, size_t, loff_t);
> - int (*bdev_try_to_free_page)(struct super_block*, struct page*, gfp_t);
>
> locking rules:
> All may block [not true, see below]
> @@ -194,7 +193,6 @@ umount_begin: no
> show_options: no (namespace_sem)
> quota_read: no (see below)
> quota_write: no (see below)
> -bdev_try_to_free_page: no (see below)
> ====================== ============ ========================
>
> ->statfs() has s_umount (shared) when called by ustat(2) (native or
> @@ -210,9 +208,6 @@ dqio_sem) (unless an admin really wants to screw up something and
> writes to quota files with quotas on). For other details about locking
> see also dquot_operations section.
>
> -->bdev_try_to_free_page is called from the ->releasepage handler of
> -the block device inode. See there for more details.
> -
> file_system_type
> ================
>
> --
> 2.23.0
>
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] doc: fs: remove bdev_try_to_free_page related doc
2021-12-23 3:51 [PATCH] doc: fs: remove bdev_try_to_free_page related doc Zhiqiang Liu
2021-12-23 12:57 ` Jan Kara
@ 2021-12-23 14:15 ` Jens Axboe
2021-12-23 19:41 ` Jonathan Corbet
1 sibling, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2021-12-23 14:15 UTC (permalink / raw)
To: Zhiqiang Liu, corbet, Jan Kara, Darrick J. Wong, zhangyi (F),
linux-kernel@vger.kernel.org
Cc: linux-doc, linfeilong
On 12/22/21 8:51 PM, Zhiqiang Liu wrote:
>
> In commit acc6100d3ffa ("fs: remove bdev_try_to_free_page callback"),
> bdev_try_to_free_page has been removed.
>
> We should remove its doc.
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Jon, I'm assuming you'll take this one through the doc tree.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] doc: fs: remove bdev_try_to_free_page related doc
2021-12-23 14:15 ` Jens Axboe
@ 2021-12-23 19:41 ` Jonathan Corbet
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Corbet @ 2021-12-23 19:41 UTC (permalink / raw)
To: Jens Axboe, Zhiqiang Liu, Jan Kara, Darrick J. Wong, zhangyi (F),
linux-kernel@vger.kernel.org
Cc: linux-doc, linfeilong
Jens Axboe <axboe@kernel.dk> writes:
> On 12/22/21 8:51 PM, Zhiqiang Liu wrote:
>>
>> In commit acc6100d3ffa ("fs: remove bdev_try_to_free_page callback"),
>> bdev_try_to_free_page has been removed.
>>
>> We should remove its doc.
>
> Reviewed-by: Jens Axboe <axboe@kernel.dk>
>
> Jon, I'm assuming you'll take this one through the doc tree.
Applied, thanks.
jon
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-23 19:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-23 3:51 [PATCH] doc: fs: remove bdev_try_to_free_page related doc Zhiqiang Liu
2021-12-23 12:57 ` Jan Kara
2021-12-23 14:15 ` Jens Axboe
2021-12-23 19:41 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox