From: Markus Elfring <Markus.Elfring@web.de>
To: Hou Tao <houtao@huaweicloud.com>,
bpf@vger.kernel.org, linux-input@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
David Vernet <void@manifault.com>, Jiri Kosina <jikos@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, cocci@inria.fr
Subject: Re: HID: bpf: One function call less in call_hid_bpf_rdesc_fixup() after error detection
Date: Wed, 27 Dec 2023 09:19:27 +0100 [thread overview]
Message-ID: <b75d66cc-a507-432a-af60-655950671b8a@web.de> (raw)
In-Reply-To: <618f886f-b2ff-4d50-cf74-e8478a7e8547@huaweicloud.com>
>> The kfree() function was called in one case by the
>> call_hid_bpf_rdesc_fixup() function during error handling
>> even if the passed data structure member contained a null pointer.
>> This issue was detected by using the Coccinelle software.
>
> It is totally OK to free a null pointer through kfree() and the ENOMEM
> case is an unlikely case, so I don't think the patch is necessary.
Would you ever like to avoid redundant data processing a bit more?
Regards,
Markus
next prev parent reply other threads:[~2023-12-27 8:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-26 18:24 [PATCH] HID: bpf: One function call less in call_hid_bpf_rdesc_fixup() after error detection Markus Elfring
2023-12-27 1:13 ` Hou Tao
2023-12-27 8:19 ` Markus Elfring [this message]
2023-12-27 15:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b75d66cc-a507-432a-af60-655950671b8a@web.de \
--to=markus.elfring@web.de \
--cc=ast@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=cocci@inria.fr \
--cc=houtao@huaweicloud.com \
--cc=jikos@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox