From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD00CC433FE for ; Mon, 28 Nov 2022 07:08:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229940AbiK1HIR (ORCPT ); Mon, 28 Nov 2022 02:08:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229723AbiK1HIJ (ORCPT ); Mon, 28 Nov 2022 02:08:09 -0500 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 857EEBF6D; Sun, 27 Nov 2022 23:08:06 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=tianjia.zhang@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0VVqYIHI_1669619281; Received: from 30.27.90.133(mailfrom:tianjia.zhang@linux.alibaba.com fp:SMTPD_---0VVqYIHI_1669619281) by smtp.aliyun-inc.com; Mon, 28 Nov 2022 15:08:03 +0800 Message-ID: Date: Mon, 28 Nov 2022 15:08:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH] selftests/tls: Fix tls selftests dependency to correct algorithm Content-Language: en-US To: Bagas Sanjaya Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Shuah Khan , "Jason A. Donenfeld" , Herbert Xu , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221125121905.88292-1-tianjia.zhang@linux.alibaba.com> From: Tianjia Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bagas, On 11/25/22 9:18 PM, Bagas Sanjaya wrote: > On Fri, Nov 25, 2022 at 08:19:05PM +0800, Tianjia Zhang wrote: >> Commit d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") moves >> the SM3 and SM4 stand-alone library and the algorithm implementation for >> the Crypto API into the same directory, and the corresponding relationship >> of Kconfig is modified, CONFIG_CRYPTO_SM3/4 corresponds to the stand-alone >> library of SM3/4, and CONFIG_CRYPTO_SM3/4_GENERIC corresponds to the >> algorithm implementation for the Crypto API. Therefore, it is necessary >> for this module to depend on the correct algorithm. >> > > I feel a rather confused. What about below? > > ``` > Commit moves SM3 and SM4 algorithm implementations from > stand-alone library to crypto API. The corresponding configuration > options for the API version (generic) are CONFIG_CRYPTO_SM3_GENERIC and > CONFIG_CRYPTO_SM4_GENERIC, respectively. > > Replace option selected in selftests configuration from the library version > to the API version. > ``` > Thanks, this is great, I will pick it up. >> Fixes: d2825fa9365d ("crypto: sm3,sm4 - move into crypto directory") >> Cc: Jason A. Donenfeld >> Cc: stable@vger.kernel.org # v5.19+ >> Signed-off-by: Tianjia Zhang >> --- >> tools/testing/selftests/net/config | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config >> index ead7963b9bf0..bd89198cd817 100644 >> --- a/tools/testing/selftests/net/config >> +++ b/tools/testing/selftests/net/config >> @@ -43,5 +43,5 @@ CONFIG_NET_ACT_TUNNEL_KEY=m >> CONFIG_NET_ACT_MIRRED=m >> CONFIG_BAREUDP=m >> CONFIG_IPV6_IOAM6_LWTUNNEL=y >> -CONFIG_CRYPTO_SM4=y >> +CONFIG_CRYPTO_SM4_GENERIC=y >> CONFIG_AMT=m > > You mean the correct algo option is CONFIG_CRYPTO_SM4_GENERIC, right? > Yes, CONFIG_CRYPTO_SM4_GENERIC is the correct algo option. Best regards, Tianjia