From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEBF2425CCE for ; Tue, 9 Jun 2026 13:48:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781012921; cv=none; b=Yr/YnthewX0KE2uYfz0xprSHXsXb063c821j40uvEnKTh2sajVkFmDGvsCKmFu8bTZZsgKkiOSbZsJFGxGNvnry3GHJc3fQBDsKGKD4XVlbtv8gbakmtJFbB7OqDcr3isgZ6iyxLr9S7LYJKNK6eXnrnNI7pGoxWmrNjODhyCwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781012921; c=relaxed/simple; bh=QLTukfq8tB6NdhVZj38LzdPBdu9w7A6hXB64MHrlJIc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BDTi3vLLS5TdWlY1oM3BtOPHrvI1wUC/qaGRs2KVP/byxlhI0fRLqFP8kDhSsCjMLxK4wbqQJ5V1+uklnwCgwIeF8G9pQAEzQL8NCfN6lc5nBGGRKOyLDQC5lZG6M7Noo/JUOJy56m1HklDLkOo85hD06h4Na0EsptYQCK7uy8o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SKtC9HCr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RJjb4FOj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SKtC9HCr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RJjb4FOj" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 659CnKd92668476 for ; Tue, 9 Jun 2026 13:48:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= evslsdU9NHDAqMtO0VHfpNewdxcF2fUkpvL0SD3UiIA=; b=SKtC9HCrHe5jhBwZ hhPoP/3JWA8tEQFsCo/NXGxVcqr4eydavVpBR4p6TmF/p4b+7xIiZlJiOyYJsrDw bBTDGWNHWXrZOjFGfmV+O/CMkDZ+330gBPkIJ1WvaT9B+wGZaV/Ghj2qCMWJlupI ljKYPGU2eo0ytvIVJgjUw+nEJqABlghz/Y+QLZEw6CDTMLi5KjcOgXRbqrZcCvqC kcT85oh2GPVrk9C7n9ZgV3p23mvMyxnh3StmhtXVauA5GpqBMz5waeBLpuT7FDv2 8wp9WE5G6smUSddkCoMT9qYr8ZnWpKXBE9OIK2+h7KIztrm4MWD2ghW56r5q51Uh F2M/ng== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4epe25sqwc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 09 Jun 2026 13:48:38 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5176891d0a9so14239551cf.0 for ; Tue, 09 Jun 2026 06:48:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781012918; x=1781617718; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=evslsdU9NHDAqMtO0VHfpNewdxcF2fUkpvL0SD3UiIA=; b=RJjb4FOj7RbGJc7pYtKynhftZmBpBJ4clqw7ws0soLE3iZ1xtOeBh7RxLA+l/F1Ui5 BMiOvo3joYry0oIG50yu8Moz+L7cpNSwQEAGnAMM0TjvJq5cJNAarXv96MpwAD5mb1w2 Gshgu1iorhsW037My1WgXiGjiSu1OFQV+RrRLQgfBflvaD/5+YLiolLIpISkNEr0V6fg WIiqktWlzYp6ec31xwD27W5n9fzlHhye5zPa2AnhhCItj9Z9qrh9lZoxt8oUXlCdToTi sR8Tn6ewoqyM1oZXx8LOF7/E+F8Cdwb1dmAfe9/fo8C0/9qCFB1Gq2hqt/A0sk0I2lHR 4HMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781012918; x=1781617718; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=evslsdU9NHDAqMtO0VHfpNewdxcF2fUkpvL0SD3UiIA=; b=A8QIwBlHOIUqfIprhDqmaQlKJJ6a+O1EUhGencUhvVR67nTyeUZ9KZqPL/bQEK2lQl Jnba8AqAQ9RfWjNrV0r7ddKpmUGPE/GsopNc67Y1Res+LGrU152DYjENqRrjwoZMH11F uSm/uxvURPtj+CaE1YY00EDToNf7zB4cArriwKhPGr7ggBvea+VGjQyDuFVTSTgUvAIP JEd5zogm1a1j0eRu5rkByxHPcXOuHj3K0FqOpSwx1eQwWp/m3nfddsS+0VCwas4jaS6V gvXa+ZAfU1lpI7NZfbERlyMOXCR10NLV/A6FjvUpMdDA9mP2yuTWwEw4iSSqpMJhsmLP RX6w== X-Forwarded-Encrypted: i=1; AFNElJ/dxK8oeW/0wgUXJFXdbcSJz5SZmzAbZ47zAFKbZS8RF7YPmkkW+Gu+pTe2xne0PF7i1Fz/gHoqL3r5Jig=@vger.kernel.org X-Gm-Message-State: AOJu0YyOyM7ua2ggS4ooxXyniJuDpxhh+Owr/0JlaCAEoBm2P6pz4yad x+o/V8Uk4jGVr86L9CxPh2VJGILIjJR3pBCRGh3hIYMc/Jgr4q/z1uTmgLepUeA4TH9yckidvWp mbzXrl8cPajFRB+1H6H7qYBaqUzzftboxG1nbrfwuNs9CxvzFxrQ/d+0R16NBr9Y5M24= X-Gm-Gg: Acq92OGO3pRJA+ZrUnJgTIOK6112o4BM9naHRMULk7CVHchtbljZaV8b/LwO/ZoC7+C /QlJFZ2vW8l/CeLWhCQtwmm0MQmJvx2+toedLMntbMTycwMsgDC20ei2Ypfecx6Do4Kg7QC3P79 bUs3MD9Apq73BawS329aGFAc1Ft6gfFAFpPbccT5av14oQCCnYdmCItAhBdDyaTPdOLC780cHBK GQrCf2oPOj2sKxvwRsc7o/DqeCP+gwDcdOvX2cwfowllD6bNcHPVdnB0VMYZD3KuXUO71aqGnUF FPI0u1Q86HC08mOEM6ZcilhVaZK4CSaF+vnhJTTm2YlNp1RrL/X6VR5oafctqY9CXmv4JAqY2uS lb8fgwebD5BgG4KgQOdgTIyzsVlr0zG6LlF0OH+Qcnv50XpDFjDGBc8+a X-Received: by 2002:a05:622a:4c06:b0:517:5af6:77f9 with SMTP id d75a77b69052e-51795b3af28mr176324051cf.3.1781012917988; Tue, 09 Jun 2026 06:48:37 -0700 (PDT) X-Received: by 2002:a05:622a:4c06:b0:517:5af6:77f9 with SMTP id d75a77b69052e-51795b3af28mr176323611cf.3.1781012917342; Tue, 09 Jun 2026 06:48:37 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bf05176fd07sm1058537566b.1.2026.06.09.06.48.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Jun 2026 06:48:36 -0700 (PDT) Message-ID: Date: Tue, 9 Jun 2026 15:48:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] regulator: qcom-refgen: add support for the IPQ9650 SoC To: Kathiravan Thirumoorthy , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260602-ipq9650_refgen-v1-0-55e2afa5ff64@oss.qualcomm.com> <20260602-ipq9650_refgen-v1-2-55e2afa5ff64@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260602-ipq9650_refgen-v1-2-55e2afa5ff64@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: NBkqpVK1sbRXBSlQ10jS885QMmpZBTSu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjA5MDEzMSBTYWx0ZWRfX5U5tOcwfNtQ6 3ksQv7DsLo9faERCW+6/ONrLMwfjGOKGpczmDHEZL9QfuCQMRsexLzkaxv7Hnfz2uHLKTXvAizw fZSkK3RAdy4yfTwPx81O4K0xgc+fNFyMY6+4j7edwK16vGc8QhZVjexDz8KPobpVYw78EQIQdJv GmkwBYAztkFj8V/f1bU7v4MHnpsqhvgCb8LjXsn/4TiRwSm/0GYPSvyOQgvnxsmlEsB9Jx2jRW/ O4Uk3Q6fsxpuDOgInd7lyK0Rwea1fznBvml1HE+y8XN/ySqoqMFOMNAfLI+QfRbiWUiLx2Rc7Ui 8eto6dTqNwaaUciYTelinVPlC8uZdFQe83lpQTwaZ15oflcgMKh+zDaXJvHAIBVVNOtcShO+GJI w7bf9ZP3Xj+SGGJ7rJmHgsea32DvHAM8flenxUc9D+CS0i29XYQvjwTRM5+nZ9DJhxNuNekBLFH tGBrxiKamGLgF6/qfoQ== X-Proofpoint-GUID: NBkqpVK1sbRXBSlQ10jS885QMmpZBTSu X-Authority-Analysis: v=2.4 cv=LoqiDHdc c=1 sm=1 tr=0 ts=6a2819b6 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=yEnem_Jrty2UgpzKiIgA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-09_03,2026-06-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 bulkscore=0 phishscore=0 impostorscore=0 adultscore=0 suspectscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606090131 On 6/2/26 11:22 AM, Kathiravan Thirumoorthy wrote: > IPQ9650 SoC has 2 REFGEN blocks providing the reference current to the > PCIe and USB, UNIPHY PHYs. For the other SoCs, clocks for this block is > enabled on power up but that's not the case for IPQ9650 and we have to > enable those clocks explicitly to bring up the PHYs properly. > > As per the design team, REFGEN block provides the reference current. > Hence marked the regulator type as REGULATOR_CURRENT. > > Signed-off-by: Kathiravan Thirumoorthy > --- I'm slightly confused. Is there no register programming needed? Can we at least retrieve the running state in .is_enabled() by reading some value? Konrad