From: Chris Wilson <chris@chris-wilson.co.uk>
To: Indan Zupancic <indan@nul.nu>, Jeff Chua <jeff.chua.linux@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>, Len Brown <lenb@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Commit 500f7147cf5bafd139056d521536b10c2bc2e154 breaks _resume_
Date: Wed, 09 Feb 2011 09:32:09 +0000 [thread overview]
Message-ID: <b7da2f$qco1ng@fmsmga001.fm.intel.com> (raw)
In-Reply-To: <d41841c1e5f524f976edea8cdd075238.squirrel@webmail.greenhost.nl>
On Wed, 9 Feb 2011 03:56:36 +0100 (CET), "Indan Zupancic" <indan@nul.nu> wrote:
> All in all it seems quite wrong, no matter if it happens to work, because
> it depends on the calling order done by the drm layer. If *_crtc_enable()
> is called instead it won't do anything because of that active = true thing.
> This seems to be happening in your case.
The order is very well defined.
modesetting (upon resume we set the previous mode):
for each enabled crtc:
crtc_helper->prepare -> intel_crtc_disable()
crtc->mode_set -> intel_crtc_mode_set()
crtc_helper->commit -> intel_crtc_enable()
for each !enabled crtc:
crtc->disable -> intel_crtc_disable()
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-02-09 9:32 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 1:50 Commit 500f7147cf5bafd139056d521536b10c2bc2e154 breaks _resume_ Jeff Chua
2011-02-06 8:19 ` Marc Koschewski
2011-02-06 11:02 ` Takashi Iwai
2011-02-06 11:06 ` Dave Airlie
2011-02-06 12:21 ` Marc Koschewski
2011-02-06 13:04 ` Rafael J. Wysocki
2011-02-06 13:44 ` Marc Koschewski
2011-02-06 13:55 ` Rafael J. Wysocki
2011-02-06 11:00 ` Takashi Iwai
2011-02-06 12:24 ` Marc Koschewski
2011-02-06 13:19 ` Takashi Iwai
2011-02-06 14:01 ` Jeff Chua
2011-02-06 14:47 ` Chris Wilson
2011-02-06 14:51 ` Jeff Chua
2011-02-06 14:49 ` Jeff Chua
2011-02-06 15:27 ` Chris Wilson
2011-02-07 4:48 ` Jeff Chua
2011-02-07 5:02 ` Jeff Chua
2011-02-07 8:25 ` Takashi Iwai
2011-02-07 8:36 ` Jeff Chua
2011-02-07 8:45 ` Jeff Chua
2011-02-07 8:54 ` Takashi Iwai
2011-02-07 8:52 ` Takashi Iwai
2011-02-07 10:15 ` Takashi Iwai
2011-02-07 13:38 ` Jeff Chua
2011-02-07 14:11 ` Jeff Chua
2011-02-07 21:20 ` Rafael J. Wysocki
2011-02-08 1:40 ` Jeff Chua
2011-02-08 13:36 ` Chris Wilson
2011-02-09 0:55 ` Jeff Chua
2011-02-09 1:05 ` Jeff Chua
2011-02-09 2:56 ` Indan Zupancic
2011-02-09 5:45 ` Jeff Chua
2011-02-09 9:42 ` Indan Zupancic
2011-02-09 9:32 ` Chris Wilson [this message]
2011-02-09 10:20 ` Indan Zupancic
2011-02-07 10:02 ` Marc Koschewski
2011-02-07 10:06 ` Takashi Iwai
2011-02-07 10:09 ` Marc Koschewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b7da2f$qco1ng@fmsmga001.fm.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=indan@nul.nu \
--cc=jeff.chua.linux@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox