From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760400AbdJRD6D (ORCPT ); Tue, 17 Oct 2017 23:58:03 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:34848 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758893AbdJRD6B (ORCPT ); Tue, 17 Oct 2017 23:58:01 -0400 Subject: Re: [PATCH] input: touchscreen: ti_am335x_tsc: Fix incorrect step config for 5 wire touchscreen To: Dmitry Torokhov CC: , , References: <20170919062906.501-1-vigneshr@ti.com> From: Vignesh R Message-ID: Date: Wed, 18 Oct 2017 09:28:01 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20170919062906.501-1-vigneshr@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 19 September 2017 11:59 AM, Vignesh R wrote: > From: Jeff Lance > > Step config setting for 5 wire touchscreen is incorrect for Y coordinates. > It was broken while we moved to DT. If you look close at the offending > commit bb76dc09ddfc ("input: ti_am33x_tsc: Order of TSC wires, made > configurable"), the change was: > > - STEPCONFIG_XNP | STEPCONFIG_YPN; > + ts_dev->bit_xn | ts_dev->bit_yp; > > while bit_xn = STEPCONFIG_XNN and bit_yp = STEPCONFIG_YNN. Not quite the > same. > > Fixes: bb76dc09ddfc ("input: ti_am33x_tsc: Order of TSC wires, made configurable") > Signed-off-by: Jeff Lance > [vigneshr@ti.com: Rebase to v4.14-rc1] > Signed-off-by: Vignesh R > --- > Gentle ping... > Tested on AM335x EVM with 5 wire tsc module. Also sanity tested > on a 4 wire tsc as well. > > drivers/input/touchscreen/ti_am335x_tsc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c > index 7953381d939a..f1043ae71dcc 100644 > --- a/drivers/input/touchscreen/ti_am335x_tsc.c > +++ b/drivers/input/touchscreen/ti_am335x_tsc.c > @@ -161,7 +161,7 @@ static void titsc_step_config(struct titsc *ts_dev) > break; > case 5: > config |= ts_dev->bit_xp | STEPCONFIG_INP_AN4 | > - ts_dev->bit_xn | ts_dev->bit_yp; > + STEPCONFIG_XNP | STEPCONFIG_YPN; > break; > case 8: > config |= ts_dev->bit_yp | STEPCONFIG_INP(ts_dev->inp_xp); > -- Regards Vignesh