From: Krzysztof Kozlowski <krzk@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>,
	Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
	Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sebastian Reichel <sre@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Andreas Kemnade <andreas@kemnade.info>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-rtc@vger.kernel.org
Subject: Re: [PATCH v2 02/15] dt-bindings: Add trickle-charge upper limit
Date: Wed, 29 Oct 2025 14:33:39 +0100	[thread overview]
Message-ID: <b81502cc-d91d-4801-ad72-034c20b1c72a@kernel.org> (raw)
In-Reply-To: <CACRpkdZcszMZEU2Wzx8kaoR46ytziqtedmCrsjEL3QOrDtDgzg@mail.gmail.com>
On 29/10/2025 14:26, Linus Walleij wrote:
> On Wed, Oct 29, 2025 at 7:22 AM Matti Vaittinen
> <mazziesaccount@gmail.com> wrote:
> 
>>> But I believe this is wrong. Trickle charging does not switch to
>>> anything more, there is no fast charging after trickle. You have some
>>> sort of pre-pre-charging, which is just pre-charging.
>>
>> There is trickle, pre and fast-charge phases. Furthermore, the
>> fast-charge is further divided to CC and CV. Finally, if my memory
>> serves me well, Linus W did explain me that some chargers use
>> 'trickle-charging' as a _last_ charging phase for a full battery. Thus
>> the term 'trickle-charging' is slightly confusing - but it is already
>> used by the existing bindings...
>>
>> https://lore.kernel.org/all/20211116001755.2132036-1-linus.walleij@linaro.org/
> 
> I think we need to refer to a textbook or IEEE articles to get this
> terminology right.
> 
> As you say it appears "trickle-charging" is ambiguous.
> 
> Maybe what Krzysztof suggest to use: "pre-pre-charging" or
> "empty-battery-charging" or something like this is needed.
> 
> But we really need a trustworthy academic source here.
Trickle charging is accurate for both cases - pre-pre and top-off -
because it just describes very small current. That's why I found it in
many TI datasheets - mostly for Li-Ion batteries describing Matti's
case, but also in at least one case for Ni-Mh describing top-off (or
maintenance).
I am fine with the naming, but I want to be clear that this property
will describe trickle only in case of pre-pre charging. Termination
voltage simply does not fit the top-off/maintenance mode.
Best regards,
Krzysztof
next prev parent reply	other threads:[~2025-10-29 13:33 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-27 11:44 [PATCH v2 00/15] Support ROHM BD72720 PMIC Matti Vaittinen
2025-10-27 11:44 ` [PATCH v2 01/15] dt-bindings: regulator: ROHM BD72720 Matti Vaittinen
2025-10-27 21:03   ` Rob Herring
2025-10-27 11:45 ` [PATCH v2 02/15] dt-bindings: Add trickle-charge upper limit Matti Vaittinen
2025-10-29  6:03   ` Krzysztof Kozlowski
2025-10-29  6:17     ` Krzysztof Kozlowski
2025-10-29  6:24       ` Matti Vaittinen
2025-10-29  6:22     ` Matti Vaittinen
2025-10-29  6:32       ` Matti Vaittinen
2025-10-29 13:26       ` Linus Walleij
2025-10-29 13:33         ` Krzysztof Kozlowski [this message]
2025-10-27 11:45 ` [PATCH v2 03/15] dt-bindings: power: supply: BD72720 managed battery Matti Vaittinen
2025-10-27 21:08   ` Rob Herring
2025-10-27 22:34   ` Linus Walleij
2025-10-27 11:45 ` [PATCH v2 04/15] dt-bindings: mfd: ROHM BD72720 Matti Vaittinen
2025-10-27 21:13   ` Rob Herring
2025-10-29 12:22     ` Matti Vaittinen
2025-10-27 21:20   ` Andreas Kemnade
2025-10-29 12:23     ` Matti Vaittinen
2025-10-27 22:42   ` Linus Walleij
2025-10-29 12:30     ` Matti Vaittinen
2025-10-29 13:08       ` Linus Walleij
2025-10-27 11:46 ` [PATCH v2 05/15] dt-bindings: leds: bd72720: Add BD72720 Matti Vaittinen
2025-10-28  8:25   ` Krzysztof Kozlowski
2025-10-27 11:46 ` [PATCH v2 06/15] mfd: rohm-bd71828: Use regmap_reg_range() Matti Vaittinen
2025-10-27 11:46 ` [PATCH v2 08/15] regulator: bd71828: rename IC specific entities Matti Vaittinen
2025-10-27 12:14   ` Mark Brown
2025-10-27 11:47 ` [PATCH v2 09/15] regulator: bd71828: Support ROHM BD72720 Matti Vaittinen
2025-10-27 12:15   ` Mark Brown
2025-10-27 11:47 ` [PATCH v2 10/15] gpio: Support ROHM BD72720 gpios Matti Vaittinen
2025-10-27 11:47 ` [PATCH v2 11/15] clk: clk-bd718x7: Support BD72720 clk gate Matti Vaittinen
2025-10-27 11:47 ` [PATCH v2 12/15] rtc: bd70528: Support BD72720 rtc Matti Vaittinen
2025-10-27 12:38   ` Alexandre Belloni
2025-10-27 13:02     ` Matti Vaittinen
2025-10-27 11:48 ` [PATCH v2 13/15] power: supply: bd71828: Support wider register addresses Matti Vaittinen
2025-10-27 11:48 ` [PATCH v2 14/15] power: supply: bd71828-power: Support ROHM BD72720 Matti Vaittinen
2025-10-27 11:48 ` [PATCH v2 15/15] MAINTAINERS: Add ROHM BD72720 PMIC Matti Vaittinen
2025-10-28  6:06 ` [PATCH v2 07/15] mfd: bd71828: Support ROHM BD72720 Matti Vaittinen
2025-10-28  6:39 ` [PATCH v2 00/15] Support ROHM BD72720 PMIC Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=b81502cc-d91d-4801-ad72-034c20b1c72a@kernel.org \
    --to=krzk@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andreas@kemnade.info \
    --cc=brgl@bgdev.pl \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=mazziesaccount@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=pavel@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).