From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751926AbdHGC7y (ORCPT ); Sun, 6 Aug 2017 22:59:54 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38672 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751513AbdHGC7w (ORCPT ); Sun, 6 Aug 2017 22:59:52 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D17F66022B Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH V8 1/2] PCI: handle CRS returned by device after FLR To: linux-pci@vger.kernel.org, timur@codeaurora.org, alex.williamson@redhat.com Cc: linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjorn Helgaas , linux-kernel@vger.kernel.org References: <1502071792-15263-1-git-send-email-okaya@codeaurora.org> From: Sinan Kaya Message-ID: Date: Sun, 6 Aug 2017 22:59:49 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1502071792-15263-1-git-send-email-okaya@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/6/2017 10:09 PM, Sinan Kaya wrote: > + pcie_capability_read_word(dev, PCI_EXP_RTCAP, &root_cap); > + if (root_cap & PCI_EXP_RTCAP_CRSVIS) { > + /* don't touch the HW before waiting 100ms */ > + msleep(100); This is obviously broken. I should have checked the capability on the root port. I was trying to get it out before Monday. However, I still want to hear about the preference of this methodology. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.