From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 423D447276E for ; Mon, 29 Jun 2026 17:24:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782753866; cv=none; b=mTri7b+ELA0MlRe30FOQqXAzHR8PG1Ze1UgbAXnc2d1ZzRslmetfMt8pFAU8jzR59CTvnEktLgL5Wb8BV8ihPuRyi+6zujxvr+oMnh1miSnveHD4YTUgg0IOJqcSDWxWybTpZtgCS317/JMJKYOFYVvZbYmdkQWD/7DXZ/RTnnA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782753866; c=relaxed/simple; bh=eg1oTq9t7UFsafEJ/rCjarmIEI/bnIocyCGkwgmH+tU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f/TyWU+V0UaVXPAr3lWGyT8Obe2C0zav+d7LpEzL4sMKVVnKDVUGCC2o7O8TbR/2tg4nXYcNMgYZ8JlyUW7Llz26vPdVgUy/nJQDubDQGsRILzZVco7hqUyp1uU+D2T1OoONoOfPoY9SM7plyBg0pYK3whpSFtS1wfvYWRTdYSs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=gFeb3XnT; arc=none smtp.client-ip=91.218.175.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="gFeb3XnT" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782753852; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IZNbbav3TlayBnL24voJZl6NnED9LU5K9rl2Lg6cBNo=; b=gFeb3XnTM6SMtm27Y9liMgdbo8RGjXGKPEII6Ieiw6WvJavwMB++05Dylmkt5UtsT6UsRT 0h1qePfTwxkE4guHUbDxrFEWSlFTOQWk40xF46QauPYEgjSeDAoRQj+F1Km9RY8hJ77LQe O6GAeunG+xJo1ElZsdmCg6mSDK+fVh4= Date: Mon, 29 Jun 2026 18:23:58 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2 2/2] mm/vmpressure: split v1 userspace eventfd code into vmpressure-v1.c To: Johannes Weiner Cc: Andrew Morton , david@kernel.org, linux-mm@kvack.org, tj@kernel.org, mkoutny@suse.com, shakeel.butt@linux.dev, roman.gushchin@linux.dev, liam@infradead.org, linux-kernel@vger.kernel.org, ljs@kernel.org, mhocko@suse.com, rppt@kernel.org, surenb@google.com, vbabka@kernel.org, kernel-team@meta.com References: <20260629130042.2649505-1-usama.arif@linux.dev> <20260629130042.2649505-3-usama.arif@linux.dev> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Usama Arif In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 29/06/2026 17:48, Johannes Weiner wrote: > On Mon, Jun 29, 2026 at 05:59:37AM -0700, Usama Arif wrote: >> @@ -101,7 +101,7 @@ obj-$(CONFIG_DEVICE_MIGRATION) += migrate_device.o >> obj-$(CONFIG_TRANSPARENT_HUGEPAGE) += huge_memory.o khugepaged.o >> obj-$(CONFIG_PAGE_COUNTER) += page_counter.o >> obj-$(CONFIG_LIVEUPDATE_MEMFD) += memfd_luo.o >> -obj-$(CONFIG_MEMCG_V1) += memcontrol-v1.o >> +obj-$(CONFIG_MEMCG_V1) += memcontrol-v1.o vmpressure-v1.o > > Might as well move the interface part to memcontrol-v1.c instead of > creating a new file. > I think it would make it easier once we move cgroup v2 off of vmpressure. Then we can rename vmpressure-v1.c to just vmpressure.c and gate it to CONFIG_MEMCG_V1. The other option would be everything living in memcontrol-v1.c? I think its nice to keep it separate as memcontrol-v1.c is already 2K+ lines and this is standalone feature that can sit in a separate file. > Otherwise looks good to me.