The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Holalu Yogendra, Niranjan" <niranjan.hy@ti.com>
To: Andrey Golovko <andrey.golovko@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Vinod Koul <vkoul@kernel.org>,
	Bard Liao <yung-chuan.liao@linux.intel.com>,
	Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
	Mario Limonciello <superm1@kernel.org>,
	Antoine Monnet <antoine@montane.tech>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Pierre-Louis Bossart" <pierre-louis.bossart@linux.dev>,
	"Lu, Kevin" <kevin-lu@ti.com>,
	"Ding, Shenghao" <shenghao-ding@ti.com>,
	"Xu, Baojun" <baojun.xu@ti.com>, "Wang, Sen" <sen@ti.com>,
	"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>
Subject: Re: ASoC: tas2783-sdw: port prepare never completes after S0i3, no audio and no error (AMD ACP7.0, ASUS ProArt PX13)
Date: Tue, 28 Jul 2026 07:31:36 +0000	[thread overview]
Message-ID: <b863334f983a42888d0de5973a998020@ti.com> (raw)
In-Reply-To: <c6b9b217-3678-42d8-8e01-7fdbf7c67c7a@linux.dev>

> On 19:39-20260727, Pierre-Louis Bossart wrote:
> Subject: Re: ASoC: tas2783-sdw: port prepare never completes after S0i3, no audio and no error (AMD ACP7.0, ASUS ProArt PX13)
> 
> >On 7/27/26 11:33, Andrey Golovko wrote:

> > Questions
> > ---------
> >  - Should TAS2783 declare simple_ch_prep_sm at all? The port evidently
> >    does not prepare instantaneously, which is the premise of that
> >    property; letting the core do its normal write-and-poll would at least
> >    turn this into a visible error instead of silence.
> >  - If the property is correct, should tas_port_prep() poll
> >    DPn_PrepareStatus after writing DPn_PrepareCtrl, mirroring what the
> >    core does?

We need to use the same BIOS between Windows and Linux, the BIOS sets the device as Simplified_CP_SM.

The device expects the DPn_PrepareCtrl bits to be set to be functional - but doesn't update DPn_PrepareStatus.

If the device is configured as generic CP_SM, the DPn_PrepareStatus bits will not be updated.
Hence we end up with port prepare fail errors even for normal scenario where it could produce audio.
So, the changes were added in the codec driver to explicitly write DPn_PrepareCtrl even in simplified CP_SM
and ignore the DPn_PrepareStatus. 

Regards
Niranjan

  reply	other threads:[~2026-07-28  7:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27  9:33 ASoC: tas2783-sdw: port prepare never completes after S0i3, no audio and no error (AMD ACP7.0, ASUS ProArt PX13) Andrey Golovko
2026-07-27 14:08 ` Pierre-Louis Bossart
2026-07-28  7:31   ` Holalu Yogendra, Niranjan [this message]
2026-08-07  5:21     ` Andrey Golovko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b863334f983a42888d0de5973a998020@ti.com \
    --to=niranjan.hy@ti.com \
    --cc=Vijendar.Mukunda@amd.com \
    --cc=andrey.golovko@gmail.com \
    --cc=antoine@montane.tech \
    --cc=baojun.xu@ti.com \
    --cc=broonie@kernel.org \
    --cc=kevin-lu@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=sen@ti.com \
    --cc=shenghao-ding@ti.com \
    --cc=superm1@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox