From: Yonghong Song <yhs@meta.com>
To: Arnd Bergmann <arnd@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
John Fastabend <john.fastabend@gmail.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] [v3] bpf: hide unused bpf_patch_call_args
Date: Tue, 6 Jun 2023 15:46:49 -0700 [thread overview]
Message-ID: <b896db61-2ee1-44c8-ebb7-930e3033df42@meta.com> (raw)
In-Reply-To: <20230602135128.1498362-1-arnd@kernel.org>
On 6/2/23 6:50 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This function is only used when CONFIG_BPF_JIT_ALWAYS_ON is disabled,
> but CONFIG_BPF_SYSCALL is enabled. When both are turned off, the
> prototype is missing but the unused function is still compiled,
> as seen from this W=1 warning:
>
> kernel/bpf/core.c:2075:6: error: no previous prototype for 'bpf_patch_call_args' [-Werror=missing-prototypes]
>
> Add a matching #ifdef for the definition to leave it out.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Yonghong Song <yhs@fb.com>
prev parent reply other threads:[~2023-06-06 22:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 13:50 [PATCH 1/2] [v3] bpf: hide unused bpf_patch_call_args Arnd Bergmann
2023-06-02 13:50 ` [PATCH 2/2] [v3] bpf: fix bpf_probe_read_kernel prototype mismatch Arnd Bergmann
2023-06-06 22:49 ` Yonghong Song
2023-06-12 17:04 ` Daniel Borkmann
2023-06-06 22:46 ` Yonghong Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b896db61-2ee1-44c8-ebb7-930e3033df42@meta.com \
--to=yhs@meta.com \
--cc=Jason@zx2c4.com \
--cc=andrii@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox