public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srini@kernel.org>
To: Rob Herring <robh@kernel.org>,
	Srinivas Kandagatla <srini@kernel.org>,
	Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slimbus: qcom: remove unused qcom controller driver
Date: Wed, 1 Oct 2025 15:21:55 +0100	[thread overview]
Message-ID: <b8c1365a-545d-40ae-a39c-e15a3e1f07e7@kernel.org> (raw)
In-Reply-To: <CAL_JsqLcinpeJyib+JG7UFspUqXDTzCLguF3Nt4JJY9YncTb9A@mail.gmail.com>



On 10/1/25 3:19 PM, Rob Herring wrote:
> +Greg
> 
> On Fri, Sep 19, 2025 at 12:25 PM Rob Herring <robh@kernel.org> wrote:
>>
>> On Fri, Sep 5, 2025 at 12:30 AM Srinivas Kandagatla <srini@kernel.org> wrote:
>>>
>>>
>>>
>>> On 9/5/25 12:08 AM, Rob Herring wrote:
>>>> On Tue, Aug 19, 2025 at 8:44 AM Srinivas Kandagatla
>>>> <srinivas.kandagatla@oss.qualcomm.com> wrote:
>>>>>
>>>>> Thanks Rob for reporting this,
>>>>>
>>>>> On 8/19/25 2:35 PM, Rob Herring wrote:
>>>>>> On Thu, Jul 24, 2025 at 8:28 AM <srinivas.kandagatla@oss.qualcomm.com> wrote:
>>>>>>>
>>>>>>> From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
>>>>>>>
>>>>>>> Qcom Slimbus controller driver is totally unused and dead code, there is
>>>>>>> no point in keeping this driver in the kernel without users.
>>>>>>>
>>>>>>> This patch removes the driver along with device tree bindings.
>>>>>>>
>>>>>>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
>>>>>>> ---
>>>>>>>  .../bindings/slimbus/qcom,slim.yaml           |  86 --
>>>>>>>  drivers/slimbus/Kconfig                       |   7 -
>>>>>>>  drivers/slimbus/Makefile                      |   3 -
>>>>>>>  drivers/slimbus/qcom-ctrl.c                   | 735 ------------------
>>>>>>>  4 files changed, 831 deletions(-)
>>>>>>>  delete mode 100644 Documentation/devicetree/bindings/slimbus/qcom,slim.yaml
>>>>>>>  delete mode 100644 drivers/slimbus/qcom-ctrl.c
>>>>>>
>>>>>> This adds warnings to dt_binding_check:
>>>>>>
>>>>>> Documentation/devicetree/bindings/slimbus/slimbus.example.dtb:
>>>>>> /example-0/soc/slim@28080000: failed to match any schema with
>>>>>> compatible: ['qcom,apq8064-slim', 'qcom,slim']
>>>>>
>>>>> Will replace this example with slim-ngd and fold it in the original patch.
>>>>
>>>> Still warning in linux-next...
>>> Its done now!
>>
>> Now I get this:
>>
>> Documentation/devicetree/bindings/slimbus/slimbus.example.dtb:
>> slim@28080000 (qcom,slim-ngd-v1.5.0): 'audio-codec@1,0' does not match
>> any of the regexes: '^pinctrl-[0-9]+$', '^slim@[0-9a-f]+$'
>>         from schema $id:
>> http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml#
>> Documentation/devicetree/bindings/slimbus/slimbus.example.dtb:
>> slim@28080000 (qcom,slim-ngd-v1.5.0): #address-cells: 1 was expected
>>         from schema $id:
>> http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml#
>> Documentation/devicetree/bindings/slimbus/slimbus.example.dtb:
>> slim@28080000 (qcom,slim-ngd-v1.5.0): 'dmas' is a required property
>>         from schema $id:
>> http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml#
>> Documentation/devicetree/bindings/slimbus/slimbus.example.dtb:
>> slim@28080000 (qcom,slim-ngd-v1.5.0): 'dma-names' is a required
>> property
>>         from schema $id:
>> http://devicetree.org/schemas/slimbus/qcom,slim-ngd.yaml#
> 
> Still failing in linux-next.

Rob, sorry for delay..

will send a fix,


--srini

> 
> Rob


  reply	other threads:[~2025-10-01 14:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-24 13:28 [PATCH] slimbus: qcom: remove unused qcom controller driver srinivas.kandagatla
2025-07-24 13:31 ` Konrad Dybcio
2025-07-24 14:24   ` Dmitry Baryshkov
2025-07-27 11:25     ` Srinivas Kandagatla
2025-07-27 16:12       ` Dmitry Baryshkov
2025-07-28  9:24     ` Luca Weiss
2025-07-25 23:23 ` Rob Herring (Arm)
2025-08-18  6:48 ` Srinivas Kandagatla
2025-08-19 13:35 ` Rob Herring
2025-08-19 13:44   ` Srinivas Kandagatla
2025-09-04 23:08     ` Rob Herring
2025-09-05  5:30       ` Srinivas Kandagatla
2025-09-19 17:25         ` Rob Herring
2025-10-01 14:19           ` Rob Herring
2025-10-01 14:21             ` Srinivas Kandagatla [this message]
2025-10-01 15:03               ` Srinivas Kandagatla
2025-10-01 15:31                 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8c1365a-545d-40ae-a39c-e15a3e1f07e7@kernel.org \
    --to=srini@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox