From: Paolo Bonzini <pbonzini@redhat.com>
To: Yu Zhang <yu.c.zhang@linux.intel.com>, kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, rkrcmar@redhat.com,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
xiaoguangrong@tencent.com, joro@8bytes.org
Subject: Re: [PATCH v2 1/5] KVM: x86: Add return value to kvm_cpuid().
Date: Thu, 17 Aug 2017 15:18:18 +0200 [thread overview]
Message-ID: <b8cd5ec7-d679-a3fe-77fc-c4ec277dd63b@redhat.com> (raw)
In-Reply-To: <9e7e9117-12a6-aae1-8c36-28a7a50282b6@linux.intel.com>
On 17/08/2017 14:33, Yu Zhang wrote:
>>>>
>>>> +enum {
>>>> + NO_CHECK_LIMIT = 0,
>>>> + CHECK_LIMIT = 1,
>>>> +};
>>> emulate.c should not include cpuid.h. The argument can be simply a
>>> bool, though.
>>
>> Thanks, Paolo.
>> So we just use true/false in emulate.c & svm.c, is this OK?
I would use true/false everywhere.
>> BTW could you please
> Sorry for the unfinished line. I was wondering, why can't emulate.c
> include cpuid.h?
The emulator should be separate from the rest of KVM, in principle it
could be used by userspace too. So its interface should be as limited
as possible.
Paolo
next prev parent reply other threads:[~2017-08-17 13:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 19:52 [PATCH v2 0/5] KVM: MMU: 5 level EPT/shadow support Yu Zhang
2017-08-17 19:52 ` [PATCH v2 1/5] KVM: x86: Add return value to kvm_cpuid() Yu Zhang
2017-08-17 12:29 ` Paolo Bonzini
2017-08-17 12:23 ` Yu Zhang
2017-08-17 12:33 ` Yu Zhang
2017-08-17 13:18 ` Paolo Bonzini [this message]
2017-08-17 13:17 ` Paolo Bonzini
2017-08-17 13:20 ` Yu Zhang
2017-08-17 14:29 ` Paolo Bonzini
2017-08-17 19:52 ` [PATCH v2 2/5] KVM: MMU: check guest CR3 reserved bits based on its physical address width Yu Zhang
2017-08-17 12:31 ` Paolo Bonzini
2017-08-17 12:25 ` Yu Zhang
2017-08-17 19:52 ` [PATCH v2 3/5] KVM: MMU: Rename PT64_ROOT_LEVEL to PT64_ROOT_4LEVEL Yu Zhang
2017-08-17 19:52 ` [PATCH v2 4/5] KVM: MMU: Add 5 level EPT & Shadow page table support Yu Zhang
2017-08-17 19:52 ` [PATCH v2 5/5] KVM: MMU: Expose the LA57 feature to VM Yu Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8cd5ec7-d679-a3fe-77fc-c4ec277dd63b@redhat.com \
--to=pbonzini@redhat.com \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=xiaoguangrong@tencent.com \
--cc=yu.c.zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).